Re: [PATCH v3 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-14 Thread Stephen Boyd
On 08/14/13 05:59, Ivan T. Ivanov wrote: +} + +static const struct of_device_id of_dwc3_matach[] = { match? Maybe you can make it all one line too { .compatible = qcom,dwc3 } + { + .compatible = qcom,dwc3, + }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_dwc3_matach);

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-19 Thread Stephen Boyd
On 08/19/13 05:27, Ivan T. Ivanov wrote: Hi, On Fri, 2013-08-16 at 16:44 -0600, Stephen Warren wrote: On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and

Re: [PATCH] usb: phy: msm: fix possible build error

2014-02-18 Thread Stephen Boyd
On 02/18, Felipe Balbi wrote: This will fail builds on configs where CONFIG_PM_RUNTIME=y and CONFIG_PM_SLEEP=n. Following build error will show up: drivers/usb/phy/phy-msm-usb.c: In function ???msm_otg_runtime_suspend???: drivers/usb/phy/phy-msm-usb.c:1693:2: error: implicit declaration

[PATCH 00/12] Convert MSM to common clock framework

2013-06-04 Thread Stephen Boyd
). It also removes some custom clock APIs that MSM provides and finally moves the proc_comm clock code to the common struct clk. This patch series will be used as the foundation of the MSM 8660/8960 clock code that I plan to send out after this series. Stephen Boyd (12): msm_serial: Convert

[PATCH 03/12] usb: otg: msm: Convert to clk_prepare/unprepare

2013-06-04 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/usb/phy/phy-msm-usb.c | 38 +++--- 1 file changed, 19 insertions(+), 19

[PATCH/RESEND 03/12] usb: otg: msm: Convert to clk_prepare/unprepare

2013-06-17 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/usb/phy/phy-msm-usb.c | 38 +++--- 1 file changed, 19 insertions(+), 19

sleeping while atomic in dwc3_gadget_start

2013-06-26 Thread Stephen Boyd
Hi, I'm getting the folllowing BUG message on bootup with 3.10-rc5 BUG: sleeping function called from invalid context at mm/slub.c:926 in_atomic(): 1, irqs_disabled(): 128, pid: 1, name: swapper/0 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.0-rc5-gee3e35b-09316-ge78f3b35 #643 [c0014220]

Re: sleeping while atomic in dwc3_gadget_start

2013-06-27 Thread Stephen Boyd
On 06/26/13 23:58, Felipe Balbi wrote: On Wed, Jun 26, 2013 at 02:52:56PM -0700, Stephen Boyd wrote: Hi, I'm getting the folllowing BUG message on bootup with 3.10-rc5 BUG: sleeping function called from invalid context at mm/slub.c:926 in_atomic(): 1, irqs_disabled(): 128, pid: 1, name

[PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare

2012-09-20 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/usb/otg/msm_otg.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions

[PATCH 00/10] Convert MSM to common clock framework

2012-09-20 Thread Stephen Boyd
() function which I already posted to the list[1]. They're based on linux-next-20120917. Stephen Boyd (10): usb: otg: msm: Convert to clk_prepare/unprepare msm_sdcc: Convert to clk_prepare/unprepare msm: iommu: Convert to clk_prepare/unprepare msm: iommu: Use clk_set_rate() instead

Re: [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare

2012-09-26 Thread Stephen Boyd
On 09/26/12 09:58, Pankaj Jangra wrote: On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd sb...@codeaurora.org wrote: diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c index 9f5fc90..2ae0639 100644 --- a/drivers/usb/otg/msm_otg.c +++ b/drivers/usb/otg/msm_otg.c @@ -514,13

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-26 Thread Stephen Boyd
On 12/20, David Brown wrote: On Thu, Dec 19, 2013 at 05:26:13PM -0600, Felipe Balbi wrote: it's getting quite late for me. I still want to leave my stuff soaking in linux-next for a while. I'll try my best, though, if you ack it ASAP Thanks. Patch 1 already has my Ack in it, and I've sent

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Stephen Boyd
Yay nitpicks! On 09/12/14 10:29, Andy Gross wrote: + +struct qcom_dwc3_usb_phy { + void __iomem*base; + struct device *dev; + struct phy *phy; Align with other members? + +static int wait_for_latch(void __iomem *addr) +{ + u32 retry = 10; Why not

Re: [PATCH 1/8] usb: add bus type for USB ULPI

2015-02-12 Thread Stephen Boyd
On 01/23/15 07:12, Heikki Krogerus wrote: diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c index e614ef6..753cb08 100644 --- a/scripts/mod/file2alias.c +++ b/scripts/mod/file2alias.c @@ -1176,6 +1176,19 @@ static int do_rio_entry(const char *filename, }

[PATCH 00/12] Remove mach-msm and associated code

2015-03-13 Thread Stephen Boyd
-soc. Although some patches should be fine to take through maintainers, some things like mmc and usb have header file dependencies for platform_data. [1] http://lkml.kernel.org/r/20150307031212.ga8...@fifo99.com Stephen Boyd (12): ARM: Remove mach-msm and associated ARM architecture code gpio

[PATCH 08/12] ehci-msm: Remove dead dependency

2015-03-13 Thread Stephen Boyd
dwal...@fifo99.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- This can be acked and go through arm-soc or applied directly to usb tree. drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index

[PATCH 09/12] usb: phy: msm: Remove dead code

2015-03-13 Thread Stephen Boyd
.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- This needs an ack to go through arm-soc with patch 1 that removes the platform code using these ops. drivers/usb/phy/Kconfig | 2 +- drivers/usb/phy/phy-msm-usb.c | 18 ++ include/linux/usb/msm_hsusb.h | 4 3

Re: [PATCH 00/12] Remove mach-msm and associated code

2015-03-13 Thread Stephen Boyd
On 03/13/15 12:55, Arnd Bergmann wrote: On Friday 13 March 2015 11:09:33 Stephen Boyd wrote: The maintainers for mach-msm no longer have any plans to support or test the platforms supported by this architecture[1]. Most likely there aren't any active users of this code anyway, so let's delete

Re: [PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-01 Thread Stephen Boyd
Quoting Peter Chen (2016-06-01 05:05:20) > On Wed, Jun 01, 2016 at 01:57:23AM -0700, Stephen Boyd wrote: > > Quoting Krzysztof Kozlowski (2016-06-01 01:02:18) > > > Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq > > > device. The pwrseq dev

Re: [PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-01 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2016-06-01 01:02:18) > Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq > device. The pwrseq device will be used by USB hub to cycle the power > before activating ports. > > Signed-off-by: Krzysztof Kozlowski Drive by

Re: [PATCH 0/2] usb: phy: Add support for the Qualcomm HSIC USB PHY

2016-06-17 Thread Stephen Boyd
On 06/17/2016 03:25 AM, Neil Armstrong wrote: > In order to support the Qualcomm MDM9615 in the Sierra Wireless WP8548 > Modules, add the Qualcomm HSIC USB PHY used inside the MDM9615 SoC. > > This patchset is part of a global SoC + Module + Board support for the > Sierra Wireless mangOH Board

[PATCH] usb: otg-fsm: Cancel HNP polling work when not used

2016-06-27 Thread Stephen Boyd
n <gre...@linuxfoundation.org> Fixes: ae57e97a9521 ("usb: common: otg-fsm: add HNP polling support") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/common/usb-otg-fsm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/common

RE: [PATCH 04/21] usb: chipidea: Only read/write OTGSC from one place

2016-06-27 Thread Stephen Boyd
Quoting Jun Li (2016-06-27 01:04:39) > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index > > 03b6743461d1..763a8332b009 100644 > > --- a/drivers/usb/chipidea/otg.c > > +++ b/drivers/usb/chipidea/otg.c > > @@ -104,7 +104,32 @@ void ci_handle_vbus_change(struct ci_hdrc

[PATCH 03/21] usb: ulpi: Avoid reading/writing in device creation with OF devices

2016-06-26 Thread Stephen Boyd
to power on the device but haven't figured out which device it is yet to know what sort of regulators, clks, etc. that need to be turned on for it to work. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by:

[PATCH 12/21] usb: chipidea: msm: Keep device runtime enabled

2016-06-26 Thread Stephen Boyd
, etc. for finer grain power management later, but this is necessary to make sure we can keep accessing the device right now. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- dr

[PATCH 18/21] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-06-26 Thread Stephen Boyd
artman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 43 +- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chip

[PATCH 19/21] usb: chipidea: msm: Be silent on probe defer errors

2016-06-26 Thread Stephen Boyd
If something fails in ci_hdrc_add_device() due to probe defer, we shouldn't print an error message. Be silent in this case as we'll try probe again later. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.

[PATCH 06/21] usb: chipidea: Initialize and reinitialize phy later

2016-06-26 Thread Stephen Boyd
is properly managed across role switches. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci.h | 3 ++- drivers/usb/chipidea/core.c | 23 ++- dr

[PATCH 04/21] usb: chipidea: Only read/write OTGSC from one place

2016-06-26 Thread Stephen Boyd
t; Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/core.c | 32 drivers/usb/chipidea/otg.c | 35 +++ 2 f

[PATCH 21/21] phy: Add support for Qualcomm's USB HS phy

2016-06-26 Thread Stephen Boyd
The high-speed phy on qcom SoCs is controlled via the ULPI viewport. Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- .../devicetree/bindings/phy/qcom,usb-hs-phy.txt| 71 ++ d

[PATCH 08/21] usb: chipidea: Kick OTG state machine for AVVIS with vbus extcon

2016-06-26 Thread Stephen Boyd
r.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/otg_fsm.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipid

[PATCH 09/21] usb: chipidea: Add support for ULPI PHY bus

2016-06-26 Thread Stephen Boyd
Kroah-Hartman <gre...@linuxfoundation.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/Kconfig | 7 +++ drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci.h | 20 ++

[PATCH 17/21] usb: chipidea: msm: Make platform data driver local instead of global

2016-06-26 Thread Stephen Boyd
of this structure per each device instance so that odd things don't happen. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 19 ---

[PATCH 20/21] phy: Add support for Qualcomm's USB HSIC phy

2016-06-26 Thread Stephen Boyd
The HSIC USB controller on qcom SoCs has an integrated all digital phy controlled via the ULPI viewport. Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- .../devicetree/bindings/phy/qcom,usb-h

[PATCH 05/21] usb: chipidea: Handle extcon events properly

2016-06-26 Thread Stephen Boyd
Ivanov" <iivanov...@gmail.com> Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/otg.c | 46 +++- include/linux

[PATCH 10/21] usb: chipidea: msm: Rely on core to override AHBBURST

2016-06-26 Thread Stephen Boyd
<peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/dr

[PATCH 07/21] usb: chipidea: Notify of reset when switching into host mode

2016-06-26 Thread Stephen Boyd
in the usb command register. Therefore, add this event hook in the host role after we toggle that bit. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/host.c | 3 +

[PATCH] usb: ulpi: Automatically set driver::owner with ulpi_driver_register()

2016-06-25 Thread Stephen Boyd
oge...@linux.intel.com> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/common/ulpi.c | 5 +++-- include/linux/ulpi/driver.h | 6 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index

[PATCH 16/21] usb: chipidea: msm: Restore wrapper settings after reset

2016-06-26 Thread Stephen Boyd
consolidate the register writes into the wrapper driver instead so that we clearly split the wrapper from the phys. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chip

[PATCH 00/21] Support qcom's HSIC USB and rewrite USB2 HS phy support

2016-06-26 Thread Stephen Boyd
[1] https://lkml.org/lkml/2016/2/22/7 [2] http://lkml.kernel.org/g/1449621618-11900-1-git-send-email-tim.b...@sonymobile.com [3] https://git.linaro.org/people/stephen.boyd/linux.git/shortlog/refs/heads/usb-hsic-8074 Stephen Boyd (21): of: device: Support loading a module with OF based modalias

[PATCH 01/21] of: device: Support loading a module with OF based modalias

2016-06-26 Thread Stephen Boyd
to request it with the OF based modalias instead. Add a common function that allows anyone to request a module with the OF based modalias. Cc: Rob Herring <robh...@kernel.org> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/of/d

[PATCH 02/21] usb: ulpi: Support device discovery via DT

2016-06-26 Thread Stephen Boyd
.kernel.org> Cc: Rob Herring <robh...@kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- Documentation/devicetree/bindings/usb/ulpi.txt | 20 + drivers/usb/common/ulpi.c | 56 +- 2 files changed, 74 insertions(+

[PATCH 15/21] usb: chipidea: msm: Mux over secondary phy at the right time

2016-06-26 Thread Stephen Boyd
phy) after the RESET bit is set in USBCMD. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 78 +++--- 1 file chan

[PATCH 14/21] usb: chipidea: msm: Add proper clk and reset support

2016-06-26 Thread Stephen Boyd
ation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 58 +++--- 1 file changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c

[PATCH 13/21] usb: chipidea: msm: Allow core to get usb phy

2016-06-26 Thread Stephen Boyd
The chipidea core gets the usb phy and initializes the phy at the right point now so we don't need to get the phy in this driver. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- dr

[PATCH 11/21] usb: chipidea: msm: Use hw_write_id_reg() instead of writel directly

2016-06-26 Thread Stephen Boyd
to delete that file soon. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH] usb: misc: Add driver for usb4604

2016-06-25 Thread Stephen Boyd
it down to just handle the optional reset gpio and adds the i2c command to put the device into hub mode. Datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/1716A.pdf Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- Documentatio

[PATCH 0/9] Change return type of of_clk_get_parent_count() to unsigned

2016-02-22 Thread Stephen Boyd
m> Cc: Felipe Balbi <ba...@ti.com> Cc: <linux-usb@vger.kernel.org> Cc: Hans de Goede <hdego...@redhat.com> Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com> Cc: Tomi Valkeinen <tomi.valkei...@ti.com> Cc: <linux-fb...@vger.kernel.org> Stephen Boyd (9): clk: M

[PATCH 8/9] usb: dwc3: Remove impossible check for of_clk_get_parent_count() < 0

2016-02-22 Thread Stephen Boyd
The check for < 0 is impossible now that of_clk_get_parent_count() returns an unsigned int. Simplify the code and update the types. Cc: Felipe Balbi <ba...@ti.com> Cc: <linux-usb@vger.kernel.org> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> --- Please ack so this ca

Re: [PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

2016-08-09 Thread Stephen Boyd
Quoting Peter Chen (2016-08-08 01:52:10) > From: Peter Chen > > At device tree, we have no device node for chipidea core, > the glue layer's node is the parent node for host and udc > device. But in related driver, the parent device is chipidea > core. So, in order to

Re: [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus

2016-07-11 Thread Stephen Boyd
On 10 July 2016 at 20:10, Peter Chen <hzpeterc...@gmail.com> wrote: > On Thu, Jul 07, 2016 at 03:21:01PM -0700, Stephen Boyd wrote: >> @@ -418,6 +427,17 @@ static inline bool ci_otg_is_fsm_mode(struct ci_hdrc >> *ci) >> #endif >> } >> >> +#if

Re: [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time

2016-07-11 Thread Stephen Boyd
On 10 July 2016 at 21:43, Peter Chen <hzpeterc...@gmail.com> wrote: > On Thu, Jul 07, 2016 at 03:21:06PM -0700, Stephen Boyd wrote: >> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c >> b/drivers/usb/chipidea/ci_hdrc_msm.c >> index 7e870a253f55..7708bee3ff3e 100644 &g

Re: [PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-07-11 Thread Stephen Boyd
On 10 July 2016 at 22:32, Peter Chen <hzpeterc...@gmail.com> wrote: > On Thu, Jul 07, 2016 at 03:21:09PM -0700, Stephen Boyd wrote: >> @@ -40,11 +43,38 @@ struct ci_hdrc_msm { >> struct clk *iface_clk; >> struct clk *fs_clk; >> struct ci_hdrc_pla

Re: [PATCH 20/21] phy: Add support for Qualcomm's USB HSIC phy

2016-06-28 Thread Stephen Boyd
Quoting Neil Armstrong (2016-06-28 01:49:37) > On 06/26/2016 09:28 AM, Stephen Boyd wrote: > > + uphy->cal_sleep_clk = clk = devm_clk_get(>dev, "cal_sleep"); > > + if (IS_ERR(clk)) > > + return PTR_ERR(clk); > > Hi Stephen, > >

Re: [PATCH 5/6] usb: chipidea: host: let the hcd know's parent device node

2016-07-07 Thread Stephen Boyd
Quoting Peter Chen (2016-07-07 02:14:51) > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > index 053bac9..55120ef 100644 > --- a/drivers/usb/chipidea/host.c > +++ b/drivers/usb/chipidea/host.c > @@ -109,15 +109,25 @@ static int host_start(struct ci_hdrc *ci) >

[PATCH v2 17/22] usb: chipidea: msm: Make platform data driver local instead of global

2016-07-07 Thread Stephen Boyd
of this structure per each device instance so that odd things don't happen. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 20

[PATCH v2 19/22] usb: chipidea: msm: Handle phy power states

2016-07-07 Thread Stephen Boyd
The ULPI phy on qcom platforms needs to be initialized and powered on after a USB reset and before we toggle the run/stop bit. Otherwise, the phy locks up and doesn't work properly. Hook the phy initialization into the RESET event and the phy power off into the STOPPED event. Cc: Peter Chen

[PATCH v2 00/22] Support qcom's HSIC USB and rewrite USB2 HS phy support

2016-07-07 Thread Stephen Boyd
9621618-11900-1-git-send-email-tim.b...@sonymobile.com [3] https://git.linaro.org/people/stephen.boyd/linux.git/shortlog/refs/heads/usb-hsic-8074 Stephen Boyd (22): of: device: Support loading a module with OF based modalias of: device: Export of_device_{get_modalias,uvent_modalias} to modul

[PATCH v2 12/22] usb: chipidea: msm: Rely on core to override AHBBURST

2016-07-07 Thread Stephen Boyd
<peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/dr

[PATCH v2 14/22] usb: chipidea: msm: Add proper clk and reset support

2016-07-07 Thread Stephen Boyd
oah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 72 +++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_h

[PATCH v2 20/22] usb: chipidea: msm: Be silent on probe defer errors

2016-07-07 Thread Stephen Boyd
If something fails in ci_hdrc_add_device() due to probe defer, we shouldn't print an error message. Be silent in this case as we'll try probe again later. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.

[PATCH v2 22/22] phy: Add support for Qualcomm's USB HS phy

2016-07-07 Thread Stephen Boyd
The high-speed phy on qcom SoCs is controlled via the ULPI viewport. Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- .../devicetree/bindings/phy/qcom,usb-hs-phy.txt| 83 ++ d

[PATCH v2 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel

2016-07-07 Thread Stephen Boyd
to delete that file soon. Acked-by: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff -

[PATCH v2 11/22] usb: chipidea: msm: Mark device as runtime pm active

2016-07-07 Thread Stephen Boyd
and disable the power domain to match the 'inactive' state of the device. Let's mark the device as active so that runtime PM doesn't improperly power down this device when it's actually active. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off

[PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time

2016-07-07 Thread Stephen Boyd
phy) after the RESET bit is set in USBCMD. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 67 +++--- 1 file chan

[PATCH v2 16/22] usb: chipidea: msm: Restore wrapper settings after reset

2016-07-07 Thread Stephen Boyd
consolidate the register writes into the wrapper driver instead so that we clearly split the wrapper from the phys. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chip

[PATCH v2 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} to modules

2016-07-07 Thread Stephen Boyd
The ULPI bus can be built as a module, and it will soon be calling these functions when it supports probing devices from DT. Export them so they can be used by the ULPI module. Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/of/device.c | 2 ++ 1 file changed, 2 inse

[PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus

2016-07-07 Thread Stephen Boyd
Kroah-Hartman <gre...@linuxfoundation.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/Kconfig | 7 +++ drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci.h | 22 ++

[PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-07-07 Thread Stephen Boyd
up and avoid this problem. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Cc: <devicet...@vger.kernel.org> Cc: Rob Herring <robh...@kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- Documen

[PATCH v2 01/22] of: device: Support loading a module with OF based modalias

2016-07-07 Thread Stephen Boyd
to request it with the OF based modalias instead. Add a common function that allows anyone to request a module with the OF based modalias. Cc: Rob Herring <robh...@kernel.org> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/of/d

[PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

2016-07-07 Thread Stephen Boyd
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/udc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 065f5d97aa67..f16be4710cdb 100

[PATCH v2 21/22] phy: Add support for Qualcomm's USB HSIC phy

2016-07-07 Thread Stephen Boyd
The HSIC USB controller on qcom SoCs has an integrated all digital phy controlled via the ULPI viewport. Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- .../devicetree/bindings/phy/qcom,usb-h

[PATCH v2 07/22] usb: chipidea: Notify events when switching host mode

2016-07-07 Thread Stephen Boyd
wrapper specific things after the device is stopped. So when we stop the host role, send the stopped event. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/host.c

[PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place

2016-07-07 Thread Stephen Boyd
t; Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci.h | 3 --- drivers/usb/chipidea/core.c | 32 drivers/usb/chipidea/otg.c | 34

[PATCH v2 05/22] usb: chipidea: Handle extcon events properly

2016-07-07 Thread Stephen Boyd
ot;Ivan T. Ivanov" <iivanov...@gmail.com> Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/otg.c | 46 +++- include/linux

[PATCH v2 09/22] usb: chipidea: Kick OTG state machine for AVVIS with vbus extcon

2016-07-07 Thread Stephen Boyd
r.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- I think this was rejected last time around but I've kept it in the series to continue discussion on how we're supposed to be emulating vbus an id pin interr

[PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-07-07 Thread Stephen Boyd
artman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/Kconfig | 1 + drivers/usb/chipidea/ci_hdrc_msm.c | 45 -- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/us

[PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

2016-07-07 Thread Stephen Boyd
. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/core.c | 6 ++ include/linux/usb/chipidea.h | 1 + 2 files changed, 7 insertions(+) diff --git a/dr

Re: [PATCH 16/21] usb: chipidea: msm: Restore wrapper settings after reset

2016-06-30 Thread Stephen Boyd
On 30 June 2016 at 01:54, Peter Chen <hzpeterc...@gmail.com> wrote: > On Wed, Jun 29, 2016 at 12:13:45PM -0700, Stephen Boyd wrote: >> Quoting Peter Chen (2016-06-29 01:26:48 >> > Why not using ci->platdata->vbus_extcon directly? >> >> Because ci->plat

Re: [PATCH 20/21] phy: Add support for Qualcomm's USB HSIC phy

2016-06-29 Thread Stephen Boyd
Quoting Neil Armstrong (2016-06-29 02:16:51) > On 06/28/2016 11:58 PM, Stephen Boyd wrote: > > Quoting Neil Armstrong (2016-06-28 01:49:37) > >> On 06/26/2016 09:28 AM, Stephen Boyd wrote: > >>> + uphy->cal_sleep_clk = clk = devm_clk_get(>dev, &quo

Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-23 Thread Stephen Boyd
Quoting Kishon Vijay Abraham I (2017-01-22 00:46:21) > Hi, > > On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: > > Some USB PHYs need to be told about vbus changing state > > explicitly. For example the qcom USB HS PHY needs to toggle a bit > > when

[PATCH v8 2/3] phy: Add support for Qualcomm's USB HSIC phy

2017-01-25 Thread Stephen Boyd
The HSIC USB controller on qcom SoCs has an integrated all digital phy controlled via the ULPI viewport. Cc: Kishon Vijay Abraham I <kis...@ti.com> Acked-by: Rob Herring <r...@kernel.org> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org

[PATCH v8 0/3] Support qcom's HSIC USB and rewrite USB2 HS support

2017-01-25 Thread Stephen Boyd
/people/stephen.boyd/linux.git/log/?h=usb-hsic-8074 [2] https://patchwork.kernel.org/patch/9319527/ [3] https://lkml.kernel.org/r/20160914014246.31847-1-stephen.b...@linaro.org Stephen Boyd (3): usb: chipidea: Configure phy for appropriate mode phy: Add support for Qualcomm's USB HSIC ph

[PATCH v8 1/3] usb: chipidea: Configure phy for appropriate mode

2017-01-25 Thread Stephen Boyd
here. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/core.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb

Re: [PATCH -next] usb: chipidea: msm: Fix return value check in ci_hdrc_msm_probe()

2017-01-25 Thread Stephen Boyd
; Fixes: 2fc305be364e ("usb: chipidea: msm: Mux over secondary phy at the > right time") > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Thanks. Reviewed-by: Stephen Boyd <stephen.b...@linaro.org> -- To unsubscribe from this list: send the line &qu

Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

2017-01-18 Thread Stephen Boyd
Quoting Peter Chen (2017-01-17 23:34:32) > On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote: > > Quoting Peter Chen (2017-01-15 19:45:51) > > > > > > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need > > > to port it to gener

[PATCH v7 3/5] phy: Add set_vbus callback

2017-01-20 Thread Stephen Boyd
gnal isn't routed to the PHY this "session valid" signal won't ever toggle, so we have to toggle it explicitly. This callback is used to do that. Cc: Peter Chen <peter.c...@nxp.com> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- New patch drivers/phy/phy-core.c | 1

[PATCH v7 0/5] Support qcom's HSIC USB and rewrite USB2 HS support

2017-01-20 Thread Stephen Boyd
n.boyd/linux.git/log/?h=usb-hsic-8074 [2] https://patchwork.kernel.org/patch/9319527/ [3] https://lkml.kernel.org/r/20160914014246.31847-1-stephen.b...@linaro.org Stephen Boyd (5): phy: Add support for Qualcomm's USB HSIC phy usb: chipidea: msm: Configure phy for appropriate mode phy: Add set

[PATCH v7 4/5] usb: chipidea: Signal vbus state to phy

2017-01-20 Thread Stephen Boyd
ppropriate phy_set_vbus() call here to signal vbus state changes to the phy. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- New patch drivers/usb/chipidea/otg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) di

[PATCH v7 5/5] phy: Add support for Qualcomm's USB HS phy

2017-01-20 Thread Stephen Boyd
The high-speed phy on qcom SoCs is controlled via the ULPI viewport. Cc: <devicet...@vger.kernel.org> Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- phy_set_mode() hook split up to toggle two bits independently with n

[PATCH v7 2/5] usb: chipidea: msm: Configure phy for appropriate mode

2017-01-20 Thread Stephen Boyd
ure for. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- Made this msm specific because of how msm handles phy powerup. drivers/usb/chipidea/ci.h | 7 +-- drivers/usb/chipidea/ci_hdrc_msm.c | 4 2 f

[PATCH v7 1/5] phy: Add support for Qualcomm's USB HSIC phy

2017-01-20 Thread Stephen Boyd
The HSIC USB controller on qcom SoCs has an integrated all digital phy controlled via the ULPI viewport. Acked-by: Rob Herring <r...@kernel.org> Cc: <devicet...@vger.kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- No changes. .../devicetree/bindings

[PATCH v3 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} to modules

2016-08-31 Thread Stephen Boyd
The ULPI bus can be built as a module, and it will soon be calling these functions when it supports probing devices from DT. Export them so they can be used by the ULPI module. Cc: Rob Herring <robh...@kernel.org> Cc: <devicet...@vger.kernel.or Signed-off-by: Stephen Boyd <stephen.b..

[PATCH v3 00/22] Support qcom's HSIC USB and rewrite USB2 HS phy support

2016-08-31 Thread Stephen Boyd
//lkml.org/lkml/2016/2/22/7 [2] http://lkml.kernel.org/g/1449621618-11900-1-git-send-email-tim.b...@sonymobile.com [3] https://git.linaro.org/people/stephen.boyd/linux.git/shortlog/refs/heads/usb-hsic-8074 Stephen Boyd (22): of: device: Support loading a module with OF based modalias

[PATCH v3 05/22] usb: chipidea: Handle extcon events properly

2016-08-31 Thread Stephen Boyd
ot;Ivan T. Ivanov" <iivanov...@gmail.com> Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect") Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/otg.c | 46 +++- include/linux

[PATCH v3 11/22] usb: chipidea: msm: Mark device as runtime pm active

2016-08-31 Thread Stephen Boyd
; Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 3889809fd0c4..89c1a02d69b5 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c

[PATCH v3 12/22] usb: chipidea: msm: Rely on core to override AHBBURST

2016-08-31 Thread Stephen Boyd
to be anything besides 0, we expect the 'ahb-burst-config' dts property to be present. Acked-by: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 4 ++

[PATCH v3 03/22] usb: ulpi: Support device discovery via device properties

2016-08-31 Thread Stephen Boyd
before it's powered up and avoid this problem. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Cc: <devicet...@vger.kernel.org> Cc: Rob Herring <robh...@kernel.org> Signed-off-by: Stephen Boyd <stephen.b...@lin

[PATCH v3 16/22] usb: chipidea: msm: Restore wrapper settings after reset

2016-08-31 Thread Stephen Boyd
consolidate the register writes into the wrapper driver instead so that we clearly split the wrapper from the phys. Acked-by: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org> --- dr

[PATCH v3 19/22] usb: chipidea: msm: Handle phy power states

2016-08-31 Thread Stephen Boyd
<peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> --- drivers/usb/chipidea/ci_hdrc_msm.c | 40 +++--- drivers/usb/chipidea/core.c| 8 ++-- drivers/usb/chipidea/

  1   2   3   >