[PATCH] usb: phy: tegra: Avoid use of sizeof(void)

2014-07-21 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The PHY configuration is stored in an opaque config field, but when allocating the structure, its proper size needs to be known. In the case of UTMI, the proper structure is tegra_utmip_config of which a local variable already exists, so we can use

Re: [PATCH v2 2/4] ARM: tegra: Add resets has-utmi-pad-registers flag to all USB PHYs

2014-07-14 Thread Thierry Reding
On Thu, Jul 10, 2014 at 06:12:48PM +0300, Tuomas Tynkkynen wrote: Thierry, Since Stephen's on a vacation, I'd like to double-check with you that the DT changes looks good. Greg has applied these to the USB tree today. Yes, looks sane to me. Not sure how much people will like to see the DTS

[PATCH] usb: phy: tegra: Do not include asm/mach-types.h

2014-07-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com It is no longer needed and keeping it will break 64-bit ARM builds. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Thierry Reding
On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote: On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam gautam.vi...@samsung.com wrote

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: Hi, On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:17:10AM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: [...] + /* Create child xhci-plat device */ + memset(xhci_resources, 0, sizeof(xhci_resources)); + res = platform_get_resource(to_platform_device(dev),

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 01:18:22PM -0700, Andrew Bresticker wrote: Arnd, On Thu, May 15, 2014 at 1:17 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: + +int tegra_xhci_register_mbox_notifier(struct notifier_block *nb) +{ + int

[PATCH] USB: EHCI: tegra: Drop unused defines

2014-02-25 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Since commit 2d22b42db02f usb: phy: registering Tegra USB PHY as platform driver the driver no longer relies on the hard-coded physical addresses to determine the association between PHY and EHCI port, so these defines can be dropped. Signed-off

Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-02-12 Thread Thierry Reding
On Mon, Feb 10, 2014 at 01:33:39PM +0800, liujunliang_...@163.com wrote: From: Liu Junliang liujunliang_...@163.com Signed-off-by: Liu Junliang liujunliang_...@163.com --- drivers/net/usb/Kconfig | 16 + drivers/net/usb/Makefile |1 + drivers/net/usb/sr9800.c | 873

Re: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-04 Thread Thierry Reding
--- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thierry Reding tred...@nvidia.com pgpztN5vkmcF9.pgp Description: PGP signature

Re: [PATCH 27/31] USB: EHCI: tegra: use reset framework

2013-11-29 Thread Thierry Reding
. --- drivers/usb/host/ehci-tegra.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding tred...@nvidia.com pgpVJB4hRtMwz.pgp Description: PGP signature

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-15 Thread Thierry Reding
On Wed, Jul 31, 2013 at 05:29:40PM -0600, Stephen Warren wrote: On 07/31/2013 04:20 PM, Sergei Shtylyov wrote: On 08/01/2013 02:06 AM, Stephen Warren wrote: ... That's really horrible design. Yup. Both USB PHY and EHCI controller registers really are interleaved in one range.

Re: [PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-02 Thread Thierry Reding
doesn't have any negative affect on your PCIe patches. Thanks. PCIe on Beaver seems to behave the same way whether that patch is applied or not, so: Tested-by: Thierry Reding tred...@nvidia.com I wonder if perhaps a similar change can be made to Cardhu to see if that helps with the PCIe link

[PATCH] USB: EHCI: tegra: Fix oops in error cleanup

2013-06-14 Thread Thierry Reding
in tegra_ehci_probe(). This patch fixes the issue by adding an additional label into the cleanup path to separately take down the PHY and the transceiver. Signed-off-by: Thierry Reding thierry.red...@gmail.com --- Note: This is based on top of Stephen's latest patch series to allow building the driver

Re: [PATCH V3 REPOST 0/7] USB: tegra: support building as a module

2013-06-14 Thread Thierry Reding
| 2 + drivers/usb/phy/phy-tegra-usb.c | 43 +++- drivers/usb/phy/phy-ulpi-viewport.c | 2 + include/linux/usb/tegra_usb_phy.h | 4 - 9 files changed, 165 insertions(+), 389 deletions(-) The series: Tested-by: Thierry Reding thierry.red...@gmail.com pgpAES0C1Gu9E.pgp

[PATCH v2] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-03 Thread Thierry Reding
and initialize the transceiver field to ERR_PTR(-ENODEV) when the operating mode isn't TEGRA_USB_OTG to allow for consistent checking. Signed-off-by: Thierry Reding thie...@gilfi.de Acked-by: Stephen Warren swar...@nvidia.com Acked-by: Venu Byravarasu vbyravar...@nvidia.com --- Note that this has

Re: [PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
be removed from the failure code paths. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Reviewed-by: Thierry Reding thierry.red...@avionic-design.de pgpR2wexD4ouX.pgp Description: PGP signature

Re: [PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
be removed from the failure code paths. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/phy/omap-usb3.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Thierry Reding thierry.red...@avionic-design.de

Re: [PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
be removed from the failure code paths. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/phy/omap-control-usb.c | 24 +--- 1 files changed, 9 insertions(+), 15 deletions(-) Reviewed-by: Thierry Reding thierry.red

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-21 Thread Thierry Reding
On Thu, Feb 21, 2013 at 01:58:39PM -0800, Greg KH wrote: On Thu, Feb 21, 2013 at 12:25:24PM -0800, Linus Torvalds wrote: On Thu, Feb 21, 2013 at 10:40 AM, Greg KH gre...@linuxfoundation.org wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major,

[PATCH 29/33] usb: Convert to devm_ioremap_resource()

2013-01-21 Thread Thierry Reding
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Thierry

<    1   2