Re: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information

2013-07-18 Thread Tony Lindgren
()) + musb_plat.phy_label = twl4030; + if (soc_is_am35xx()) { oh_name = am35x_otg_hs; name = musb-am35x; I don't think there's a USB PHY on non-twl4030 chips, so this should be OK: Acked-by: Tony Lindgren t...@atomide.com diff --git a/include/linux

Re: [PATCH 05/15] ARM: dts: omap: update usb_otg_hs data

2013-07-18 Thread Tony Lindgren
. But sounds like things will stop working for USB unless we do it like this so: Acked-by: Tony Lindgren t...@atomide.com --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3-beagle-xm.dts

Re: [PATCH 1/4] usb: phy: rename nop_usb_xceiv = usb_phy_gen_xceiv

2013-07-30 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130729 05:27]: On Fri, Jul 26, 2013 at 10:15:54PM +0200, Sebastian Andrzej Siewior wrote: The nop driver isn't a do-nothing-stub but supports a couple functions like clock on/off or is able to use a voltage regulator. This patch simply renames the driver to

Re: [PATCH 1/4] usb: phy: rename nop_usb_xceiv = usb_phy_gen_xceiv

2013-07-30 Thread Tony Lindgren
* Sebastian Andrzej Siewior bige...@linutronix.de [130730 00:41]: On 07/30/2013 09:08 AM, Tony Lindgren wrote: Looking at this patch there's a pretty high probability of introducing pointless merge conflicts. How about do the platform data related changes as a separate follow-up series

Re: [GIT PULL, FOR LINUX-OMAP] usb: nop phy rename

2013-08-14 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130809 07:35]: Hi Tony, here's a pull request of one patch to avoid conflicts during the merge window. Please consider applying to your tree and I'll take this same patch upstream. Thanks, pulling into omap-for-v3.12/usb. Regards, Tony The following

Re: [PATCH 0/2] ARM: OMAP: fix USB regression on Nokia boards

2013-08-16 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130815 12:25]: Hi, On Tue, Aug 06, 2013 at 08:06:14PM +0300, Aaro Koskinen wrote: USB subsystem changes broke the USB peripheral/gadget on N800, N810 and RX-51/N900 during the merge window. We need to fix this in board files. I tested all these with

Re: [PATCH v2 3/9] ARM: OMAP2+: omap-usb-host: Get rid of platform_data from struct usbhs_phy_data

2013-09-20 Thread Tony Lindgren
it comes out, then yes I can ack them: Acked-by: Tony Lindgren t...@atomide.com That way I can also pull in the topic branch as needed to avoid self inflicted merge conflicts ;) And Benoit can set up a separate .dts branch based on your branch to make sure the dependencies are in place before

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-23 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [130920 12:29]: On Sunday 08 September 2013 10:50:39 Pali Rohár wrote: This patch will register bq24150a charger in RX-51 board data. Patch also adding platform function between isp1704 and bq2415x drivers for detecting charger type. So finally

Re: [PATCH v3 03/10] ARM: OMAP2+: omap-usb-host: Get rid of platform_data from struct usbhs_phy_data

2013-10-02 Thread Tony Lindgren
in as needed. For this patch: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop RESET line changes

2013-10-02 Thread Tony Lindgren
on this one as well. Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 5/6] Revert ARM: OMAP2+: Provide alias to USB PHY clock

2013-10-09 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131009 00:19]: Hi Tony, On 10/08/2013 01:06 PM, Roger Quadros wrote: This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. The proper clock reference is provided in device tree so we no longer need this. Could you please Ack this one? I think

Re: [PATCH v2 5/6] Revert ARM: OMAP2+: Provide alias to USB PHY clock

2013-10-22 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131010 02:23]: On 10/09/2013 06:15 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [131009 00:19]: Hi Tony, On 10/08/2013 01:06 PM, Roger Quadros wrote: This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. The proper clock reference

Re: [PATCH] include/linux/usb/usb_phy_gen_xceiv.h: check built-in or module for swithing usb_nop_xceiv_register() implementation

2013-11-14 Thread Tony Lindgren
* Chen Gang gang.c...@asianux.com [131023 02:57]: When CONFIG_NOP_USB_XCEIV is as 'm', usb_nop_xceiv_register() will be exported when the related module is loaded. So for built-in source code, still need use the empty one. Or it will can not pass compiling, the related error (for arm, with

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-10 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-11 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130111 01:43]: Tony, On 01/11/2013 01:45 AM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130114 03:31]: On 01/11/2013 08:13 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130111 01:43]: Tony, On 01/11/2013 01:45 AM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure

Re: [PATCH v7 01/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-17 Thread Tony Lindgren
* Alan Stern st...@rowland.harvard.edu [130117 07:19]: On Thu, 17 Jan 2013, Roger Quadros wrote: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130117 03:34]: We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. It's best that Paul queues this and the next patch as these clock alias clean-up patches can be done separately. That way the dependency between

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [130117 14:33]: On Thu, 17 Jan 2013, Felipe Balbi wrote: do you mean v3.9 ? It sounds like the other patches need to be merged first before these cleanups can be merged. So rather than adding a merge order dependency during 3.9, it seems best to queue

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-02-01 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130125 02:30]: Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own.

Re: [PATCH v2 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-02-01 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130123 03:27]: Hi, On Mon, Jan 21, 2013 at 07:38:26PM +0530, Kishon Vijay Abraham I wrote: A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be

Re: [PATCH v2 3/6] ARM: OMAP: USB: Add phy binding information

2013-02-01 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130124 18:36]: This is w.r.t the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding information between the PHY and the USB controller should be specified in the platform specific

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-02-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130204 07:57]: Hi, On Fri, Feb 01, 2013 at 11:14:24AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [130125 02:30]: Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-05 Thread Tony Lindgren
* Greg KH gre...@linuxfoundation.org [130205 09:00]: On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: Hi Tony Greg, What's the best way to get these patches in? All patches have been acked by respective maintainers. If Tony can Ack the arch/arm/mach-omap2 stuff

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread Tony Lindgren
my Acked-by: Tony Lindgren t...@atomide.com for those. 2. A branch for Benoit based on v3.8-rc6 That branch should contain all the .dts changes as those will most likely cause nasty merge conflicts otherwise with what Benoit has queued up. Regards, Tony -- To unsubscribe from this list

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-06 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130206 01:53]: On 02/05/2013 07:17 PM, Tony Lindgren wrote: * Greg KH gre...@linuxfoundation.org [130205 09:00]: On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: Hi Tony Greg, What's the best way to get these patches in? All patches have

Re: [GIT PULL] arm-soc: OMAP USB Host cleanup for 3.9

2013-02-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130214 04:08]: Hi Tony, This is the ARM-soc part of the OMAP USB Host cleanup series for 3.9. It is based on 3.8-rc6 + usbhost17-common that I sent earlier. Please pull. Thanks. Thanks for reworking this series! I'll pull this. Regards, Tony The

Re: [RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130307 06:44]: +#include mach/usb.h We should be getting rid of the plat and mach includes for drivers for omap1 also, so let's not make it harder by adding more of it. We should have just the following: include/linux/platform_data/usb-omap.h this contains

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Patch makes sens to me, just a related question.. Do you get this when trying to enable the host mode,

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130311 10:12]: On Mon, Mar 11, 2013 at 6:24 PM, Tony Lindgren t...@atomide.com wrote: * Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-12 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. ... arch/arm/mach-omap2/board-3430sdp.c| 97 +++-

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130313 06:46]: On 03/12/2013 06:40 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. ... arch

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130313 09:40]: On 03/13/2013 06:24 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130313 06:46]: On 03/12/2013 06:40 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130314 08:45]: OK. Let me know how the below patch looks. After that, the board code will look like. static struct usbhs_phy_data phy_data[] = { { .reset_gpio = 147, .vcc_gpio = 148 .vcc_polarity = 1,

Re: [PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-15 Thread Tony Lindgren
Hi, I think you can get rid of quite a bit more of the repeated data for most boards, see below. * Roger Quadros rog...@ti.com [130315 08:21]: Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use

Re: [PATCH v3 0/4] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-18 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130318 05:55]: Hi Tony, I've revised the patches based on your comments. For now I've just adapted Panda and Beagleboard. If this looks OK then I can adapt the other boards as well. Thanks yes looks good to me now. Regards, Tony -- To unsubscribe from this

Re: [PATCH v2 00/23] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-19 Thread Tony Lindgren
Hi Felipe, * Roger Quadros rog...@ti.com [130315 08:20]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. Device tree support is added for Beagleboard and Panda. NOTE: The first patch needs to be shared

Re: [PATCH v4 01/21] usb: phy: nop: Add some parameters to platform data

2013-03-20 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130320 09:00]: On Wed, Mar 20, 2013 at 05:44:40PM +0200, Roger Quadros wrote: Add clk_rate parameter to platform data. If supplied, the NOP phy driver will program the clock to that rate during probe. Also add 2 flags, needs_vcc and needs_reset. If the flag

Re: [PATCH v3 4/6] ARM: OMAP: USB: Add phy binding information

2013-03-20 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130320 02:17]: --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@ -265,6 +266,7 @@ static void __init omap_2430sdp_init(void) omap_mux_init_signal(usb0hs_stp, OMAP_PULL_ENA | OMAP_PULL_UP);

Re: [PATCH v4 01/21] usb: phy: nop: Add some parameters to platform data

2013-04-02 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130320 09:24]: On Wed, Mar 20, 2013 at 09:13:24AM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [130320 09:00]: On Wed, Mar 20, 2013 at 05:44:40PM +0200, Roger Quadros wrote: Add clk_rate parameter to platform data. If supplied, the NOP phy

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-03 Thread Tony Lindgren
Hi, * Roger Quadros rog...@ti.com [130319 07:31]: Register a device tree clock provider for AUX clocks on the OMAP4 SoC. Also provide the binding information. Signed-off-by: Roger Quadros rog...@ti.com --- .../devicetree/bindings/clock/omap4-clock.txt | 32 ++

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-04 Thread Tony Lindgren
* Rajendra Nayak rna...@ti.com [130403 22:25]: On Thursday 04 April 2013 05:12 AM, Tony Lindgren wrote: How about just add a minimal drivers/clk/omap/clk-xyz.c that takes the configuration from DT and is based on the binding we already have in Documentation/devicetree/bindings/clock

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-04 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130404 00:39]: On 04/04/2013 02:42 AM, Tony Lindgren wrote: --- a/arch/arm/mach-omap2/cclock44xx_data.c +++ b/arch/arm/mach-omap2/cclock44xx_data.c @@ -27,6 +27,7 @@ #include linux/clk-private.h #include linux/clkdev.h #include linux/io.h +#include

Re: [PATCH v4 00/21] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-04-05 Thread Tony Lindgren
* Benoit Cousson b-cous...@ti.com [130405 03:00]: On 04/05/2013 10:30 AM, Benoit Cousson wrote: ... ARM: dts: OMAP4: Add HS USB Host IP nodes ARM: dts: OMAP3: Add HS USB Host IP nodes ARM: dts: omap3-beagle: Add USB Host support These 3 DTS patches are good to me, but I

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-05 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130405 03:44]: On 04/04/2013 07:41 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130404 00:39]: On 04/04/2013 02:42 AM, Tony Lindgren wrote: For v3.10, let's just make sure that USB works with DT as then after v3.10 we can make omap4 DT only

Re: [PATCH v4 00/21] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-04-08 Thread Tony Lindgren
* Benoit Cousson b-cous...@ti.com [130408 05:11]: Hi Tony, On 04/05/2013 05:43 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [130405 03:00]: On 04/05/2013 10:30 AM, Benoit Cousson wrote: ... ARM: dts: OMAP4: Add HS USB Host IP nodes ARM: dts: OMAP3: Add HS USB

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-09 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130409 03:00]: On 04/05/2013 06:58 PM, Tony Lindgren wrote: Well your approach is fine as a first step moving all the clock code, but it needs to be a real driver under drivers/clock/omap. And the DT binding needs to stay the same for the driver(s

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-09 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [130409 09:54]: * Roger Quadros rog...@ti.com [130409 03:00]: On 04/05/2013 06:58 PM, Tony Lindgren wrote: Can't you just use the clock name there to get it? In device tree we don't pass around clock names. You can either get a phandle or an index

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-10 Thread Tony Lindgren
-off-by: Tony Lindgren t...@atomide.com Signed-off-by: Nishanth Menon n...@ti.com --- .../devicetree/bindings/clock/omap-clock.txt | 40 + drivers/clk/Makefile |1 + drivers/clk/omap/Makefile |1 + drivers/clk/omap

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-10 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [130410 12:23]: On Wed, Apr 10, 2013 at 1:49 PM, Tony Lindgren t...@atomide.com wrote: We can avoid the concern of storing the struct clk * and do the look up lazily on consumer driver probe by setting a dummy struct clk * here. Then replace

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-02-28 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140227 06:21]: Hi, This patchset brings up USB Host ports and Ethernet port on the OMAP5 uEVM board. It also does some cleanup with respect to DT clock binding for the mfd/omap-usb-host driver. Please queue these for -next. Lee, I've folded some

Re: [PATCH 06/12] phy: omap: Select OMAP_OCP2SCP bus driver

2014-03-03 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140303 07:11]: The OMAP_USB2 and OMAP_PIP3 phy devices will not be detected if the OMAP_OCP2SCP driver is not present. So select it. Selecting drivers like this will easily lead into missing dependencies. Especially it's bad for tristate driver options that

Re: [PATCH 02/12] phy: omap-control: Update DT binding information

2014-03-03 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140303 07:10]: Move omap-control binding information to the right location. Signed-off-by: Roger Quadros rog...@ti.com --- Documentation/devicetree/bindings/phy/ti-phy.txt | 25 ++ Documentation/devicetree/bindings/usb/omap-usb.txt |

Re: [PATCH 02/12] phy: omap-control: Update DT binding information

2014-03-04 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140304 01:17]: Hi Tony, On 03/03/2014 09:02 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140303 07:10]: Move omap-control binding information to the right location. Signed-off-by: Roger Quadros rog...@ti.com --- Documentation/devicetree

Re: [PATCH 02/12] phy: omap-control: Update DT binding information

2014-03-05 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140305 04:26]: + George Tony, On 03/04/2014 06:28 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140304 01:17]: Hi Tony, On 03/03/2014 09:02 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140303 07:10]: Move omap-control binding

Re: [PATCH v5 6/6] arm/dts: added dt properties to adapt to the new phy framwork

2014-03-05 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [140305 04:46]: Tony/Benoit, On Monday 03 March 2014 05:08 PM, Kishon Vijay Abraham I wrote: Added device tree bindings for dwc3, usb2 and usb3 PHYs. The documentation of these can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt

Re: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL

2014-03-07 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [140307 05:46]: On 03/07/2014 03:09 PM, Roger Quadros wrote: USB_DPLL must be initialized and locked at boot so that USB modules can work. Also program USB_DLL_M2 output to half rate. CC: Mike Turquette mturque...@linaro.org CC: Tero Kristo t-kri...@ti.com

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Tony Lindgren
tree. You need to take patches 1 to 6 in the MFD tree. Out of these, patches 1 to 4 need to be shared with Tony as an immutable branch. Tony, could you please Ack patches 1 to 4? Thanks. Changes in 1 to 6 look OK to me, so for those please feel free to add: Acked-by: Tony Lindgren t

Re: [PATCH v3 5/8] ARM: OMAP5: hwmod: Add ocp2scp3 and sata hwmods

2014-03-12 Thread Tony Lindgren
: Tony Lindgren t...@atomide.com Signed-off-by: Balaji T K balaj...@ti.com Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 73 ++ 1 file changed, 73 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c

Re: Infinite looping in omap2430.c USB driver

2012-07-09 Thread Tony Lindgren
* NeilBrown ne...@suse.de [120706 15:44]: Hello `./scripts/get_maintainer.pl -f drivers/usb/musb/omap2430.c` omap2430_musb_set_vbus in omap2430.c contains: while (musb_readb(musb-mregs, MUSB_DEVCTL) 0x80) { cpu_relax();

usb: musb: Fix LapDock enumeration on omap for boot and slow cable insertion

2013-05-03 Thread Tony Lindgren
not enumerating. Signed-off-by: Tony Lindgren t...@atomide.com --- Can you guys please test that this does not cause regressions on other devices when connecting USB devices? --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -251,6 +251,20 @@ void omap_musb_mailbox(enum

[PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

2013-05-10 Thread Tony Lindgren
this by specifying the interrupt following the TI INTC binding. Without this fix MUSB won't work as it is trying to use irq0 instead of irq92. Signed-off-by: Tony Lindgren t...@atomide.com --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -516,7 +516,7 @@ usb_otg_hs

[PATCH] ARM: dts: Fix musb interrupt for device tree booting

2013-05-10 Thread Tony Lindgren
this by specifying the interrupt following the TI INTC binding. Without this fix MUSB won't work as it is trying to use irq0 instead of irq92. Signed-off-by: Tony Lindgren t...@atomide.com --- Sorry had the wrong subject in the previous mail. That was for the breaking commit. Here's the patch again

Re: usb: musb: Fix LapDock enumeration on omap for boot and slow cable insertion

2013-05-16 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130515 07:11]: On Fri, May 03, 2013 at 11:01:33AM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130503 10:55]: Looks like we can get VBUS interrupt before the ID interrupt how can this happen ? VBUS interrupt happens when you connect to a port

Re: MUSB multiplatform work?

2013-05-30 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130528 09:42]: Hi, On Mon, May 27, 2013 at 05:02:09PM +0200, Arnd Bergmann wrote: Hi Felipe, We've gone through remaining work items for getting the ARM kernel to full multiplatform support again, and MUSB came up. I'm sure you have your own thoughts on

Re: MUSB multiplatform work?

2013-05-30 Thread Tony Lindgren
* Linus Walleij linus.wall...@linaro.org [130530 13:27]: On Thu, May 30, 2013 at 10:18 PM, Tony Lindgren t...@atomide.com wrote: TUSB would work with dmaengine, but AFAIK we're still missing the dmaengine configuration options to support increasing device end FIFO address. Can you

Re: MUSB multiplatform work?

2013-05-30 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [130530 13:25]: TUSB we can make depend on ARMv7, the only implementation we have is for omap2420, which is ARMv6. This should solve the issue for ARMv7 multiplatform builds for now. Sorry mean depend on !ARMv7. But thinking about it more, that does not make

Re: MUSB multiplatform work?

2013-05-31 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130530 21:06]: On Thu, May 30, 2013 at 01:54:49PM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [130530 13:25]: TUSB we can make depend on ARMv7, the only implementation we have is for omap2420, which is ARMv6. This should solve the issue

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-13 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130613 22:41]: Hi, On Thursday 13 June 2013 06:35 PM, Tomi Valkeinen wrote: Hi, On 28/05/13 08:18, Kishon Vijay Abraham I wrote: Hi Tony, On Friday 17 May 2013 06:52 PM, Kishon Vijay Abraham I wrote: In order for controllers to get PHY in case

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [130613 23:42]: On 14/06/13 08:47, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [130613 22:41]: Hi, On Thursday 13 June 2013 06:35 PM, Tomi Valkeinen wrote: Hi, On 28/05/13 08:18, Kishon Vijay Abraham I wrote: Hi Tony

Re: [PATCH v2 1/5] ARM: OMAP1: USB: move omap_usb_config to platform data

2013-06-18 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130616 06:41]: Move omap_usb_config to platform data, so that OTG driver can include it. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi This is probably best queued with the USB transceiver: Acked-by: Tony Lindgren t...@atomide.com --- arch/arm

Re: [PATCH v2 5/5] ARM: OMAP1: nokia770: enable Tahvo

2013-06-18 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130616 06:41]: Add platform data for Tahvo. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Thanks, applying into omap-for-v3.11/board. I left out the .extcon entry to remove the dependency to the USB patches. Then the rest of the series can be queued

Re: [RFC PATCH 2/6] mfd: omap-usb-host: Put pins in IDLE state on suspend

2013-06-20 Thread Tony Lindgren
* Kevin Hilman khil...@linaro.org [130619 10:30]: Hi Roger, Roger Quadros rog...@ti.com writes: In order to support wake up from suspend use the pinctrl framework to put the USB host pins in IDLE state during suspend. CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger

Re: [PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-07-04 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130619 01:58]: In order for controllers to get PHY in case of non dt boot, the phy binding information (phy label) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi

Re: [PATCH v2 1/4] arm: omap: Add phy binding info for musb in plat data

2013-07-16 Thread Tony Lindgren
...@ti.com Tested-by: Tomi Valkeinen tomi.valkei...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/usb-musb.c |3 +++ include/linux/usb/musb.h |3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb

Re: [PATCH v2 4/4] arm: omap: remove using usb_bind_phy for binding musb and phy

2013-07-16 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130708 04:21]: Now that MUSB for OMAP started using devm_usb_get_phy_by_name which does not require PHY library to already have the binding information, removed usb_bind_phy calls that binds the MUSB controller with the PHY from the board files.

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Tony Lindgren
* Ravi Babu ravib...@ti.com [120831 04:10]: --- a/arch/arm/plat-omap/include/plat/usb.h +++ b/arch/arm/plat-omap/include/plat/usb.h @@ -95,7 +95,6 @@ extern void am35x_musb_reset(void); extern void am35x_musb_phy_power(u8 on); extern void am35x_musb_clear_irq(void); extern void

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [120906 10:23]: Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap

[PATCH 03/29] ARM: OMAP1: Make plat/mux.h omap1 only

2012-09-19 Thread Tony Lindgren
- * - * Copyright (C) 2003 - 2008 Nokia Corporation - * - * Written by Tony Lindgren - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [120924 06:08]: Hi, On Mon, Sep 24, 2012 at 03:54:22PM +0300, Philippe De Swert wrote: Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well still in the progress of migrating of my personal to work laptop. Since the

MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.939422] unable to find transceiver of type USB2 PHYrouping on. Total pages: 251648 [1.945190] HS

[PATCH 04/16] ARM: OMAP: Make plat/fpga.h local to arch/arm/plat-omap

2012-10-04 Thread Tony Lindgren
until we flip over mach-omap2 to device tree. Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Florian Tobias Schandinat florianschandi...@gmx.de Cc: linux-fb...@vger.kernel.org Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/mach

Re: MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121004 11:04]: Hi, On Thu, Oct 04, 2012 at 10:31:08AM -0700, Tony Lindgren wrote: Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg

Re: MUSB regression in linux next at least for pandboard

2012-10-05 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [121004 18:41]: Also on the EHCI port, I've seen issues where unplugging the cable hangs kernel with an infinite loop. But that happens only occasionally, sorry does not seem to happen right now so no output to paste here. Or maybe this issue has

Re: [PATCH 1/1] musb : remove generic_interrupt and have all drivers define the isr on their own. Remove some unneeded CONFIG_SOC_OMAP_3430 instances

2012-10-08 Thread Tony Lindgren
that Tony Lindgren predicted would happen at some point. Thanks looks OK to me: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-10 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I kis...@ti.com [120919 04:32]: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy driver and the documentation with device tree binding information is updated.

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-12 Thread Tony Lindgren
* kishon kis...@ti.com [121012 02:10]: Hi Tony, On Thursday 11 October 2012 06:29 AM, Tony Lindgren wrote: Hi, * Kishon Vijay Abraham I kis...@ti.com [120919 04:32]: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes

Re: [PATCH 1/1] ARM: dts: omap5: Add clocks to USB3 PHY node

2014-04-18 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140414 00:23]: Hi Tony, On 04/01/2014 05:13 PM, Felipe Balbi wrote: On Tue, Apr 01, 2014 at 01:37:27PM +0300, Roger Quadros wrote: The USB3 PHY driver (ti-pipe3) was updated so that the relevant clock phandles are expected in the DT node. Provide the

Re: [PATCH v3 7/7] dts: dra7-evm: add USB support

2014-05-13 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140505 02:55]: Add USB pinmux information and USB modes for the USB controllers. CC: Benoît Cousson bcous...@baylibre.com Reviewed-by: Felipe Balbi ba...@ti.com Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/dra7-evm.dts | 24

Re: [PATCH v4 7/7] dts: dra7-evm: add USB support

2014-05-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140514 00:59]: From: Roger Quadros rog...@ti.com Add USB pinmux information and USB modes for the USB controllers. Thanks, applying all the .dts changes in this series into omap-for-v3.16/dt. Using the non-irqbar versions. Tony -- To unsubscribe from this

Re: [PATCH v2] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP

2014-05-16 Thread Tony Lindgren
* Paul Bolle pebo...@tiscali.nl [140516 03:01]: Commit 193ab2a60700 (usb: gadget: allow multiple gadgets to be built) apparently required that checks for CONFIG_USB_GADGET_OMAP would be replaced with checks for CONFIG_USB_OMAP. Do so now for the remaining checks for CONFIG_USB_GADGET_OMAP,

Re: [PATCH v3 09/10] ARM: dts: omap3-beagle-xm: Add USB Host support

2013-11-26 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131120 02:33]: Nishant, On 11/19/2013 11:05 PM, Nishanth Menon wrote: On 09/24/2013 03:53 AM, Roger Quadros wrote: Provide RESET GPIO and Power regulator for the USB PHY, the USB Host port mode and the PHY device for the controller. Also provide pin

Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13)

2013-11-26 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131126 00:57]: On 11/25/2013 05:50 PM, Nishanth Menon wrote: On Mon, Nov 25, 2013 at 7:55 AM, Roger Quadros rog...@ti.com wrote: Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply for the USB PHY. As the generic PHY driver can't handle more

Re: [PATCH v2 5/6] Revert ARM: OMAP2+: Provide alias to USB PHY clock

2013-12-08 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131023 03:14]: On 10/22/2013 06:17 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [131010 02:23]: On 10/09/2013 06:15 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [131009 00:19]: Hi Tony, On 10/08/2013 01:06 PM, Roger Quadros wrote

Re: [PATCH 1/3] ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module

2013-12-08 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [131208 17:27]: Hi Benoît, On Tue, 3 Dec 2013, Roger Quadros wrote: Without this, the USB devices are sometimes not detected on OMAP4 Panda with u-boot v2013.10. Unlike what the comment states, errata i660 does not state that we can't RESET the USB

Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-12-09 Thread Tony Lindgren
* Javier Martinez Canillas jav...@dowhile0.org [131209 03:51]: Hi Kishon, On Mon, Dec 9, 2013 at 7:07 AM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Saturday 07 December 2013 02:38 AM, Felipe Balbi wrote: Hi, On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez

Re: [PATCH] phy: omap_usb2: fix module dependency

2013-12-10 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [131210 12:26]: Due to over-use of select statements, we could fall into a situation where CONFIG_USB_PHY would be enabled while CONFIG_USB_SUPPORT wouldn't. This would generate a situation where usb_bind_phy() would not be defined and kernel build for some

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2013-12-16 Thread Tony Lindgren
-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ARM: OMAP2+: Introduce local usb.h

2012-10-18 Thread Tony Lindgren
gre...@linuxfoundation.org Cc: Partha Basak part...@india.ti.com Cc: Keshava Munegowda keshava_mgo...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap1/clock.c |1 arch/arm/mach-omap2/board-2430sdp.c |1

[PATCH 2/2] ARM: OMAP: move OMAP USB platform data to linux/platform_data/omap-usb.h

2012-10-18 Thread Tony Lindgren
-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/board-4430sdp.c|1 + arch/arm/mach-omap2/board-am3517evm.c |1 + arch/arm/mach-omap2/board-omap3evm.c |1 + arch/arm/mach-omap2/board-omap4panda.c |1 + arch/arm/mach-omap2/board-rx51.c |1 + arch/arm/mach

  1   2   3   4   5   6   7   >