Re: [PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-15 Thread Tony Lindgren
Hi, I think you can get rid of quite a bit more of the repeated data for most boards, see below. * Roger Quadros rog...@ti.com [130315 08:21]: Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130314 08:45]: OK. Let me know how the below patch looks. After that, the board code will look like. static struct usbhs_phy_data phy_data[] = { { .reset_gpio = 147, .vcc_gpio = 148 .vcc_polarity = 1,

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130313 06:46]: On 03/12/2013 06:40 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. ... arch

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130313 09:40]: On 03/13/2013 06:24 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130313 06:46]: On 03/12/2013 06:40 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-12 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130312 04:47]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. ... arch/arm/mach-omap2/board-3430sdp.c| 97 +++-

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Patch makes sens to me, just a related question.. Do you get this when trying to enable the host mode,

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130311 10:12]: On Mon, Mar 11, 2013 at 6:24 PM, Tony Lindgren t...@atomide.com wrote: * Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least

Re: [RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130307 06:44]: +#include mach/usb.h We should be getting rid of the plat and mach includes for drivers for omap1 also, so let's not make it harder by adding more of it. We should have just the following: include/linux/platform_data/usb-omap.h this contains

Re: [GIT PULL] arm-soc: OMAP USB Host cleanup for 3.9

2013-02-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130214 04:08]: Hi Tony, This is the ARM-soc part of the OMAP USB Host cleanup series for 3.9. It is based on 3.8-rc6 + usbhost17-common that I sent earlier. Please pull. Thanks. Thanks for reworking this series! I'll pull this. Regards, Tony The

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-06 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130206 01:53]: On 02/05/2013 07:17 PM, Tony Lindgren wrote: * Greg KH gre...@linuxfoundation.org [130205 09:00]: On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: Hi Tony Greg, What's the best way to get these patches in? All patches have

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-05 Thread Tony Lindgren
* Greg KH gre...@linuxfoundation.org [130205 09:00]: On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: Hi Tony Greg, What's the best way to get these patches in? All patches have been acked by respective maintainers. If Tony can Ack the arch/arm/mach-omap2 stuff

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread Tony Lindgren
my Acked-by: Tony Lindgren t...@atomide.com for those. 2. A branch for Benoit based on v3.8-rc6 That branch should contain all the .dts changes as those will most likely cause nasty merge conflicts otherwise with what Benoit has queued up. Regards, Tony -- To unsubscribe from this list

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-02-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130204 07:57]: Hi, On Fri, Feb 01, 2013 at 11:14:24AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [130125 02:30]: Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-02-01 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130125 02:30]: Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own.

Re: [PATCH v2 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-02-01 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [130123 03:27]: Hi, On Mon, Jan 21, 2013 at 07:38:26PM +0530, Kishon Vijay Abraham I wrote: A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be

Re: [PATCH v2 3/6] ARM: OMAP: USB: Add phy binding information

2013-02-01 Thread Tony Lindgren
* Kishon Vijay Abraham I kis...@ti.com [130124 18:36]: This is w.r.t the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding information between the PHY and the USB controller should be specified in the platform specific

Re: [PATCH v7 01/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-17 Thread Tony Lindgren
* Alan Stern st...@rowland.harvard.edu [130117 07:19]: On Thu, 17 Jan 2013, Roger Quadros wrote: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130117 03:34]: We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. It's best that Paul queues this and the next patch as these clock alias clean-up patches can be done separately. That way the dependency between

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [130117 14:33]: On Thu, 17 Jan 2013, Felipe Balbi wrote: do you mean v3.9 ? It sounds like the other patches need to be merged first before these cleanups can be merged. So rather than adding a merge order dependency during 3.9, it seems best to queue

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130114 03:31]: On 01/11/2013 08:13 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130111 01:43]: Tony, On 01/11/2013 01:45 AM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-11 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130111 01:43]: Tony, On 01/11/2013 01:45 AM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-10 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130110 08:54]: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and

Re: [PATCH v4 16/23] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-12-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [121210 02:23]: There is no such clock as utmi_p1_gfclk. It is only a clock selector bit to select th the parent of usb_host_hs_utmi_p1_clk. So we get rid of utmi_p1_gfclk and utmi_p2_gfclk by merging them into usb_host_hs_utmi_p1_clk and usb_host_hs_utmi_p2_clk

Re: [PATCH v4 01/23] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-12-14 Thread Tony Lindgren
* Samuel Ortiz sa...@linux.intel.com [121213 16:57]: Hi Tony, On Thu, Dec 13, 2012 at 01:49:49PM -0800, Tony Lindgren wrote: Hi Samuel, * Roger Quadros rog...@ti.com [121210 02:23]: Instead of using cpu_is_omap..() macros in the device driver we rely on information provided

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Tony Lindgren
* Ian Coolidge iancooli...@gmail.com [121214 01:55]: Hi, We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded product. For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral mode. We use the Ethernet gadget configured for cdc_eem to use Ethernet

Re: [PATCH v4 01/23] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-12-13 Thread Tony Lindgren
. Want to ack this one? Regards, Tony Signed-off-by: Roger Quadros rog...@ti.com CC: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/usb-host.c |4 drivers/mfd/omap-usb-host.c|2 +- include/linux/platform_data/usb-omap.h |3 +++ 3 files

Re: [PATCH v3 01/23] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-12-05 Thread Tony Lindgren
in this series with scripts/get_maintainer.pl to see who all should be cc:ed? Regards, Tony Signed-off-by: Roger Quadros rog...@ti.com CC: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/usb-host.c |4 drivers/mfd/omap-usb-host.c|2 +- include/linux

Re: [PATCH v2 13/22] mfd: omap-usb-host: override number of ports from platform data

2012-11-28 Thread Tony Lindgren
that plat/usb.h is now include/linux/platform_data/usb-omap.h in linux next so you need to coordinate with that. For the arch/arm/*omap*/* parts: Acked-by: Tony Lindgren t...@atomide.com diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index 3c43449..eb85528 100644

Re: [PATCH v2 18/22] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-11-28 Thread Tony Lindgren
. Other than that: Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Roger Quadros rog...@ti.com CC: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/usb-host.c|4 arch/arm/plat-omap/include/plat/usb.h |3 +++ drivers/mfd/omap-usb-host.c |3

Re: [PATCH 00/16] OMAP USB Host cleanup

2012-11-20 Thread Tony Lindgren
Hi Roger, * Kevin Hilman khil...@deeprootsystems.com [121119 15:24]: Roger Quadros rog...@ti.com writes: Kevin, On 11/16/2012 10:08 PM, Kevin Hilman wrote: Roger Quadros rog...@ti.com writes: Hi, This patchset addresses the following - Avoid addressing clocks one by one by

Re: [PATCHv2 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-11-06 Thread Tony Lindgren
(g_mass_storage). This commit changes defconfigs point to the new gadget. Signed-off-by: Michal Nazarewicz min...@mina86.com I need more Acks here. Only got one from Nicolas. Anyone else ? For omaps: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line

Re: [PATCHv2 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-11-06 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121106 12:40]: Hi, On Tue, Nov 06, 2012 at 10:42:27AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121106 10:41]: * Felipe Balbi ba...@ti.com [121106 03:40]: Hi, On Fri, Nov 02, 2012 at 02:31:50PM +0100, Michal Nazarewicz wrote

Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Tony Lindgren
* Keshava Munegowda keshava_mgo...@ti.com [121031 07:29]: The USB2 Host device node is extracted and used in the probe of the driver to initialize the usb ports and controller. The platform specific initialization is also performed. Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com ---

[PATCH 1/2] ARM: OMAP2+: Introduce local usb.h

2012-10-18 Thread Tony Lindgren
gre...@linuxfoundation.org Cc: Partha Basak part...@india.ti.com Cc: Keshava Munegowda keshava_mgo...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap1/clock.c |1 arch/arm/mach-omap2/board-2430sdp.c |1

[PATCH 2/2] ARM: OMAP: move OMAP USB platform data to linux/platform_data/omap-usb.h

2012-10-18 Thread Tony Lindgren
-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/board-4430sdp.c|1 + arch/arm/mach-omap2/board-am3517evm.c |1 + arch/arm/mach-omap2/board-omap3evm.c |1 + arch/arm/mach-omap2/board-omap4panda.c |1 + arch/arm/mach-omap2/board-rx51.c |1 + arch/arm/mach

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-12 Thread Tony Lindgren
* kishon kis...@ti.com [121012 02:10]: Hi Tony, On Thursday 11 October 2012 06:29 AM, Tony Lindgren wrote: Hi, * Kishon Vijay Abraham I kis...@ti.com [120919 04:32]: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-10 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I kis...@ti.com [120919 04:32]: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy driver and the documentation with device tree binding information is updated.

Re: [PATCH 1/1] musb : remove generic_interrupt and have all drivers define the isr on their own. Remove some unneeded CONFIG_SOC_OMAP_3430 instances

2012-10-08 Thread Tony Lindgren
that Tony Lindgren predicted would happen at some point. Thanks looks OK to me: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: MUSB regression in linux next at least for pandboard

2012-10-05 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [121004 18:41]: Also on the EHCI port, I've seen issues where unplugging the cable hangs kernel with an infinite loop. But that happens only occasionally, sorry does not seem to happen right now so no output to paste here. Or maybe this issue has

MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.939422] unable to find transceiver of type USB2 PHYrouping on. Total pages: 251648 [1.945190] HS

[PATCH 04/16] ARM: OMAP: Make plat/fpga.h local to arch/arm/plat-omap

2012-10-04 Thread Tony Lindgren
until we flip over mach-omap2 to device tree. Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Florian Tobias Schandinat florianschandi...@gmx.de Cc: linux-fb...@vger.kernel.org Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/mach

Re: MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121004 11:04]: Hi, On Thu, Oct 04, 2012 at 10:31:08AM -0700, Tony Lindgren wrote: Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [120924 06:08]: Hi, On Mon, Sep 24, 2012 at 03:54:22PM +0300, Philippe De Swert wrote: Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well still in the progress of migrating of my personal to work laptop. Since the

[PATCH 03/29] ARM: OMAP1: Make plat/mux.h omap1 only

2012-09-19 Thread Tony Lindgren
- * - * Copyright (C) 2003 - 2008 Nokia Corporation - * - * Written by Tony Lindgren - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [120906 10:23]: Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Tony Lindgren
* Ravi Babu ravib...@ti.com [120831 04:10]: --- a/arch/arm/plat-omap/include/plat/usb.h +++ b/arch/arm/plat-omap/include/plat/usb.h @@ -95,7 +95,6 @@ extern void am35x_musb_reset(void); extern void am35x_musb_phy_power(u8 on); extern void am35x_musb_clear_irq(void); extern void

Re: Infinite looping in omap2430.c USB driver

2012-07-09 Thread Tony Lindgren
* NeilBrown ne...@suse.de [120706 15:44]: Hello `./scripts/get_maintainer.pl -f drivers/usb/musb/omap2430.c` omap2430_musb_set_vbus in omap2430.c contains: while (musb_readb(musb-mregs, MUSB_DEVCTL) 0x80) { cpu_relax();

<    2   3   4   5   6   7