From: Oliver Neukum oneu...@suse.de
Both could want to submit the same URB. Some checks of the flag
intended to prevent that were missing.
Signed-off-by: Oliver Neukum oneu...@suse.de
CC: sta...@vger.kernel.org
---
drivers/usb/class/cdc-wdm.c | 13 +
1 file changed, 9 insertions
From: Oliver Neukum oneu...@suse.de
These devices tend to become unresponsive after S3
Signed-off-by: Oliver Neukum oneu...@suse.de
CC: sta...@vger.kernel.org
---
drivers/usb/core/quirks.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core
From: Oliver Neukum oneu...@suse.de
Some systems although they have firmware class 'M', which usually
needs a work around to not crash, must not be subjected to the
work around because the work around crashes them. They cannot be
told apart by their own device descriptor, but as they are part
From: Oliver Neukum oneu...@suse.de
Some systems although they have firmware class 'M', which usually
needs a work around to not crash, must not be subjected to the
work around because the work around crashes them. They cannot be
told apart by their own device descriptor, but as they are part
From: Oliver Neukum oneu...@suse.de
Some controllers really do need much longer than the standard
allows.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/xhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
It has been reported that this chipset really cannot
sleep without this extraordinary delay.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/xhci-pci.c | 8
drivers/usb/host/xhci.c | 9 +++--
drivers/usb/host/xhci.h | 1
From: Oliver Neukum oneu...@suse.de
Some USB drive enclosures do not correctly report an
overflow condition if they hold a drive with a capacity
over 2TB and are confronted with a READ_CAPACITY_10.
They answer with their capacity modulo 2TB.
The generic layer cannot cope with that. It must
From: Oliver Neukum oneu...@suse.de
The device is not responsive when resumed, unless it is reset.
Signed-off-by: Oliver Neukum oneu...@suse.de
CC: sta...@vger.kernel.org
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb
From: Oliver Neukum oneu...@suse.de
The device descriptors are messed up after remote wakeup
Signed-off-by: Oliver Neukum oneu...@suse.de
CC: sta...@vger.kernel.org
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core
From: Oliver Neukum oneu...@suse.de
This converts the DEBUG level printk to dynamic debugging
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-dbg.c | 104 ++--
drivers/usb/host/ohci-hcd.c | 4 --
drivers/usb/host/ohci-q.c | 2
From: Oliver Neukum oneu...@suse.de
There's no reason to leave out the debugfs files
under normal conditions.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-dbg.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/host/ohci-dbg.c b
From: Oliver Neukum oneu...@suse.de
As this function is called from interrupt care must
be taken that as little as possible overhead is used
if dynamic debbuging is not enabled.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-dbg.c | 91
From: Oliver Neukum oneu...@suse.de
For dynamic debug the overhead for evaluating parameters must
be sacrificed only if the message is actually printed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
From: Oliver Neukum oneu...@suse.de
Rewrite it so that the status is evaluated only if the
printk is actually executed.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-dbg.c | 51 +
1 file changed, 24 insertions(+), 27 deletions
From: Oliver Neukum oneu...@suse.de
Conditional compilation for debugging is removed in favor of
dynamic debugging. To do so
1. the support for debugfs is always compiled
2. the support for the ancient print_urb debugging aid is removed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is made in user space.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb
From: Oliver Neukum oneu...@suse.de
The decision about what is interesting is done in user space
when dynamic debugging is used.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
With dynamic debugging the selection is done in user space
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci
From: Oliver Neukum oneu...@suse.de
With the new dbg_status() the interrupt handler doesn't need
conditional compilation
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci
From: Oliver Neukum oneu...@suse.de
Always compile in the debugfs support
---
drivers/usb/host/fotg210-hcd.c | 8
drivers/usb/host/fotg210.h | 8
2 files changed, 16 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 55486bd
From: Oliver Neukum oneu...@suse.de
Just remove the conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 501ecea..de0e3e4
From: Oliver Neukum oneu...@suse.de
With the introduction of dynamic debugging it has become redundant.
Collapse it with ohci_dbg()
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 4 ++--
drivers/usb/host/ohci-q.c | 8
drivers/usb/host/ohci.h | 2
From: Oliver Neukum oneu...@suse.de
The expensive evaluation should be done only if a message is
actually to be printed.
Signed-off-by: Oliver Neukum oneukum2suse.de
---
drivers/usb/host/fotg210-hcd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is shifted to user space by
dynamic debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
This gets rid of conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 31 ---
drivers/usb/host/fusbh200.h | 8
2 files changed, 39 deletions(-)
diff --git
From: Oliver Neukum oneu...@suse.de
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 44 +++-
1 file
From: Oliver Neukum oneu...@suse.de
This makes sure the header files are all there
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
From: Oliver Neukum oneu...@suse.de
This makes sure the header files are all there
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
From: Oliver Neukum oneu...@suse.de
No need for conditional compilation here.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index
From: Oliver Neukum oneu...@suse.de
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 48 +++--
1
From: Oliver Neukum oneu...@suse.de
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
It has become unnecessary by #define trickery
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index 8631862..d6e2814
From: Oliver Neukum oneu...@suse.de
With dynamic debugging the selection is done in user space
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci
From: Oliver Neukum oneu...@suse.de
With the introduction of dynamic debugging it has become redundant.
Collapse it with ohci_dbg()
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 4 ++--
drivers/usb/host/ohci-q.c | 8
drivers/usb/host/ohci.h | 2
From: Oliver Neukum oneu...@suse.de
Just remove the conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 501ecea..de0e3e4
From: Oliver Neukum oneu...@suse.de
Conditional compilation for debugging is removed in favor of
dynamic debugging. To do so
1. the support for debugfs is always compiled
2. the support for the ancient print_urb debugging aid is removed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers
From: Oliver Neukum oneu...@suse.de
With the new dbg_status() the interrupt handler doesn't need
conditional compilation
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci
From: Oliver Neukum oneu...@suse.de
The decision about what is interesting is done in user space
when dynamic debugging is used.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
Rewrite it so that the status is evaluated only if the
printk is actually executed.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-dbg.c | 51 +
1 file changed, 24 insertions(+), 27 deletions
From: Oliver Neukum oneu...@suse.de
Always compile in the debugfs support
---
drivers/usb/host/fotg210-hcd.c | 8
drivers/usb/host/fotg210.h | 8
2 files changed, 16 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 55486bd
From: Oliver Neukum oneu...@suse.de
Simply remove the conditional compilation and remove
the empty stubs.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 47 --
1 file changed, 47 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
The expensive evaluation should be done only if a message is
actually to be printed.
Signed-off-by: Oliver Neukum oneukum2suse.de
---
drivers/usb/host/fotg210-hcd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
These helpers are used only during setup of a HCD.
A small overhead is no problem.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/usb/host/fusbh200
From: Oliver Neukum oneu...@suse.de
Rewrite for little overhead so that it can be used
in interrupt handlers for dynamic debugging
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
From: Oliver Neukum oneu...@suse.de
This gets rid of conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 31 ---
drivers/usb/host/fusbh200.h | 8
2 files changed, 39 deletions(-)
diff --git
From: Oliver Neukum oneu...@suse.de
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is made in user space.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb
From: Oliver Neukum oneu...@suse.de
This allows removal of much conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 17 ++---
drivers/usb/host/fusbh200.h | 4
2 files changed, 2 insertions(+), 19 deletions(-)
diff
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is shifted to user space by
dynamic debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
It has become unnecessary by #define trickery
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index 8631862..d6e2814
From: Oliver Neukum oneu...@suse.de
In the drivers that no longer need it, it is removed.
It is removed from the Makefile. Drivers not fully converted
to dynamic debug have it shifted down into the individual
drivers.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/Makefile
From: Oliver Neukum oneu...@suse.de
For dynamic debug the overhead for evaluating parameters must
be sacrificed only if the message is actually printed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
From: Oliver Neukum oneu...@suse.de
With dynamic debugging this log level is no longer supported.
The decision which messages are interesting is done in user space.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 16 +---
1 file changed, 5
From: Oliver Neukum oneu...@suse.de
This makes sure the header files are all there
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
From: Oliver Neukum oneu...@suse.de
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 48 +++--
1
From: Oliver Neukum oneu...@suse.de
No need for conditional compilation here.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index
From: Oliver Neukum oneu...@suse.de
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
With the introduction of dynamic debugging it has become redundant.
Collapse it with ohci_dbg()
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 4 ++--
drivers/usb/host/ohci-q.c | 8
drivers/usb/host/ohci.h | 6
From: Oliver Neukum oneu...@suse.de
Just remove the conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hcd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 501ecea..de0e3e4
From: Oliver Neukum oneu...@suse.de
This makes sure the header files are all there
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
From: Oliver Neukum oneu...@suse.de
These helpers are used only during setup of a HCD.
A small overhead is no problem.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/usb/host/fusbh200
From: Oliver Neukum oneu...@suse.de
This gets rid of conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 31 ---
drivers/usb/host/fusbh200.h | 8
2 files changed, 39 deletions(-)
diff --git
From: Oliver Neukum oneu...@suse.de
For dynamic debug the overhead for evaluating parameters must
be sacrificed only if the message is actually printed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
From: Oliver Neukum oneu...@suse.de
Simply remove the conditional compilation and remove
the empty stubs.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 47 --
1 file changed, 47 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
In the drivers that no longer need it, it is removed.
It is removed from the Makefile. Drivers not fully converted
to dynamic debug have it shifted down into the individual
drivers.
Signed-off-by: Oliver Neukum oneu...@suse.deusb: kill DEBUG compile option
From: Oliver Neukum oneu...@suse.de
This is overkill. Just removeit.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index e8ba4c4..b57e997 100644
From: Oliver Neukum oneu...@suse.de
This allows removal of much conditional compilation.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 20
drivers/usb/host/fusbh200.h | 4
2 files changed, 4 insertions(+), 20 deletions(-)
diff
From: Oliver Neukum oneu...@suse.de
Simple elemination of the conditional compilation
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hub.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
From: Oliver Neukum oneu...@suse.de
It is useless now. Straight removal.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 1 -
drivers/usb/host/fotg210-hcd.c | 1 -
drivers/usb/host/fusbh200-hcd.c | 1 -
drivers/usb/host/ohci-hcd.c | 2 --
4 files changed
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is made in user space.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers
From: Oliver Neukum oneu...@suse.de
Always compile in the debugfs support
---
drivers/usb/host/fotg210-hcd.c | 8
drivers/usb/host/fotg210.h | 8
2 files changed, 16 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 55486bd
From: Oliver Neukum oneu...@suse.de
That logging is overkill. Simply remove it.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index
From: Oliver Neukum oneu...@suse.de
With dynamic debugging this log level is no longer supported.
The decision which messages are interesting is done in user space.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 16 +---
1 file changed, 5
From: Oliver Neukum oneu...@suse.de
Conditional compilation for debugging is removed in favor of
dynamic debugging. To do so
1. the support for debugfs is always compiled
2. the support for the ancient print_urb debugging aid is removed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers
From: Oliver Neukum oneu...@suse.de
With dynamic debugging the selection is done in user space
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ohci-hub.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
The decision what is interesting is shifted to user space by
dynamic debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
From: Oliver Neukum oneu...@suse.de
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(CONFIG_DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/uhci-hcd.c | 44
From: Oliver Neukum oneu...@suse.de
It is useless now. Straight removal.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 1 -
drivers/usb/host/fotg210-hcd.c | 1 -
drivers/usb/host/fusbh200-hcd.c | 1 -
drivers/usb/host/ohci-hcd.c | 2 --
4 files changed
From: Oliver Neukum oneu...@suse.de
It is useless now. Straight removal.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hcd.c | 1 -
drivers/usb/host/fotg210-hcd.c | 1 -
drivers/usb/host/fusbh200-hcd.c | 1 -
drivers/usb/host/ohci-hcd.c | 2 --
4 files changed
From: Oliver Neukum oneu...@suse.de
The buffer for responses must not overflow.
If this would happen, set a flag, drop the data and return
an error after user space has read all remaining data.
Signed-off-by: Oliver Neukum oli...@neukum.org
CC: sta...@kernel.org
---
drivers/usb/class/cdc-wdm.c
From: Oliver Neukum oneu...@suse.de
The buffer for responses must not overflow.
If this would happen, set a flag, drop the data and return
an error after user space has read all remaining data.
Signed-off-by: Oliver Neukum oli...@neukum.org
CC: sta...@kernel.org
---
drivers/usb/class/cdc-wdm.c
From: Oliver Neukum oneu...@suse.de
uas_probe() calls usb_alloc_streams(). That can fail on XHCI
with -ENOSYS if the controller doesn't support streams. In that
case devices should be handed over to storage. Thus the driver
needs to return -ENODEV so that the driver core will give other
drivers
From: Oliver Neukum oneu...@suse.de
On some older XHCIs streams are not supported and the UAS driver
will fail at probe time. For those devices storage should try
to bind to UAS devices.
This patch adds a flag for stream support to HCDs and evaluates
it.
Signed-off-by: Oliver Neukum oneu
From: Oliver Neukum oneu...@suse.de
Define usb_lock_port and usb_unlock_port in all cases
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/core/hub.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 28d1218..68d077e 100644
From: Oliver Neukum oneu...@suse.de
On some older XHCIs streams are not supported and the UAS driver
will fail at probe time. For those devices storage should try
to bind to UAS devices.
This patch adds a flag for stream support to HCDs and evaluates
it.
Signed-off-by: Oliver Neukum oli
From: Oliver Neukum oneu...@suse.de
This error case isn't reported during enumeration.
Signed-off-by: Oliver Neukum oli...@neukum.org
---
drivers/usb/core/hub.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 726f4a1
From: Oliver Neukum oneu...@suse.de
I have a device that times out if enumerated after being
switched on while connected. Increasing timeouts or retries
doesn't help. The device needs an additional reset.
Signed-off-by: Oliver Neukum oli...@neukum.org
---
drivers/usb/core/hub.c | 15
From: Oliver Neukum oneu...@suse.de
Quote Dan:
The patch e36e64930cff: uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible from Nov 7, 2013, leads to the following static
checker warning:
drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
error: scheduling with locks held
From: Oliver Neukum oneu...@suse.de
There is an allocation with GFP_NOIO with a spinlock
held that the checker didn't catch.
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver
From: Oliver Neukum oneu...@suse.de
Quote Dan:
The patch e36e64930cff: uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible from Nov 7, 2013, leads to the following static
checker warning:
drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
error: scheduling with locks held
From: Oliver Neukum oneu...@suse.de
There is an allocation with GFP_NOIO with a spinlock
held that the checker didn't catch.
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver
From: Oliver Neukum oneu...@suse.de
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver Neukum oli...@neukum.org
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2
From: Oliver Neukum oneu...@suse.de
intfdata is set only after scsi_scan(). uas_pre_reset() however
needs intfdata to be valid and will follow the NULL pointer
killing khubd. intfdata must be preemptively set before the
host is registered and undone in the error case.
Signed-off-by: Oliver
From: Oliver Neukum oli...@neukum.org
Werner Fink has reported problems with this hub.
Signed-off-by: Oliver Neukum oli...@neukum.org
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 3113c1d..e14346a
From: Oliver Neukum oli...@neukum.org
As a bitmap is used for free/used. As a device freed
all memory operations must be scheduled before the bitmap
is manipulated.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/dwc3/core.c |1 +
1 files changed, 1 insertions(+), 0 deletions
From: Oliver Neukum oneu...@suse.de
Either we log for all chips we set the quirk for or for
none. This patch reports it for all chips.
Signed-off-by: Oliver Neukum oli...@neukum.org
---
drivers/usb/host/xhci-pci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers
From: Oliver Neukum oneu...@suse.de
Simple elemination of the conditional compilation
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/ehci-hub.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
From: Oliver Neukum oneu...@suse.de
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host
From: Oliver Neukum oneu...@suse.de
For dynamic debug the overhead for evaluating parameters must
be sacrificed only if the message is actually printed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
From: Oliver Neukum oneu...@suse.de
Conditional compilation for debugging is removed in favor of
dynamic debugging. To do so
1. the support for debugfs is always compiled
2. the support for the ancient print_urb debugging aid is removed
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers
1 - 100 of 1750 matches
Mail list logo
