[PATCH] USB: option: add support for DW5821e

#EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option Signed-off-by: Aleksander Morgado Cc

Re: [PATCH] usb: serial: qcserial: add support for the Dell DW5821e module

>> I believe Aleksander might be referring to usb_choose_configuration() in >> drivers/usb/core/generic.c? It does some confusing things with >> multi-function/multi-configuration devices, explained by this comment: >> >> /* From the remaining configs, choose the first one whose >>

Re: [PATCH] usb: serial: qcserial: add support for the Dell DW5821e module

>> >> This would be when running on configuration #1: >> >> T: Bus=04 Lev=03 Prnt=04 Port=02 Cnt=01 Dev#= 7 Spd=5000 MxCh= 0 >> D: Ver= 3.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 2 >> P: Vendor=413c ProdID=81d7 Rev=03.18 >> S: Manufacturer=DELL >> S: Product=DW5821e Snapdragon X20 LTE

Re: [PATCH] usb: serial: qcserial: add support for the Dell DW5821e module

On Tue, Jun 26, 2018 at 8:09 AM, Johan Hovold wrote: > On Sat, Jun 23, 2018 at 11:24:08PM +0200, Aleksander Morgado wrote: >> This module exposes two USB configurations: a QMI+AT capable setup on >> USB config #1 and a MBIM capable setup on USB config #2. >> >> By def

[PATCH] usb: serial: qcserial: add support for the Dell DW5821e module

in the secondary configuration. Signed-off-by: Aleksander Morgado --- drivers/usb/serial/qcserial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 613f91add03d..ed109c86e747 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb

[PATCH] cdc_ether: flag the Huawei ME906/ME909 as WWAN

The Huawei ME906 (12d1:15c1) comes with a standard ECM interface that requires management via AT commands sent over one of the control TTYs (e.g. connected with AT^NDISDUP). Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> --- drivers/net/usb/cdc_ether.c | 6 ++ 1 file chan

[PATCH] cdc_ether: flag the u-blox TOBY-L2 and SARA-U2 as wwan

-by: Aleksander Morgado <aleksan...@aleksander.es> --- drivers/net/usb/cdc_ether.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 29c7e2ec0dcb..52ea80bcd639 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drive

[PATCH] rndis_host: support Novatel Verizon USB730L

ECM interface which doesn't require any other kernel update to make it work. Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> --- Hey, I'm not sure if binding this logic to a specific vid:pid (1410:9030) would be more appropriate here, or if it's ok to just bind class/subclass

[PATCH v2] cdc_ncm: flag the u-blox TOBY-L4 as wwan

=1,' and then running DHCP on the NCM interface. Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> --- drivers/net/usb/cdc_ncm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 811b18215cae..47cab1bde065

Re: [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan

On Fri, Aug 25, 2017 at 3:22 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Fri, Aug 25, 2017 at 02:59:46PM +0200, Aleksander Morgado wrote: >> Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> >> --- >> drivers/net/usb/cdc_ncm.c | 7 +++

[PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan

Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> --- drivers/net/usb/cdc_ncm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 811b18215cae..47cab1bde065 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/n

Re: issues with commit c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")

Hey Bjørn, On Thu, Apr 20, 2017 at 10:32 AM, Bjørn Mork wrote: > Sorry for being much too late here, but during recent attemts to debug > issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due > to missing notifications") I believe I found a couple of issues with

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

On Wed, Apr 19, 2017 at 7:28 PM, Bjørn Mork wrote: >> as a side note in latest kernels I had troubles with qmi devices >> (e.g. I/O error when using qmicli). >> >> I found your suggestion in libqmi mailing list to revert commit >> >> 833415a3e781a26fe480a34d45086bdb4fe1e4c0 >>

[PATCH] USB: qcserial: add Dell DW5570 QDL

The Dell DW5570 is a re-branded Sierra Wireless MC8805 which will by default boot with vid 0x413c and pid 0x81a3. When triggered QDL download mode, the device switches to pid 0x81a6 and provides the standard TTY used for firmware upgrade. Cc: <sta...@vger.kernel.org> Signed-off-by: Alek

Re: 03f0:521d Hewlett-Packard

On Thu, Apr 21, 2016 at 7:15 AM, mirkt wrote: > Bus 001 Device 007: ID 03f0:521d Hewlett-Packard > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 255 Vendor Specific Class > bDeviceSubClass

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

On Thu, Dec 3, 2015 at 7:24 PM, Bjørn Mork wrote: > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra

[PATCH] USB: serial: option: add support for Novatel MiFi USB620L

guide). Signed-off-by: Aleksander Morgado <aleksan...@aleksander.es> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 685fef7..2ab2a33 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/

Re: [PATCH 1/2] xhci: fix reporting of 0-sized URBs in control endpoint

On Fri, Mar 6, 2015 at 7:08 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 03/06/2015 06:14 PM, Mathias Nyman wrote: From: Aleksander Morgado aleksan...@aleksander.es When a control transfer has a short data stage, the xHCI controller generates two transfer

[PATCH] xhci: no need to check for URB_SHORT_NOT_OK

the status is always set to 0. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/host/xhci-ring.c | 51 +++- 1 file changed, 8 insertions(+), 43 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[PATCH v5] xhci: fix reporting of 0-sized URBs in control endpoint

-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- Hey Mathias, This v5 of the patch takes into account the possibility of needing to return -EREMOTEIO if URB_SHORT_NOT_OK was requested in the transfer flags

Re: [RFC PATCH] xhci: fix reporting of 0-sized URBs in control endpoints

On Mon, Mar 2, 2015 at 12:57 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: On 26.02.2015 23:59, Aleksander Morgado wrote: On Thu, Feb 26, 2015 at 5:12 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: When a control transfer has a short data stage, the xHCI controller generates

Re: [RFC PATCH] xhci: fix reporting of 0-sized URBs in control endpoints

On Mon, Mar 2, 2015 at 4:02 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 2 Mar 2015, Aleksander Morgado wrote: I think my patch also lacks the -EREMOTEIO return for the case when 0 bytes are transferred. I'll try to update it today. It's not necessary. The USB core automatically

[PATCH] hso: add missing spinlock grab when iterating the serial table

Access to the 'serial_table' array needs to be protected by the spinlock. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/hso.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 3c8dfe5

Re: [RFC PATCH] xhci: fix reporting of 0-sized URBs in control endpoints

...@linux.intel.com Tested this patch (with the extra else if suggested in the follow up commit) and it seems to work correctly with the HSO plugin. Not sure if it'll end up being the last version or not, but anyway: Tested-by: Aleksander Morgado aleksan...@aleksander.es Let me know if you want me

Re: [PATCH] hso: add missing spinlock grab when iterating the serial table

On Fri, Feb 27, 2015 at 7:44 PM, Aleksander Morgado aleksan...@aleksander.es wrote: Access to the 'serial_table' array needs to be protected by the spinlock. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/hso.c | 9 +++-- 1 file changed, 7 insertions

Re: [RFC PATCH] xhci: fix reporting of 0-sized URBs in control endpoints

On Thu, Feb 26, 2015 at 5:12 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: When a control transfer has a short data stage, the xHCI controller generates two transfer events: a COMP_SHORT_TX event that specifies the untransferred amount, and a COMP_SUCCESS event. But when the data stage

Re: [PATCH v3] xhci: fix reporting of 0-sized URBs in control endpoint

on the ep_ring-last_td_was_short flag, which is set to true when a COMP_SHORT_TX event is received. This fixes a bug which affected the HSO plugin, which relies on URBs with urb-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado

[PATCH v4] xhci: fix reporting of 0-sized URBs in control endpoint

the HSO plugin, which relies on URBs with urb-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- Hey Mathias, I have now updated the patch to avoid re-using the 'last_td_was_short' flag, and instead use a new

Re: [PATCH v2] xhci: fix reporting of 0-sized URBs in control endpoint

, which relies on URBs with urb-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/host/xhci-ring.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH v3] xhci: fix reporting of 0-sized URBs in control endpoint

with urb-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- Hey, This is the third update of the patch: * v2 modified the commit message to make it shorter and clearer. * v3 updated the format

Re: [PATCH v3] xhci: fix reporting of 0-sized URBs in control endpoint

On Mon, Feb 23, 2015 at 4:23 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Hi On 23.02.2015 13:52, Aleksander Morgado wrote: When a control transfer has a short data stage, the xHCI controller generates two transfer events: a COMP_SHORT_TX event that specifies the untransferred

[PATCH v2] xhci: fix reporting of 0-sized URBs in control endpoint

with urb-actual_length == 0 to halt re-submitting the RX URB in the control endpoint. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/host/xhci-ring.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

On Sat, Feb 21, 2015 at 4:34 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 21 Feb 2015, Aleksander Morgado wrote: Probably didn't explain well, sorry, likely mixing terms. What I mean is that when the data length received is equal to the transfer buffer length, we get a single IRQ

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

Hey Alan, On Sat, Feb 21, 2015 at 3:47 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 21 Feb 2015, Aleksander Morgado wrote: When the control TD doesn't have TRBs in the data stage, the URB actual length is set equal to the transfer buffer length. E.g. with a 64 byte transfer

[PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/host/xhci-ring.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 88da8d6..6b050f1 100644 --- a/drivers/usb/host/xhci-ring.c +++ b

Re: [PATCH] xhci: fix reporting of 0-sized URBs in control endpoint

On Sat, Feb 21, 2015 at 1:18 AM, Aleksander Morgado aleksan...@aleksander.es wrote: The current logic, though, doesn't seem to contemplate the case where a TD has a TDR in the data stage which actually reports 0 bytes (i.e. transfer event len equal to transfer buffer len). The logic

Re: cdc_mbim with Huawei E3372, nothing works

On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin hvtaifwkbgefb...@gmail.com wrote: I have this USB ID 12d1:157d, Sonera Opengate LTE. It says all is okay but no packets are moving. With the SIM card in Lumia I get 50/25 Mbit/s. linux 3.19, Fedora 21, usb-modeswitch-2.2.1, usb_modeswitch-data

Re: cdc_mbim with Huawei E3372, nothing works

On Tue, Feb 17, 2015 at 5:50 PM, Sami Farin hvtaifwkbgefb...@gmail.com wrote: On Tue, Feb 17, 2015 at 17:32:40 +0100, Aleksander Morgado wrote: On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin hvtaifwkbgefb...@gmail.com wrote: I have this USB ID 12d1:157d, Sonera Opengate LTE. It says all

[PATCH] hso: always read interface number from the current altsetting

Always read bInterfaceNumber from the current altsetting, not from the first one available in the altsetting array. This is coming from code review, not related to any specific bug. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/hso.c | 13 + 1 file

ehci vs xhci: zero-length packet received in control endpoint handled differently?

Hey, I've been trying to debug the issue I have with my Option Globetrotter modem, handled by the 'hso' driver. One thing the driver does is to re-submit the RX urb in the control endpoint if the urb-actual_length is 0: put_rxbuf_data_and_resubmit_ctrl_urb () { ... /* Re issue

[PATCH] hso: fix rx parsing logic when skb allocation fails

and re-initializing rx_buf_missing). So, just let the while loop continue so that in the next iteration the WAIT_SYNC state cleanly stops the loop. The WAIT_SYNC processing will be done just after that, only if the end of packet is flagged. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es

Option HSO tty returning NUL bytes read continuously in USB3 port

Hey, I'm trying to understand why this Option Globetrotter modem (net/usb/hso driver, 0af0:6971) ends up returning NUL bytes read continuously in the TTY when plugged in a USB3 port but not in a USB2 one. I'm testing this with a 3.18.6 kernel plus a self-compiled hso driver from net-next; but I

Re: Understanding what's going on when using a Huawei E173 USB 3G web-stick (UMTS/HSPA)

NetworkManager uses ModemManager for all WWAN control, NM only handles the configuration storage and IP addressing parts of the setup. ModemManager handles modem hardware detection, capability detection, WWAN registration and setup, signal strength reporting, network connection initiation,

Re: bugreport: huawei_cdc_ncm control device freezes for 3-5 minutes on connect with E3276 LTE modem

On Fri, Oct 3, 2014 at 10:01 AM, Erik Alapää erik.ala...@gmail.com wrote: Problem: When connecting to a Huawei E3276 LTE modem using 'AT+CGACT=1,1' in minicom over /dev/cdc-wdm1, the cdc-wdm device freezes for 3-5 minutes until accepting AT commands again. Keywords: huawei_cdc_ncm, LTE, AT

Re: [PATCH] USB: qcserial: add Netgear AirCard 341U PID

On Thu, May 29, 2014 at 10:20 AM, Johan Hovold jhov...@gmail.com wrote: From: Aleksander Morgado aleksan...@aleksander.es Add Netgear AirCard 341U PID. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es Link: http://marc.info/?l=linux-usbm=140130486111309w=2 Cc: sta

[PATCH usb,stable] usb: qcserial: add additional Sierra Wireless QMI devices

A set of new VID/PIDs retrieved from the out-of-tree GobiNet/GobiSerial Sierra Wireless drivers. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- Hey, This patch is for stable branches only, and should be applied after the following one: [PATCH usb,stable] usb: qcserial: add

[PATCH usb-next] usb: qcserial: add additional Sierra Wireless QMI devices

A set of new VID/PIDs retrieved from the out-of-tree GobiNet/GobiSerial Sierra Wireless drivers. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es Link: http://marc.info/?l=linux-usbm=140136310027293w=2 Cc: sta...@vger.kernel.org# backport in link above --- drivers/usb/serial

[PATCH] net: qmi_wwan: add additional Sierra Wireless QMI devices

A set of new VID/PIDs retrieved from the out-of-tree GobiNet/GobiSerial Sierra Wireless drivers. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- Hey, The patch should be applied after the following one: [PATCH] net: qmi_wwan: add Netgear AirCard 341U http://marc.info/?l=linux

[PATCH] net: qmi_wwan: interface #11 in Sierra Wireless MC73xx is not QMI

This interface is unusable, as the cdc-wdm character device doesn't reply to any QMI command. Also, the out-of-tree Sierra Wireless GobiNet driver fully skips it. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/qmi_wwan.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH v3 4/5] usb: qcserial: define and use Sierra Wireless layout

On Sun, Apr 27, 2014 at 4:47 PM, Bjørn Mork bm...@telenor.net wrote: From: Bjørn Mork bj...@mork.no All the non Gobi Qualcomm based devices handled by this driver share a common standard Sierra Wireless specific layout. Adding code specifically for this layout allow us to reduce the number

Re: [PATCH v3 4/5] usb: qcserial: define and use Sierra Wireless layout

On Wed, May 28, 2014 at 2:54 PM, Bjørn Mork bj...@mork.no wrote: Aleksander Morgado aleksan...@aleksander.es writes: On Sun, Apr 27, 2014 at 4:47 PM, Bjørn Mork bm...@telenor.net wrote: From: Bjørn Mork bj...@mork.no All the non Gobi Qualcomm based devices handled by this driver share

[PATCH] net: qmi_wwan: add Netgear AirCard 341U

Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 83208d4..c0b611f 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c

[PATCH usb-next] usb: qcserial: add Netgear AirCard 341U

Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/serial/qcserial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index ca7b430..9c8b6ee 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial

[PATCH usb,stable] usb: qcserial: add Netgear AirCard 341U

Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/serial/qcserial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 6c0a542..781e4db 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb

[PATCH] net: qmi_wwan: add support for Cinterion PXS8 and PHS8

McCullough david.mccullo...@accelecon.com Signed-off-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index ff5c871..1eddd43 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b

[PATCH] USB: serial: option: blacklist interface 4 for Cinterion PHS8 and PXS8

-by: Aleksander Morgado aleksan...@aleksander.es --- drivers/usb/serial/option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5c86f57..604948b 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c

[PATCH] net: qmi_wwan: fix Cinterion PLXX product ID

-christoph.schem...@gemalto.com CC: Christian Schmiedl christian.schmi...@gemalto.com CC: Nicolaus Colberg nicolaus.colb...@gemalto.com Signed-off-by: Aleksander Morgado aleksan...@lanedo.com --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb

Re: [PATCH] cdc-acm: implement TIOCSSERIAL to avoid blocking close(2)

d...@redhat.com Cc: sta...@vger.kernel.org Works pretty well for me. Tested-by: Aleksander Morgado aleksan...@gnu.org --- drivers/usb/class/cdc-acm.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class

[PATCH] net: qmi_wwan: new device: Foxconn/Novatel E396

Foxconn-branded Novatel E396, Gobi3k modem. Cc: Dan Williams d...@redhat.com Cc: Bjørn Mork bj...@mork.no Cc: Ben Chan benc...@google.com Signed-off-by: Aleksander Morgado aleksan...@lanedo.com --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb