[PATCH RESEND] usb: gadget: f_mass_storage: Fix the logic to iterate all common->luns

2017-07-06 Thread Axel Lin
It is wrong to do --i in the for loop. Fixes: dd02ea5a3305 ("usb: gadget: mass_storage: Use static array for luns") Signed-off-by: Axel Lin <axel@ingics.com> Reviewed-by: Krzysztof Opasiak <k.opas...@samsung.com> Acked-by: Michal Nazarewicz <min...@mina86.com> ---

[PATCH] usb: gadget: f_mass_storage: Fix the logic to iterate all common->luns

2017-06-09 Thread Axel Lin
It is wrong to do --i in the for loop. Fixes: dd02ea5a3305 ("usb: gadget: mass_storage: Use static array for luns") Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/usb/gadget/function/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Axel Lin
2015-07-15 16:29 GMT+08:00 Uwe Kleine-König u.kleine-koe...@pengutronix.de: Hello, On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote: Hi, On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote: 2015-06-20 15:39 GMT+08:00 Axel Lin axel@ingics.com: Also simplify

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

2015-07-15 Thread Axel Lin
2015-06-05 8:27 GMT+08:00 Axel Lin axel@ingics.com: The ops is never changed in ulpi_phy_create(), so make it const. Hi Kishon, Would you pick up this patch? Without this patch, passing a const struct phy_ops* to ulip_phy_create will have compiler warning. It should be fine to pass a const

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Axel Lin
2015-06-20 15:39 GMT+08:00 Axel Lin axel@ingics.com: Also simplify the code a bit by specify direction and initial value for output in devm_gpiod_get_optional function. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Heikki Krogerus heikki.kroge...@linux.intel.com Acked-by: Kishon

[PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-06-20 Thread Axel Lin
Also simplify the code a bit by specify direction and initial value for output in devm_gpiod_get_optional function. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Heikki Krogerus heikki.kroge...@linux.intel.com Acked-by: Kishon Vijay Abraham I kis...@ti.com --- Hi This patch was sent

[PATCH] phy: ulpi_phy: Add const qualifier to ops

2015-06-04 Thread Axel Lin
The ops is never changed in ulpi_phy_create(), so make it const. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/ulpi_phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h index ac49fb6..f2ebe49 100644 --- a/drivers

[PATCH v2] usb: phy: Find the right match in devm_usb_phy_match

2015-03-11 Thread Axel Lin
with the phy) Signed-off-by: Axel Lin axel@ingics.com Cc: sta...@vger.kernel.org # v3.6+ --- v2: Add Fixes and Cc stable tags drivers/usb/phy/phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 2f9735b..d1cd6b5 100644

[PATCH] usb: phy: Find the right match in devm_usb_phy_match

2015-03-10 Thread Axel Lin
The res parameter passed to devm_usb_phy_match() is the location where the pointer to the usb_phy is stored, hence it needs to be dereferenced before comparing to the match data in order to find the correct match. Signed-off-by: Axel Lin axel@ingics.com --- drivers/usb/phy/phy.c | 4 +++- 1

[PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name

2015-03-10 Thread Axel Lin
Current code does not call clk_prepare(phy-optclk) when using the old usb_otg_ss_refclk960m name. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-omap-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy

[PATCH] phy: twl4030-usb: Remove redundant assignment for twl-linkstat

2015-03-09 Thread Axel Lin
It's pointless to set twl-linkstat twice. Signed-off-by: Axel Lin axel@ingics.com --- Resend with linux-usb in Cc. drivers/phy/phy-twl4030-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c index 8e87f54..bc42d6a 100644