Re: [RFC RESEND 00/10] Create separate header for ehci-dbgp driver

2014-11-04 Thread Daniele Forsi
2014-11-03 4:07 GMT+01:00 Chris Rorvick: fusbh200: Make Xen notificaiton consistent with EHCI fotg210: Make Xen notificaiton consistent with EHCI you may want to fix the spelling: s/notificaiton/notification/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 5/5] phy: exynos5-usbdrd: Adding Kconfig dependency for Exynos7

2014-08-28 Thread Daniele Forsi
SoC series USB DRD PHY driver - depends on ARCH_EXYNOS5 OF + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) OF shouldn't that prompt and its help text be updated to mention also Exynos7? -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Daniele Forsi
(fw_header-fw_start); + if (start fw-size) + goto out; since start is an offset in an array of size fw-size this should check for = and if a command is at least cmd(2 bytes) + length(2 bytes), shouldn't this check for start = fw-size - 4? -- Daniele Forsi -- To unsubscribe from

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-20 Thread Daniele Forsi
|= gpio_value_mask[offset]; else gpio-index = ~gpio_value_mask[offset]; do you find it less readable or less efficient? -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-04 Thread Daniele Forsi
with a full stop, three lines without; colons the last lines do not align to the first three -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-04 Thread Daniele Forsi
(i.e. STiH407). + Say 'Y' or 'M' here if you have one such device comment Debugging features you are actually removing the line Say 'Y' or 'M' here if you have one such device from the previous item -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2] Add support for GPIOs for SMSC LAN95xx chips.

2014-06-25 Thread Daniele Forsi
function) -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] leds: USB: Add support for MSI GT683R led panels

2014-06-05 Thread Daniele Forsi
2014-06-05 13:06 GMT+02:00: + dev_err(led-usb_dev-dev, Message to be send to device is too long\n); there's a typo: s/send/sent/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [Patch V3 2/2] usbtest: Add interrupt EP testcases

2014-05-23 Thread Daniele Forsi
is like this? case USB_ENDPOINT_XFER_BULK: set in or out; break; case USB_ENDPOINT_XFER_INT: set int_in or int_out; break; case USB_ENDPOINT_XFER_ISOC: set iso_in or iso_out; break; default: do nothing; it would be easier to follow even if it adds and indentation level -- Daniele Forsi

[RFC] usb: storage: shuttle_usbat: fix discs being detected twice

2014-04-29 Thread Daniele Forsi
Even if the USB-to-ATAPI converter supported multiple LUNs, this driver would always detect the same physical device or media because it doesn't use srb-device-lun in any way. Tested with an Hewlett-Packard CD-Writer Plus 8200e. Signed-off-by: Daniele Forsi dfo...@gmail.com --- drivers/usb

Re: [PATCH] USB: serial: ftdi_sio: add id for Brainboxes VX-001 ExpressCard

2014-03-25 Thread Daniele Forsi
2014-03-25 20:00 GMT+01:00 Michele Baldessari: Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in + * Product: ExpressCard 1 Port RS2323 there is a stray trailing 3 -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH 2/2] added fputs() fgets() error handling

2013-11-04 Thread Daniele Forsi
(fp); } -- -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: choice =y selection becomes lost after having multiple entries =m with depends on

2013-10-30 Thread Daniele Forsi
2013/10/30 Dirk Gouders: Those values are also written to the config file causing modules when they should not. this sentence of the commit message is missing something, I think you mean: s/causing modules/causing modules to be built/ -- Daniele Forsi -- To unsubscribe from this list: send

Re: [PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Daniele Forsi
2013/9/19 Peter Chen: + milliseconds to increase successive wakup delays); there's a typo: s/wakup/wakeup/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH]fsl/usb: Workarourd for USB erratum-A005697

2013-09-19 Thread Daniele Forsi
2013/9/19 Ramneek Mehresh: + * we need to wait for 10ms for bus to fo into suspend mode after there's a typo: s/fo/go/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-26 Thread Daniele Forsi
2013/7/26 Greg Kroah-Hartman: + Say Y here if you want to usb the Suunto ANT+ USB device. I think there might be a thinko: s/to usb/to use/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/4] proc_usb_info.txt: Correct documentation about endianness of config descriptors

2013-05-30 Thread Daniele Forsi
2013/5/30 Hans de Goede: +are wTotalLength bytes apart. If a device returns less configuration +descriptor data then indicated by wTotalLength there will be a hole in s/then/than/ -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH 4/4] Documentation sysfs-bus-usb: Document all files used by libusb

2013-05-30 Thread Daniele Forsi
2013/5/30 Hans de Goede: + be trusted, as the device may have a smaller config descriptor + then it advertises. The bLength field of each (sub) descriptor as in the other text: s/then/than/ -- Daniele Forsi -- To unsubscribe from this list: send the line

Re: Testing phonet

2013-05-01 Thread Daniele Forsi
it should be possible to do both parts on the same machine, that would test only the phonet module and not cdc_phonet (Each socket [...] can send and receive packets with any other peer). -- Daniele Forsi /* G N O K I I A Linux/Unix toolset and driver for the mobile phones. This file

Re: Testing phonet

2013-04-30 Thread Daniele Forsi
Hello Andrzej, I removed people from CC On Monday, April 29, 2013 6:30 PM Daniele Forsi wrote: I can provide the OP with frames captured from a real phone when talking with gnokii You mean some kind of dump? What can it be useful for? Comparing the messages sequence

Re: Testing phonet

2013-04-29 Thread Daniele Forsi
the OP with frames captured from a real phone when talking with gnokii -- Daniele Forsi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html