Re: [PATCH 00/16] remove eight obsolete architectures

Do we have anything left that still implements NOMMU? David -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

Andy Lutomirski wrote: > David, are these encrypted keys ever exported anywhere? If not, could > the code use a mode that doesn't need padding? ecryptfs uses them, I think. David -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

Andy Lutomirski wrote: > > - sg_set_buf(_out[1], pad, sizeof pad); > > + sg_set_buf(_out[1], empty_zero_page, 16); > > My fix here is obviously bogus (I meant to use ZERO_PAGE(0)), but what > exactly is the code trying to do? The old code makes no sense. It's

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

Andy Lutomirski wrote: > I don't know whether you're right, but that sounds a bit silly to me. > This is a *tiny* amount of memory. Assuming a 1MiB kernel image in 4K pages, that gets you back a couple of pages I think - useful if you've only got a few MiB of RAM. David --

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

Andy Lutomirski wrote: > After all, rodata is ordinary memory, is backed by struct page, etc. Is that actually true? I thought some arches excluded the kernel image from the page struct array to make the array consume less memory. David -- To unsubscribe from this list:

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

Andy Lutomirski wrote: > +static const char zero_pad[16] = {0}; Isn't there a global page of zeros or something that we can share? Also, you shouldn't explicitly initialise it so that it stays in .bss. > - sg_set_buf(_out[1], pad, sizeof pad); > + sg_set_buf(_out[1],

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

Andrzej Hajda wrote: > Semantic patch finds comparisons of types: > unsigned < 0 > unsigned >= 0 > The former is always false, the latter is always true. > Such comparisons are useless, so theoretically they could be > safely removed, but their presence quite often

[PATCH 09/26] goku_udc: Don't use create_proc_read_entry() [RFC]

Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells dhowe...@redhat.com cc: Felipe Balbi ba...@ti.com cc: Greg Kroah-Hartman gre...@linuxfoundation.org cc: linux-usb@vger.kernel.org --- drivers/usb/gadget

[PATCH 10/26] fsl_udc: Don't use create_proc_read_entry() [RFC]

Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells dhowe...@redhat.com cc: Li Yang le...@freescale.com cc: Felipe Balbi ba...@ti.com cc: Greg Kroah-Hartman gre...@linuxfoundation.org cc: linux-usb

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

Sarah Sharp sarah.a.sh...@linux.intel.com wrote: I guess my question is a deeper one: do we need to rename all the xHCI macros to have the XHCI_ prefix, in order to avoid future collision? For example, one of the macros is MAX_HC_PORTS, which could possibly be used by other host drivers in

[PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h. Signed-off-by: David Howells dhowe...@redhat.com cc: Sarah Sharp sarah.a.sh...@linux.intel.com cc: Greg Kroah-Hartman gre...@linuxfoundation.org cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 16

[PATCH 1/2] xhci: Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT

Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT as ilog2() can be worked out at compile time, whereas __ffs() must be calculated at runtime. Signed-off-by: David Howells dhowe...@redhat.com cc: Sarah Sharp sarah.a.sh...@linux.intel.com cc: Greg Kroah-Hartman gre

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

Sarah Sharp sarah.a.sh...@linux.intel.com wrote: I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI driver is built in? Or is there some other point I'm missing? Sorry, I

[GIT PULL] Disintegrate UAPI for usb

) UAPI Disintegration 2012-10-09 David Howells (1): UAPI: (Scripted) Disintegrate include/linux/usb include/linux/usb/Kbuild | 10 - include/linux/usb/audio.h| 524

Re: [GIT PULL] Disintegrate UAPI for usb

Greg KH gre...@linuxfoundation.org wrote: Can you merge the following branch into the usb tree please. Is this (and the other pull requests for other subsystems) for 3.7 or for 3.8? I don't really mind. There are no dependencies on it. Getting it in 3.7 means there's more chance it'll