[PATCH 9/9] usb: dwc2: gadget: Add handler for WkupAlert interrupt

Added interrupt handler for WkupAlert interrupt. This interrupt should initiate Remote Wake up. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c

[PATCH 8/9] usb: dwc2: gadget: enable WKUP_ALERT interrupt

with the host frame number. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 66401ffeb5a2..4f99f2e44a5b 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c

[PATCH 7/9] usb: dwc2: gadget: Program GREFCLK register

Added dwc2_gadget_program_ref_clk function to program GREFCLK register in device mode. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 23 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/usb/dwc2/core.h b/drivers

[PATCH 6/9] usb: dwc2: gadget: Add parameters for GREFCLK register

Added ref_clk_per and sof_cnt_wkup_alert parameters in dwc2_core_params struct and set default values. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.h | 18 ++ drivers/usb/dwc2/params.c | 2 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/usb/dwc2

[PATCH 4/9] usb: dwc2: Update target (u)frame calculation

In service interval based scheduling target (u)frame must be set as a last frame in this the service interval. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2

[PATCH 5/9] usb: dwc2: Add definitions for new registers

New registers were added to dwc otg core. GREFCLK - This register used to control ref_clk parameters. GINTSTS2 - New WKUP_ALERT interrupt was added. GINTMSK2 - Mask register for GINTSTS2. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/hw.h | 13 + 1 file changed, 13

[PATCH 3/9] usb: dwc2: Add dwc2_gadget_dec_frame_num_by_one() function

Added dwc2_gadget_dec_frame_num_by_one() function in gadget.c. This function will be used to calculate descriptor frame number field value. For service interval mode frame number in descriptor should point to last (u)frame in the interval. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2

[PATCH 2/9] usb: dwc2: Add core parameter for service interval support

Added core parameter for service interval based scheduling. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.h| 9 + drivers/usb/dwc2/debugfs.c | 1 + drivers/usb/dwc2/gadget.c | 4 drivers/usb/dwc2/params.c | 4 4 files changed, 18 insertions(+) diff --git

[PATCH 1/9] usb: dwc2: Update registers definitions to support service interval

Added GHWCFG4_SERVICE_INTERVAL_SUPPORTED and DCTL_SERVICE_INTERVAL_SUPPORTED bits definitions to support service interval based scheduling. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/hw.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2

[PATCH 0/9] usb: dwc2: device: Add service interval support

. Because of some inaccuracies of reference clock new interrupt was added to initiate remote wake up and keep sync with the host frame number. The new interrupt register were added GINTSTS2 for that interrupt. Grigor Tovmasyan (9): usb: dwc2: Update registers definitions to support service

Re: Possible race condition in f_mass_storage gadget during deinitialization. Kernel warning issued

Hi On 8/20/2018 15:20, Felipe Balbi wrote: > > Hi, > > Adrian Ambrożewicz writes: >> Hello, >> >> I'm consistently observing kernel warnings related to Mass Storage USB >> Gadget de-initialization flow. After investigation I believe that I've >> found root cause of these warnings, however I'm

Re: [PATCH v2 3/3] usb: dwc2: Make dwc2_readl/writel functions endianness-agnostic.

Hi Felipe, On 7/27/2018 12:26, Gevorg Sahakyan wrote: > Declared dwc2_check_core_endianness() function for dynamicly check > core endianness. > Added needs_byte_swap flag to hsotg structure, and depending on > flag swap value inside dwc2_readl/writel functions. > > Signed-off-by: Gevorg Sahakyan

Re: [PATCH v2 2/4] usb: dwc2: Modify dwc2_readl/writel functions prototype

On 7/26/2018 16:10, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan writes: >>>> Added hsotg argument to dwc2_readl/writel function prototype, >>>> and also instead of address pass offset of register. >>>> hsotg will contain flag field for en

Re: [PATCH v2 2/4] usb: dwc2: Modify dwc2_readl/writel functions prototype

Hi Felipe, On 7/26/2018 14:43, Felipe Balbi wrote: > Gevorg Sahakyan writes: > >> Added hsotg argument to dwc2_readl/writel function prototype, >> and also instead of address pass offset of register. >> hsotg will contain flag field for endianness. >> >> Also customized dwc2_set_bit and

Re: [PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

Hi Stefan, Marek Please test this patch and tell if it will cause any problem. Thanks, Grigor On 5/24/2018 6:22 PM, Grigor Tovmasyan wrote: > Freed allocated request for ep0 to prevent memory leak in case when > dwc2_driver_probe() failed. > > Signed-off-by: Grigor Tovm

[PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

Freed allocated request for ep0 to prevent memory leak in case when dwc2_driver_probe() failed. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> Cc: Stefan Wahren <stefan.wah...@i2se.com> Cc: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/usb/dwc2/gadget.c |

Re: usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

_add_gadget_udc() call. The issue happens if DWC2 > driver is initialized from deferred probe (in such case the gadget driver > is already registered). > > Felipe: please drop or revert this patch in your -next branch. > > > Best regards > Marek Szyprowski, PhD >

Re: [PATCH v3] usb: dwc2: Fix kernel doc's warnings.

Hi Felipe, I rebase this patch to your current testing/next (3196f73ff844) BR, Grigor. On 5/16/2018 12:04 PM, Grigor Tovmasyan wrote: > Added descriptions for all not described parameters. > Fix all kernel doc's warnings. > > Signed-off-by: Grigor Tovmasyan <tovma.

[PATCH v3] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 7 ++ drivers/usb/dwc2/core.h | 170 ++- drivers/usb/dwc2/d

Re: dwc2 device testing with Service Interval plus LPM

On 5/11/2018 2:42 PM, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> Hi all, >> >> I want to test a new feature of HSOTG core: Service Interval + LPM support >> in device mode. >> What I need to

dwc2 device testing with Service Interval plus LPM

Hi all, I want to test a new feature of HSOTG core: Service Interval + LPM support in device mode. What I need to use from host side to be able generate appropriate ISOC IN traffic? Thanks, Grigor. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

[PATCH] usb: dwc2: Add Interpacket Gap(IPG) feature support

Added GHWCFG4_IPG_ISOC_SUPPORTED and DCFG_IPG_ISOC_SUPPORDED bits definitions to enable/disable IPG feature. Added ipg_isoc_en core parameter which will indicate IPG support enable/disable and initialize it. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

Hi Simon, On 4/21/2018 4:52 PM, Simon Shields wrote: > Hi Grigor, > > On Fri, Apr 20, 2018 at 01:00:16PM +0000, Grigor Tovmasyan wrote: >> Hi Simon, >> >> On 4/19/2018 8:31 PM, Simon Shields wrote: >>> Hi all, >>> >>> On 10/04/2018 10:21 PM,

Re: [PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

Hi Stefan, On 4/18/2018 1:11 AM, Stefan Wahren wrote: > Hi Grigor, > >> Grigor Tovmasyan <grigor.tovmas...@synopsys.com> hat am 16. April 2018 um >> 12:16 geschrieben: >> >> >> In dwc2_gadget_init() we allocate EP0 request v

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

Hi Balbi, On 4/10/2018 2:21 PM, Grigor Tovmasyan wrote: > Here are two little fixes for LPM feature. > > First one is coverity warning fix. > > The Second one was asserted by Stefan Wahren. > > Changes from version 0: > > 1/2: > - Instead of converting para

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

Hi Simon, On 4/19/2018 8:31 PM, Simon Shields wrote: > Hi all, > > On 10/04/2018 10:21 PM, Grigor Tovmasyan wrote: >> Here are two little fixes for LPM feature. >> >> First one is coverity warning fix. >> >> The Second one was asserted by Stefan Wahren.

[PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

dwc2_hsotg_ep_alloc_request(). Tested using kmemleak. Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/driv

[PATCH v1 2/2] usb: dwc2: gadget: Change LPM default values

Changed default values of LPM parameters to avoid "dwc2_check_params: Invalid parameter" warnings when hardware did not support LPM feature. Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/params.

[PATCH v1 1/2] usb: dwc2: gadget: Fix coverity issue

When _param is unsigned and the minimum value of range is 0, CHECK_RANGE macro gives the following warning: COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value is never true. So I changed the type of hird_threshold from u8 to int to avoid that warning. Signed-off-by: Grigor

[PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Changes from version 0: 1/2: - Instead of converting parameter in the CHECK_RANGE macro to int, changed hird_threshold type from u8 to int. Grigor Tovmasyan

Re: dwc2: Memory leak in dwc2_gadget_init

Hi Stefan, On 4/2/2018 12:59 PM, Stefan Wahren wrote: > Hi Minas, > > i noticed that in opposite to all allocations in dwc2_gadget_init() the > function dwc2_hsotg_ep_alloc_request() uses kzalloc. So in case > usb_add_gadget_udc() would fail, the memory of the USB request would be > leaked: >

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

On 4/5/2018 12:11 PM, Tomeu Vizoso wrote: > Hi Minas, > > On 04/05/2018 09:54 AM, Minas Harutyunyan wrote: >> Hi Tomeu, >> >> On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: >>> devm_regulator_get_optional returns -ENODEV if the regulator isn't >>> there, so if that's the case we have to make sure not

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

> > return regulator_enable(hsotg->vbus_supply); > } > @@ -4342,9 +4347,7 @@ static int _dwc2_hcd_start(struct usb_hcd *hcd) > > spin_unlock_irqrestore(>lock, flags); > > - dwc2_vbus_supply_init(hsotg); > - > - return 0; > +

Re: [PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

He Stefan On 4/3/2018 8:09 PM, Stefan Wahren wrote: > Hi Grigor, > > Am 03.04.2018 um 13:21 schrieb Grigor Tovmasyan: >> Here are two little fixes for LPM feature. >> >> First one is coverity warning fix. >> >> The Second one was asserted by Stefan Wahren.

Re: [PATCH v1] usb: dwc2: Fix kernel doc's warnings.

On 4/3/2018 5:10 PM, Grigor Tovmasyan wrote: > On 4/3/2018 4:41 PM, Greg Kroah-Hartman wrote: >> On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: >>> Added descriptions for all not described parameters. >>> Fix all kernel doc's warnings. >>>

[PATCH v2] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- Changes from version 1: Fix minor kernel-doc style issue. Changes from version 0: Rebased to balbi/next. Fixed new kernel-doc warnings which

Re: [PATCH v1] usb: dwc2: Fix kernel doc's warnings.

On 4/3/2018 4:41 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: >> Added descriptions for all not described parameters. >> Fix all kernel doc's warnings. >> >> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.

[PATCH v1] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- Changes from version 0: Rebased to balbi/next. Fixed new kernel-doc warnings which cames from new patches. --- drivers/usb/dwc2/core.c

[PATCH 2/2] usb: dwc2: gadget: Change default values

Change default values of LPM parameters to avoid "dwc2_check_params: Invalid parameter" warnings when harwere did not support LPM feature. Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/params.c | 8 ++

[PATCH 1/2] usb: dwc2: gadget: Fix coverity issue

When _param is unsigned and the minimum value of range is 0, it gives the following warning: COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value is never true. Converting ._param to int to avoid this warning. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.

[PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Grigor Tovmasyan (2): usb: dwc2: gadget: Fix coverity issue usb: dwc2: gadget: Change default values drivers/usb/dwc2/params.c | 10 +- 1 file changed, 5

Re: dwc2: Confusing warnings in next-20180327 on Raspberry Pi

Hi Stefan, On 4/2/2018 7:47 PM, Stefan Wahren wrote: > Hi Minas, > > in linux-next-20180327 i will get the following confusing warnings on the > Raspberry Pi: > > Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31 > 13:24:47 CEST 2018 armv6l GNU/Linux > > [6.809185]

Re: [PATCH -next] usb: dwc2: pci: Fix error return code in dwc2_pci_probe()

n <weiyongj...@huawei.com> Reviewed-by: Grigor Tovmasyan <tovma...@synopsys.com> > --- > drivers/usb/dwc2/pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c > index 7f21747..bea2e8e 10

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

On 3/12/2018 5:34 PM, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: >> One more thing. >> >> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) >> Signed-off is missing. >> &g

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Balbi wrote: > > (no top-posting!!) > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: >> Hi, >> >> Yes. I'm verifying, it's okay. >> >> Sorry for inconvenience. > > thank you. I'll move the changes to 'next'. > -- To unsubsc

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Hi, Yes. I'm verifying, it's okay. Sorry for inconvenience. Thanks, Grigor. On 3/12/2018 4:47 PM, Felipe Balbi wrote: > > (please avoid top-posting) > > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: >> Hi Balbi, >> >> Please a

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Hi Balbi, Please also cherry-pick following commit from your 'testing/next' to 'tmp' right before 01/14. It will solve the problem. 969d58abe57d usb: dwc2: Enable LPM On 3/12/2018 4:03 PM, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> w

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

ch> pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place On 3/12/2018 2:22 PM, Felipe Balbi wrote: > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> Hi Balbi, >> >> This patch didn't apply, because you missing 01/14 and 02/14 com

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

/2018 5:10 PM, Grigor Tovmasyan wrote: > Hi Balbi, > > Seems like your testing/next was changed. > I will rebese and send them again. > > On 3/9/2018 1:07 PM, Felipe Balbi wrote: >> Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: >> >>>

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Hi Balbi, Seems like your testing/next was changed. I will rebese and send them again. On 3/9/2018 1:07 PM, Felipe Balbi wrote: > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> From: Vardan Mikayelyan <mvar...@synopsys.com> >> >> These are

Re: [PATCH 11/11] usb: dwc2: Enable LPM

Hi John, Could you please add your Signed-off to this patch? On 3/9/2018 12:06 PM, Felipe Balbi wrote: > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: >> From: John Youn <johny...@synopsys.com> >> >> Set 'lpm_capable' flag in the gad

Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

Hi Balbi, I saw you applied "e9c07984979d usb: dwc2: Force mode optimizations" patch to your testing/next. Please re-apply this commit. On 2/15/2018 6:37 PM, Grigor Tovmasyan wrote: > Hi Balbi > > On 2/15/2018 17:34, Felipe Balbi wrote: >> Hi, >> >> kbui

[PATCH v1 14/14] usb: dwc2: Enable power down

From: John Youn <johny...@synopsys.com> Enable the power down option based on the core capability. Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by:

[PATCH v1 13/14] usb: dwc2: Change hub-control to allow hibernation

From: Vardan Mikayelyan <mvar...@synopsys.com> Affected cases: ClearPortFeature's USB_PORT_FEAT_SUSPEND SetPortFeature's USB_PORT_FEAT_SUSPEND USB_PORT_FEAT_RESET Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Sig

[PATCH v1 12/14] usb: dwc2: Add dwc2_handle_gpwrdn_intr() handler

gned-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 3 ++ drivers/usb/dwc2/core_intr.c | 117 +++

[PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

From: Vardan Mikayelyan <mvar...@synopsys.com> These are wrapper functions which are calling device or host enter/exit hibernation functions. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigo

[PATCH v1 11/14] usb: dwc2: Allow entering hibernation from USB_SUSPEND interrupt

Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 52 +++- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_i

[PATCH v1 08/14] usb: dwc2: Add helper functions for restore routine

off-by: John Youn <johny...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 136 +

[PATCH v1 09/14] usb: dwc2: Add host/device hibernation functions

t;art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 18 drivers/usb/dwc2/gadget.c | 176 +

[PATCH v1 06/14] usb: dwc2: gadget: Add remote_wakeup_allowed flag

rovide interface for bringing remote wake-up signalling. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 3 +++ drivers/usb/dwc2/gad

[PATCH v1 07/14] usb: dwc2: Changes in registers backup/restore functions

ctions: dwc2_backup_host_registers() dwc2_restore_host_registers() dwc2_backup_global_registers() dwc2_restore_global_registers() Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com&g

[PATCH v1 05/14] usb: dwc2: core: Add hibernated flag

From: Vardan Mikayelyan <mvar...@synopsys.com> Added a flag to indicate that core is in hibernation, it is used to determine the hibernation state of the core. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by

[PATCH v1 04/14] usb: dwc2: gadget: Fix dwc2_restore_device_registers

d area. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.

[PATCH v1 03/14] usb: dwc2: gadget: Moved dtxfsiz backup array place

From: Vardan Mikayelyan <mvar...@synopsys.com> Moved dtxfsiz from dwc2_gregs_backup to dwc2_dregs_backup, because it is device register. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <

[PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params

Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 12 ++-- drivers/usb/dwc2/hcd.c| 4 ++-- d

[PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down

_hibernation() to dwc2_set_param_power_down(). Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 14 +++--- drivers/usb/dwc2/core.h | 12 ++--

[PATCH v1 00/14] usb: dwc2: Add hibernation support

This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a fourth and last part. In this series we included

[PATCH 6/6] usb: dwc2: Force mode optimizations

f-by: John Youn <johny...@synopsys.com> Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 61 +++-- drivers/usb/dwc2/core.h | 4 +-- drivers/usb/dwc2

Re: [PATCH 6/6] usb: dwc2: Force mode optimizations

Hi Balbi, On 2/16/2018 11:09, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> Hi Balbi, >> >> I rebased this commit to your testing/next (see below). > > Are you sure you did? Yes. I che

Re: [PATCH 5/6] usb: dwc2: eliminate irq parameter from dwc2_gadget_init

On 2/15/2018 17:08, Felipe Balbi wrote: > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> From: Vardan Mikayelyan <mvar...@synopsys.com> >> >> The irq is available in hsotg already, so there's no need to pass it as >> separate funct

Re: [PATCH 6/6] usb: dwc2: Force mode optimizations

cements and new features " patch series. Please apply this rebased patch. Also, please, reapply "[PATCH 09/17] usb: dwc2: Make dwc2_force_mode() static" which was dropped because of having dependancy from this pacth. Thanks a lot. On 1/16/2018 16:05, Grigor Tovmasyan wrote: &

Re: [PATCH 01/14] usb: dwc2: Rename hibernation to partial_power_down

Hi Balbi On 2/15/2018 17:23, Felipe Balbi wrote: > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: > >> From: Vardan Mikayelyan <mvar...@synopsys.com> >> >> No-op change, only rename. >> >> This code was misnamed originally. I

Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

Hi Balbi On 2/15/2018 17:34, Felipe Balbi wrote: > > Hi, > > kbuild test robot writes: >> tree: >>

[PATCH] usb: dwc2: Fix interval type issue

The maximum value that unsigned char can hold is 255, meanwhile the maximum value of interval is 2^(bIntervalMax-1)=2^15. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/us

[PATCH] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 7 +++ drivers/usb/dwc2/core.h | 131 ++- drivers/usb/dwc2/debug.h | 2 +- drivers/us

[PATCH 14/14] usb: dwc2: Enable power down

From: John Youn <johny...@synopsys.com> Enable the power down option based on the core capability. Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by:

[PATCH 13/14] usb: dwc2: Change hub-control to allow hibernation

From: Vardan Mikayelyan <mvar...@synopsys.com> Affected cases: ClearPortFeature's USB_PORT_FEAT_SUSPEND SetPortFeature's USB_PORT_FEAT_SUSPEND USB_PORT_FEAT_RESET Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Sig

[PATCH 12/14] usb: dwc2: Add dwc2_handle_gpwrdn_intr() handler

gned-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 3 ++ drivers/usb/dwc2/core_intr.c | 117 +++

[PATCH 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

From: Vardan Mikayelyan <mvar...@synopsys.com> These are wrapper functions which are calling device or host enter/exit hibernation functions. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigo

[PATCH 11/14] usb: dwc2: Allow entering hibernation from USB_SUSPEND interrupt

Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 52 +++- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_i

[PATCH 09/14] usb: dwc2: Add host/device hibernation functions

t;art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 18 drivers/usb/dwc2/gadget.c | 176 +

[PATCH 08/14] usb: dwc2: Add helper functions for restore routine

off-by: John Youn <johny...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 136 +

[PATCH 07/14] usb: dwc2: Changes in registers backup/restore functions

ctions: dwc2_backup_host_registers() dwc2_restore_host_registers() dwc2_backup_global_registers() dwc2_restore_global_registers() Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com&g

[PATCH 05/14] usb: dwc2: core: Add hibernated flag

From: Vardan Mikayelyan <mvar...@synopsys.com> Added a flag to indicate that core is in hibernation, it is used to determine the hibernation state of the core. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by

[PATCH 06/14] usb: dwc2: gadget: Add remote_wakeup_allowed flag

rovide interface for bringing remote wake-up signalling. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 3 +++ drivers/usb/dwc2/gad

[PATCH 03/14] usb: dwc2: gadget: Moved dtxfsiz backup array place

From: Vardan Mikayelyan <mvar...@synopsys.com> Moved dtxfsiz from dwc2_gregs_backup to dwc2_dregs_backup, because it is device register. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <

[PATCH 04/14] usb: dwc2: gadget: Fix dwc2_restore_device_registers

d area. Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Artur Petrosyan <art...@synopsys.com> Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.

[PATCH 01/14] usb: dwc2: Rename hibernation to partial_power_down

_hibernation() to dwc2_set_param_power_down(). Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 14 +++--- drivers/usb/dwc2/core.h | 12 ++--

[PATCH 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params

Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 12 ++-- drivers/usb/dwc2/hcd.c| 4 ++-- d

[PATCH 00/14] usb: dwc2: Add hibernation support

This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a fourth and last part. In this series we included

[PATCH 11/11] usb: dwc2: Enable LPM

From: John Youn <johny...@synopsys.com> Set 'lpm_capable' flag in the gadget structure so indicating that LPM is supported. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 4

[PATCH 10/11] usb: dwc2: Add core state checking

Added core state checking in dwc2_hsotg_ep_queue() function to make sure that application will submit requests only in L0 state. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 09/11] usb: dwc2: Add call_gadget() function call

Added call_gadget() function call when entering to L1 state to inform gadget that core is in L1 state. Did the same thing when exiting from L1 state to inform gadget that core is in L0 state. Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 6 +++

[PATCH 08/11] usb: dwc2: gadget: Configure the core to enable LPM

; Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/core_intr.c | 1 + drivers/usb/dwc2/gadget.c| 26 ++ 3 files changed, 29 insertions(+) diff --git a/drivers/usb/dwc2/core.h b/drivers/usb

[PATCH 07/11] usb: dwc2: Enable LPM Transaction Received interrupt

From: Sevak Arakelyan <sev...@synopsys.com> Enable "LPM Transaction Received" interrupt for receive an interrupt when host will send LPM token. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- driv

[PATCH 06/11] usb: dwc2: gadget: LPM interrupt handler

From: Sevak Arakelyan <sev...@synopsys.com> This interrupt indicates that an LPM transaction was received on the USB bus. After getting this interrupt we are going from L0 state to L1 state. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: Grigor Tovm

[PATCH 05/11] usb: dwc2: gadget: Add functionality to exit from LPM L1 state

From: Sevak Arakelyan <sev...@synopsys.com> Add a function which will be called if device is in L1 sleep state and Resume/Remote Wakeup Detected interrupt is asserted. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com>

[PATCH 04/11] usb: dwc2: Add core parameters for LPM support

m> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/usb/dwc2/core.h| 20 drivers/usb/dwc2/debugfs.c | 5 + drivers/usb/dwc2/params.c | 13 + 3 files changed, 38 insertions(+) diff --git a/drivers/usb/dwc2/core.h b/drivers/usb

[PATCH 03/11] usb: dwc2: Rename GLPMCFG... definitions

From: Sevak Arakelyan <sev...@synopsys.com> Make field names of GLPMCFG register in definitions to be the same with the databook. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma...@synopsys.com> --- drivers/

[PATCH 02/11] usb: dwc2: Backup and restore PCGCCTL1 register

From: Razmik Karapetyan <raz...@synopsys.com> Backup PCGCCTL1 register when entering hibernation mode and restore it after exiting from hibernation, to keep active ACG feature. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> Signed-off-by: Grigor Tovmasyan <tovma.

  1   2   3   >