Re: [PATCH] configfs: switch ->default groups to a linked list

2016-03-05 Thread Joel Becker
Acked-by: Joel Becker <jl...@evilplan.org> On Fri, Feb 26, 2016 at 01:33:51PM +0100, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. &

Re: [PATCH 01/15] fs: configfs: Add unlocked version of configfs_depend_item()

2015-10-20 Thread Joel Becker
On Tue, Oct 20, 2015 at 02:32:32PM +0200, Andrzej Pietrasiewicz wrote: > From: Krzysztof Opasiak > > This change is necessary for the SCSI target usb gadget composed with > configfs. In this case configfs will be used for two different purposes: > to compose a usb gadget

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-11 Thread Joel Becker
On Mon, Dec 10, 2012 at 03:17:34PM +0100, Andrzej Pietrasiewicz wrote: @Joel in particular: please see my comment in the bottom. snip I forgot to mention, representing udcs (USB Device Controllers) in configfs is similar to interfaces/endpoints: the user needs to guess what name to use in

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-07 Thread Joel Becker
Hey Guys, Sorry I missed this for a while. I'll make a couple of inline comments, and then I'll summarize my (incomplete) thoughts at the bottom. On Wed, Nov 28, 2012 at 02:50:13PM +0100, Sebastian Andrzej Siewior wrote: On 11/28/2012 02:05 PM, Michal Nazarewicz wrote: On 11/27/2012

Re: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Joel Becker
On Fri, Aug 17, 2012 at 12:34:11PM +0200, Sebastian Andrzej Siewior wrote: On 08/17/2012 12:30 PM, Andrzej Pietrasiewicz wrote: There is a separation between setting myself up and seeing that a host wants to talk to me. You are a woman. And if you not done yet done you ignore the host until

Re: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Joel Becker
On Mon, Aug 20, 2012 at 10:53:42AM +0200, Andrzej Pietrasiewicz wrote: Hello Joel, Thanks for your reply. On Monday, August 20, 2012 8:00 AM Joel Becker wrote: I think what you want here is a symlink. Create a directory high in the tree called 'ready' or 'available', and when

Re: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Joel Becker
On Mon, Aug 20, 2012 at 01:01:03PM +0200, Sebastian Andrzej Siewior wrote: On 08/20/2012 07:59 AM, Joel Becker wrote: I think what you want here is a symlink. Create a directory high in the tree called 'ready' or 'available', and when you want to lock the device in place, symlink

Re: [RFC 0/2] USB gadget - configfs

2012-08-16 Thread Joel Becker
On Thu, Aug 16, 2012 at 03:47:15PM +0200, Sebastian Andrzej Siewior wrote: On 08/16/2012 03:17 PM, Andrzej Pietrasiewicz wrote: A lun is opened on storing the file attribute of the lun, it is in fsg_lun_store_file, storage_common.c. So, again, this is a configfs callback. On storing the

Re: [RFC 0/2] USB gadget - configfs

2012-08-15 Thread Joel Becker
On Tue, Jul 10, 2012 at 10:54:44AM +0200, Andrzej Pietrasiewicz wrote: Dear Joel, Thank you for your review. @Sebastian, Alan, Felipe: Thank you, too. On Monday, July 02, 2012 11:09 AM Joel Becker wrote: snip As a prerequisite it adds an operation to configfs. The operation