[PATCH V3 2/3] usb: xhci: tegra: Add runtime PM support

2018-05-16 Thread Jon Hunter
Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable the clocks, regulators and PHY into the runtime PM callbacks. Signed-off-by: Jon Hunter <jonath...@nvidia.com> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since V2: -

[PATCH V3 1/3] usb: xhci: tegra: Prepare for adding runtime PM support

2018-05-16 Thread Jon Hunter
to usb_create_hcd() before we enable the hardware. Signed-off-by: Jon Hunter <jonath...@nvidia.com> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since V2: - Add Thierry's ACK Changes since V1: - None drivers/usb/host/xhci-tegra.c | 34 +-

[PATCH V3 3/3] usb: xhci: tegra: Add support for managing powergates

2018-05-16 Thread Jon Hunter
PM domain provider and so these are only these are only needed in the case where there is no generic PM domain. Signed-off-by: Jon Hunter <jonath...@nvidia.com> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since V2: - Add Thierry's ACK Changes since V1: - None drivers/usb/

[PATCH V2 3/3] usb: xhci: tegra: Add support for managing powergates

2018-04-26 Thread Jon Hunter
PM domain provider and so these are only these are only needed in the case where there is no generic PM domain. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- Changes since V1: - None drivers/usb/host/xhci-tegra.c | 68 +++ 1 file changed, 49 i

[PATCH V2 2/3] usb: xhci: tegra: Add runtime PM support

2018-04-26 Thread Jon Hunter
Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable the clocks, regulators and PHY into the runtime PM callbacks. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- Changes since V1: - Re-worked change to handle case where runtime PM is di

[PATCH V2 1/3] usb: xhci: tegra: Prepare for adding runtime PM support

2018-04-26 Thread Jon Hunter
to usb_create_hcd() before we enable the hardware. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- Changes since V1: - None drivers/usb/host/xhci-tegra.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/usb/host/xhci-teg

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

2018-03-09 Thread Jon Hunter
On 09/03/18 09:13, Mathias Nyman wrote: > On 09.03.2018 10:36, Thierry Reding wrote: >> On Thu, Mar 08, 2018 at 09:31:07PM +0000, Jon Hunter wrote: >>> >>> On 01/03/18 14:18, Mathias Nyman wrote: >>>> On 14.02.2018 18:34, Jon Hunter wrote: >>>&g

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

2018-03-09 Thread Jon Hunter
On 09/03/18 08:36, Thierry Reding wrote: > On Thu, Mar 08, 2018 at 09:31:07PM +0000, Jon Hunter wrote: >> >> On 01/03/18 14:18, Mathias Nyman wrote: >>> On 14.02.2018 18:34, Jon Hunter wrote: >>>> Add runtime PM support to the Tegra XHCI driver and move the f

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

2018-03-08 Thread Jon Hunter
On 01/03/18 14:18, Mathias Nyman wrote: > On 14.02.2018 18:34, Jon Hunter wrote: >> Add runtime PM support to the Tegra XHCI driver and move the function >> calls to enable/disable the clocks, regulators and PHY into the runtime >> PM callbacks. >> >>

[PATCH 1/3] usb: xhci: tegra: Prepare for adding runtime PM support

2018-02-14 Thread Jon Hunter
to usb_create_hcd() before we enable the hardware. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- drivers/usb/host/xhci-tegra.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/hos

[PATCH 2/3] usb: xhci: tegra: Add runtime PM support

2018-02-14 Thread Jon Hunter
Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable the clocks, regulators and PHY into the runtime PM callbacks. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- drivers/usb/host/xhci-tegra.c | 80 ++-

[PATCH 3/3] usb: xhci: tegra: Add support for managing powergates

2018-02-14 Thread Jon Hunter
PM domain provider and so these are only these are only needed in the case where there is no generic PM domain. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- drivers/usb/host/xhci-tegra.c | 68 +++ 1 file changed, 49 insertions(+), 19 deletion

Re: [PATCH v6 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2018-02-13 Thread Jon Hunter
On 19/06/17 15:34, Philipp Zabel wrote: > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > Make use of of_reset_control_array_get_exclusive() to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter <jonath...@nvidia.com&

Re: [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-10-20 Thread Jon Hunter
an array of reset controllers available with the device. >> >> Cc: Jon Hunter <jonath...@nvidia.com> >> Cc: Thierry Reding <tred...@nvidia.com> >> Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> >> [p.za...@pengutronix.de: switch to hidden rese

Re: [PATCH V2] usb: phy: tegra: Fix phy suspend for UDC

2017-10-09 Thread Jon Hunter
Felipe, On 02/10/17 12:52, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Oct 02, 2017 at 12:22:53PM +0100, Jon Hunter wrote: >> Commit dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124") >> added UDC support for Tegra but with UD

[PATCH V2] usb: phy: tegra: Fix phy suspend for UDC

2017-10-02 Thread Jon Hunter
ort for Tegra20/30/114/124") Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- Changes since V1: - Added fixes tag - Added test in PHY enable to see if clock is already on before enabling drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file changed, 17 insertions(+) diff -

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
On 29/09/17 15:57, Dmitry Osipenko wrote: > On 29.09.2017 16:10, Jon Hunter wrote: >> Adding Dmitry ... >> >> Felipe, Thierry, this is needed for v4.14-rc because suspend is currently >> broken for some Tegra devices. >> >> Jon >> >> On 29/09/

Re: [PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
Adding Dmitry ... Felipe, Thierry, this is needed for v4.14-rc because suspend is currently broken for some Tegra devices. Jon On 29/09/17 14:06, Jon Hunter wrote: > Commit dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124") > added UDC support for Tegra but

[PATCH] usb: phy: tegra: Fix phy suspend for UDC

2017-09-29 Thread Jon Hunter
s are seen with Tegra20 because it has a slightly different PHY to Tegra30/114/124. Signed-off-by: Jon Hunter <jonath...@nvidia.com> --- drivers/usb/phy/phy-tegra-usb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c in

Re: [PATCH v6 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-09-06 Thread Jon Hunter
On 16/08/17 11:32, Dmitry Osipenko wrote: > From: Thierry Reding > > All of these Tegra SoC generations have a ChipIdea UDC IP block that can > be used for device mode communication with a host. Implement rudimentary > support that doesn't allow switching between host and

Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-05-31 Thread Jon Hunter
On 22/05/17 12:23, Vivek Gautam wrote: > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter <jonath...@nvidia.com> > Cc: Thierry Reding <tred...@nvidia.com> > Cc: Philipp Zabel <

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-25 Thread Jon Hunter
On 25/04/17 12:06, Vivek Gautam wrote: > On 04/25/2017 04:24 PM, Jon Hunter wrote: >> On 25/04/17 11:33, Philipp Zabel wrote: >>> On Tue, 2017-04-25 at 11:05 +0100, Jon Hunter wrote: >>>> On 25/04/17 05:15, Vivek Gautam wrote: >>>>> On 04/24/2017 06:1

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-25 Thread Jon Hunter
On 25/04/17 11:33, Philipp Zabel wrote: > On Tue, 2017-04-25 at 11:05 +0100, Jon Hunter wrote: >> On 25/04/17 05:15, Vivek Gautam wrote: >>> On 04/24/2017 06:15 PM, Jon Hunter wrote: >>>> On 18/04/17 12:21, Vivek Gautam wrote: >>>>> Make use of

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-25 Thread Jon Hunter
On 25/04/17 05:15, Vivek Gautam wrote: > On 04/24/2017 06:15 PM, Jon Hunter wrote: >> On 18/04/17 12:21, Vivek Gautam wrote: >>> Make use of reset_control_array_*() set of APIs to manage >>> an array of reset controllers available with the device. >> Before we

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-24 Thread Jon Hunter
On 18/04/17 12:21, Vivek Gautam wrote: > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. Before we apply this patch, I need to check to see if the order of the resets managed by the PMC driver matter. Today the order of the

Re: [PATCH v4 3/5] net: asix: Fix AX88772x resume failures

2016-11-30 Thread Jon Hunter
by: Allan Chou <al...@asix.com.tw> > Signed-off-by: Robert Foss <robert.f...@collabora.com> > Tested-by: Robert Foss <robert.f...@collabora.com> > Tested-by: Jon Hunter <jonath...@nvidia.com> > Tested-by: Allan Chou <al...@asix.com.tw> V3 of this patch is already

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-29 Thread Jon Hunter
gt;presvd_phy_advertise = > asix_mdio_read_nopm(dev->net, dev->mii.phy_id, > MII_ADVERTISE); > } I gave this a quick test this morning and I can confirm that with the above change I no longer see the error messages. So feel free to add my ... Tested-by: Jon Hunter &

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-22 Thread Jon Hunter
Hi Allan, On 18/11/16 15:09, Jon Hunter wrote: > Hi Allan, > > On 14/11/16 09:45, ASIX_Allan [Office] wrote: >> Hi Jon, >> >> Please help to double check if the USB host controller of your Terga >> platform had been powered OFF while running the ax88772_suspend

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-18 Thread Jon Hunter
Hi Allan, On 14/11/16 09:45, ASIX_Allan [Office] wrote: > Hi Jon, > > Please help to double check if the USB host controller of your Terga > platform had been powered OFF while running the ax88772_suspend() routine or > not? Sorry for the delay. Today I set up a local board to reproduce this

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-14 Thread Jon Hunter
Hi Allan, On 14/11/16 08:50, ASIX_Allan [Home] wrote: > It seems the AX88772x dongle had been unexpectedly removed while running the > ax88772_suspend() routine. If yes, you might see these error messages > because the hardware had been absent. In my case the hardware was never removed. The

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-10 Thread Jon Hunter
Hi Robert, On 29/08/16 14:32, robert.f...@collabora.com wrote: > From: Robert Foss > > From: Allan Chou > > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Jon Hunter
On 05/05/16 18:05, Jon Hunter wrote: [snip] > I spent a bit of time looking at this to figure out what it is doing. Can we > simply > this a bit as follows (limited testing so far) ... > > Cheers > Jon > > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/h

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Jon Hunter
On 04/05/16 15:40, Thierry Reding wrote: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be shared by multiple devices

Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-05 Thread Jon Hunter
dev_warn(>dev, > "can't get utmi-pads reset from the PHY\n"); > I have not seen any issues either, but may be we were getting lucky. The change makes sense to me. Acked-by: Jon Hunter <jonath...@nvidia.com> Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html