Re: [PATCH v2] Documentation: typec.rst: Use literal-block element with ascii art

On Wed, 25 Apr 2018 16:47:01 +0300 Jani Nikula wrote: > On Fri, 06 Apr 2018, Heikki Krogerus wrote: > > Using reStructuredText literal-block element with ascii-art. > > That prevents the ascii art from being processed as > >

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

Hi, On 25 March 2018 at 12:21, Jonathan Liu <net...@gmail.com> wrote: > On 8 February 2018 at 14:55, Jeffy Chen <jeffy.c...@rock-chips.com> wrote: >> From: AMAN DEEP <aman.d...@samsung.com> >> >> There is a race condition between finish_unlinks->finish_ur

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

Hi, On 25 March 2018 at 12:21, Jonathan Liu <net...@gmail.com> wrote: > Hi, > > On 8 February 2018 at 14:55, Jeffy Chen <jeffy.c...@rock-chips.com> wrote: >> From: AMAN DEEP <aman.d...@samsung.com> >> >> There is a race condition between finish_unlin

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

c) drivers/usb/core/devio.c:1835 [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x5c) fs/ioctl.c:47 [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x54) include/linux/file.h:39 Afterwards the kernel is unresponsive to disconnect/connect of the full speed USB device but I can connect/disconnect a high speed US

[PATCH] usb: chipidea: move extcon initial state read

Any extcon events between the initial state read and ci_extcon_register are "lost". This patch doesn't fix the issue entirely but reduces the chance of the controller entering a bad state. Signed-off-by: Jonathan Marek <jonat...@marek.ca> --- drivers/usb/chip

Re: [PATCH 1/1] usb: doc: Update document for USB3 debug port usage

On Wed, 13 Dec 2017 13:07:44 +0800 Lu Baolu wrote: > Update Documentation/driver-api/usb/usb3-debug-port.rst. This update > includes the guide for using xHCI debug capability based TTY serial > link. > > Cc: Mathias Nyman > Cc: Greg

Re: [PATCH] doc: usb: chipidea: Fix typo in 'enumerate'

On Fri, 8 Dec 2017 11:53:37 -0200 Fabio Estevam wrote: > Fix the spelling of 'enumerate' in this document. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 04/15] iio: make function argument and some structures const

config_item_type structures const as they are either passed to >the functions having the argument as const or they are >stored in the const "ci_type" field of a config_item structure. > >Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Jonathan Cameron <jonat

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

On 16 October 2017 at 23:49, Bin Liu <b-...@ti.com> wrote: > On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: >> On 10 October 2017 at 14:22, Bin Liu <b-...@ti.com> wrote: >> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> >&g

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

On 10 October 2017 at 14:22, Bin Liu <b-...@ti.com> wrote: > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the device is

[PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

el.org # v4.3+ Signed-off-by: Jonathan Liu <net...@gmail.com> --- Changes for v2: - Use devm_usb_put_phy instead of usb_put_phy drivers/usb/musb/sunxi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index c9a09b5bb6e5..dc353e2

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

Hi, On 10 October 2017 at 13:14, Bin Liu <b-...@ti.com> wrote: > On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote: >> Hi, >> >> On 10 October 2017 at 01:23, Bin Liu <b-...@ti.com> wrote: >> > Hi, >> > >> > On Tue, Sep 26, 20

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

Hi, On 10 October 2017 at 01:23, Bin Liu <b-...@ti.com> wrote: > Hi, > > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the dev

[PATCH] usb: musb: Check for host-mode using is_host_active() on reset interrupt

ided by the driver logic and does not rely on register contents. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/usb/musb/musb_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/m

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

Hi, On 26 September 2017 at 21:39, Jonathan Liu <net...@gmail.com> wrote: > This fixes a kernel oops when unloading the driver due to usb_put_phy > being called after usb_phy_generic_unregister when the device is > detached. Calling usb_phy_generic_unregister causes x->dev-&g

[PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

icitly managing the lifetime of usb_phy, devm_usb_get_phy is changed to usb_get_phy and we call usb_put_phy in the probe error path. Cc: sta...@vger.kernel.org # v4.3+ Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/usb/musb/sunxi.c | 8 ++-- 1 file changed, 6 insertions(+),

[PATCH] usb: gadget: Add kerneldoc for some neglected structure fields

' Document those fields to make the warnings go away. Signed-off-by: Jonathan Corbet <cor...@lwn.net> --- include/linux/usb/gadget.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index 1a4a4bacfae6..49d8e2b7ae4a 100644 --- a/include

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

on.h| 2 +- > arch/arm/mach-omap2/omap_twl.c | 2 +- > drivers/gpio/gpio-twl4030.c | 2 +- > drivers/iio/adc/twl4030-madc.c | 2 +- > drivers/iio/adc/twl6030-gpadc.c | 2 +- Acked-by: Jonathan Cameron <ji...@kernel.org> Thanks

Re: [PATCH v4 0/6] Get rid of usbfs leftovers

On Sun, 16 Apr 2017 21:51:05 -0300 Mauro Carvalho Chehab wrote: > When we got rid of usbfs, the old /proc/bus/usb stuff got moved > to two different places: > usb/devices is now at /sys/kernel/debug > /proc/bus/usb/BBB/DDD are not at /dev/bus/usb/BBB/DDD >

Re: [PATCH v2] docs-rst: usb: update old usbfs-related documentation

On Sun, 16 Apr 2017 13:04:36 -0300 Mauro Carvalho Chehab wrote: > There's no usbfs anymore. The old features are now either > exported to /dev/bus/usb or via debugfs. > > Update documentation accordingly, pointing to the new > places where the character devices and

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

On Tue, 11 Apr 2017 16:58:40 +0200 Greg Kroah-Hartman wrote: > Nope, they don't apply to my tree, it was probably based on yours. And > the first two are ones I shouldn't be taking. > > So, feel free to take all of these with a: > Acked-by: Greg Kroah-Hartman

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

On Wed, 5 Apr 2017 10:22:54 -0300 Mauro Carvalho Chehab wrote: > Currently, there are several USB core documents that are at either > written in plain text or in DocBook format. Convert them to ReST > and add to the driver-api book. Greg, do you see any reason not to

Re: [PATCH v2 01/22] tmplcvt: make the tool more robust

On Thu, 30 Mar 2017 07:45:35 -0300 Mauro Carvalho Chehab wrote: > Currently, the script just assumes to be called at > Documentation/sphinx/. Change it to work on any directory, > and make it abort if something gets wrong. > > Also, be sure that both parameters are

Re: [PATCH 02/22] docs-rst: convert usb docbooks to ReST

On Thu, 30 Mar 2017 11:20:14 +0200 Markus Heiser wrote: > @Jon: what do you think about a bulk conversion? I'm a bit leery of it, to tell the truth. We're trying to create a better set of kernel docs, and I'm far from convinced that dumping a bunch of unloved stuff

Re: [PATCH v4 1/2] usbip: Fix-format-overflow

On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote: > The usbip userspace tools call sprintf()/snprintf() and don't check for > the return value which can lead the paths to overflow, truncating the > final file in the path. > > More urgently, GCC 7 now warns that these

[PATCH v4 1/2] usbip: Fix-format-overflow

, that makes these tools unbuildable. This patch fixes these problems by replacing sprintf() with snprintf() in one place and adding checks for the return value of snprintf(). Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- Chan

[PATCH v4 2/2] usbip: Fix implicit fallthrough warning

.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- tools/usb/usbip/src/usbip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c index d7599d9..73d8eee 100644 --- a/tools/usb/usbip/src/usbip.c +++ b/tools/usb/usbip

[PATCH v3 1/2] usbip: Fix-format-overflow

, that makes these tools unbuildable. This patch fixes these problems by replacing sprintf() with snprintf() in one place and adding checks for the return value of snprintf(). Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- Chan

[PATCH v3 2/2] usbip: Fix implicit fallthrough warning

.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- tools/usb/usbip/src/usbip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c index d7599d9..73d8eee 100644 --- a/tools/usb/usbip/src/usbip.c +++ b/tools/usb/usbip

Re: [PATCH v2 1/2] usbip: Fix-format-overflow

On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote: > Hi, > > W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze: > >   char busid[SYSFS_BUS_ID_SIZE]; > > + unsigned int size; > > I'm not really convinced to use unsigned here. snprintf() is declared > to 

[PATCH v2 1/2] usbip: Fix-format-overflow

, that makes these tools unbuildable. This patch fixes these problems by replacing sprintf() with snprintf() in one place and adding checks for the return value of snprintf(). Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- too

[PATCH v2 2/2] usbip: Fix implicit fallthrough warning

.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- tools/usb/usbip/src/usbip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c index d7599d9..73d8eee 100644 --- a/tools/usb/usbip/src/usbip.c +++ b/tools/usb/usbip

Re: [PATCH 1/2] Fix format overflows

On Tue, 2017-02-21 at 08:48 +0200, Jonathan Dieter wrote: > On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote: > > Hi, > >   > > W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:  > > > + err("busid length %i >= SYSFS_BUS_ID_SIZE", >

Re: [PATCH 1/2] Fix format overflows

Thanks for looking at this. One quick question before I put out version two with your corrections: On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote: > Hi, >  > W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze: > > The usbip userspace tools call sprintf()/snprintf()

[PATCH 2/2] Fix implicit fallthrough warning

.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- tools/usb/usbip/src/usbip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c index d7599d9..73d8eee 100644 --- a/tools/usb/usbip/src/usbip.c +++ b/tools/usb/usbip

[PATCH 1/2] Fix format overflows

, that makes these tools unbuildable. This patch fixes these problems by replacing sprintf() with snprintf() in one place and adding checks for the return value of snprintf(). Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com> Signed-off-by: Jonathan Dieter <jdie...@lesbg.com> --- too

Re: [PATCH] USB: update intro of documentation

On Mon, 24 Oct 2016 14:25:27 +0200 Greg KH wrote: > I don't have any objection to the changes, please take them through your > documentation tree: I have now done so. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH] USB: update intro of documentation

On Thu, 20 Oct 2016 15:15:00 +0200 Oliver Neukum wrote: > It does no good to mention The 2.4 kernel series and neglect > USB 3.x and XHCI. Also with type C and micro/mini USB we better > not talk about the shape of connectors. ...except that USB 2 connectors will be with us

Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

On Thu, 20 Oct 2016 18:22:28 +0200 Oliver Neukum wrote: > > Why does this not remove the .tmpl file? > > 1. We might want to keep it > 2. It is an operation beyond the scope of this patch. I have to disagree with this part; the last thing we want is two copies of the

Re: [PATCH] doc: usb: Fix typo in gadget_multi documentation

On Tue, 12 Apr 2016 18:13:27 +0100 Diego Herranz wrote: > It tries to "match" drivers for each interface (not "much"). Indeed. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [RFC PATCH] codingstyle: improve elisp for a better experience

On Thu, 21 Jan 2016 22:18:30 -0300 "Geyslan G. Bem" wrote: > This patch does use of more emacs functionalities which deliver to the > user indentation, commenting and white space highlighting. So perhaps it's just me, but that's an awful lot of elisp code for readers to wade

Re: [PATCH] net: asix: add support for the Billionton GUSB2AM-1G-B USB adapter

I fully understand. Because I seem unable to go around the annoying message, I will try to resubmit the patch with another email account. Thanks. Jonathan * This email message, including any attachments, is for the sol

Re: [linux-sunxi] [PATCH v5 2/7] phy-sun4i-usb: Add extcon support for the otg phy (phy0)

GENERIC_PHY help Enable this to support the transceiver that is part of Allwinner Should probably add CONFIG_EXTCON=y to arch/arm/configs/sunxi_defconfig so that CONFIG_PHY_SUN4I_USB=y works out of the box. Regards, Jonathan -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

On Sat, 28 Mar 2015 14:37:57 +0100 Marek Belisko ma...@goldelico.com wrote: This patch changes the documentation file as needed. Applied to the docs tree (with the changelog typo fixed). Thanks, jon -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

On Thu, 2 Apr 2015 12:35:09 +0200 Johan Hovold jo...@kernel.org wrote: This patch was incorrect and needed to be updated as discussed in the thread. Can you drop it or is your tree immutable? Sigh...and I thought I was on top of that. Dropped, sorry for the confusion. jon -- To unsubscribe

Re: [PATCH v3 0/2] staging: dwc2: add microframe scheduler

for execution (i.e. submission to the otg core) based on the microframe number of the last nak_frame received. In the case where FIQ support is not provided, then the SOF interrupt will have to be unmasked as long as there are QHs with nak_frame set. Regards Jonathan -- To unsubscribe from this list

Re: uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

://bugzilla.kernel.org/show_bug.cgi?id=80101 Regards, Jonathan On Mon, 14 Jul 2014 21:48:15 +0200 Julian Sikorski beleg...@gmail.com wrote: Hello, the same happens to me on an up-to-date Fedora 20 installation with Lacie Rugged USB3: [ 217.024320] usb 4-2: new SuperSpeed USB device number 2

Re: uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

My drive is working again with: options usb-storage quirks=174c:55aa:u -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

Here are some reports of this regression affecting other hardware: https://bbs.archlinux.org/viewtopic.php?id=183190 lsusb -v output: Bus 003 Device 003: ID 4971:8017 SimpleTech Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 3.00

Re: uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

Additional affected hardware: us 002 Device 004: ID 0bc2:3312 Seagate RSS LLC Couldn't open device, some information will be missing Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.10 bDeviceClass0 (Defined at Interface level)

Re: uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

On Fri, 20 Jun 2014 22:44:35 -0400 (GMT-04:00) Jonathan jonathan.625...@earthlink.net wrote: After upgrading to kernel 3.15 my USB 3.0 HDD dock no longer works. In fact, as soon as I connect and power up a drive with the uas module loaded, I get a hard lockup and have to restart the system

uas regression in 3.15 with ASMedia 2105 SATA bridge / ASMT1051

After upgrading to kernel 3.15 my USB 3.0 HDD dock no longer works. In fact, as soon as I connect and power up a drive with the uas module loaded, I get a hard lockup and have to restart the system. Without the uas module loaded, the dock is detected but the drive is not, rendering it unusable.

[3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

of current master (d92581fcad18, 2013-08-10) produces a working kernel. dmesg output from that working kernel attached. More details, including .config, at [2]. Any ideas for tracking this down? Thanks, Jonathan [1] Screenshot: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=bad_3.10.3-1.jpg

Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)

with it. Note that Holger ran into the same problem using a mainline (3.8-rc5) kernel. Thanks, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)

that helps, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

/664068 Reported-and-tested-by: David Banks amoe...@gmail.com # Oxygen 49 Reported-and-tested-by: Olivier MATZ z...@droids-corp.org # KeyRig 49 Signed-off-by: Jonathan Nieder jrnie...@gmail.com Cc: sta...@vger.kernel.org --- Thoughts? drivers/usb/core/quirks.c | 6 ++ 1 file changed, 6

Re: Mouse and keyboard freeze on Ivy Bridge platform

to test connecting the old keyboard and mouse through a hub, that would still be useful. Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [stable] xHCI: handle command after aborting the command ring

) consumer was replaced by the boolean value (ring-type == TYPE_EVENT). In b63f4053 the ring is xhci-cmd_ring which has type TYPE_COMMAND, so consumer should be false. Thanks, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: Mouse and keyboard freeze on Ivy Bridge platform

--disable DEBUG_INFO make localmodconfig; # optional: minimize configuration scripts/config --enable USB_DEBUG # build, test make deb-pkg; # can use -jnum for parallel build dpkg -i ../name of package; # as root reboot Thanks, Jonathan

Re: [3.1-3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

for this one is http://bugs.debian.org/680707. Please cc me or 680...@bugs.debian.org if bringing it up with ACPI folks so we can track the discussion. Thanks again for your hard work. Ciao, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord