Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

2018-03-15 Thread Kalle Valo
ers/net/wireless/cisco/Kconfig | 2 +- Acked-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/18] net: use ARRAY_SIZE

2017-10-02 Thread Kalle Valo
13 files changed, 177 insertions(+), 413 deletions(-) We have a tree for wireless so usually it's better to submit wireless changes on their own but here I assume Dave will apply this to his tree. If not, please resubmit the wireless part in a separate patch. -- Kalle Valo -- To unsubscribe from this

Re: [1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-05 Thread Kalle Valo
Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") > Cc:

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
Johan Hovold <jo...@kernel.org> writes: > On Mon, Apr 03, 2017 at 01:02:28PM +0000, Kalle Valo wrote: >> Kalle Valo <kv...@codeaurora.org> writes: >> >> > Johan Hovold <jo...@kernel.org> writes: >> > >> >> On Mon, Mar 13, 2017 at

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Johan Hovold <jo...@kernel.org> writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessi

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
, I'm just lacking behing: https://patchwork.kernel.org/patch/9620723/ > As I mentioned earlier, I should have added a > > Cc: stable <sta...@vger.kernel.org> # 2.6.39 > > but left it out as I mistakingly thought the net recommendations to do > so applied also to wireless.

Re: [2/2] zd1211rw: fix NULL-deref at probe

2017-03-22 Thread Kalle Valo
Johan Hovold <jo...@kernel.org> writes: > On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote: >> Johan Hovold <jo...@kernel.org> wrote: >> > Make sure to check the number of endpoints to avoid dereferencing a >> > NULL-pointer or accessing

Re: [2/2] zd1211rw: fix NULL-deref at probe

2017-03-22 Thread Kalle Valo
Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-09 Thread Kalle Valo
ommit/?id=949c2d0096753d518ef6e0bd8418c8086747196b >> >> I'm planning to send you a pull request tomorrow which contains that >> one. > > Thanks Kalle! > > David, can you hold on this series until Kalle's pull request gets > submitted? Past this error, allmo

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread Kalle Valo
file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request

Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Kalle Valo
module_platform_driver(ath_ahb_driver); > ^ > include/linux/device.h:1459:19: note: in definition of macro 'module_driver' > static int __init __driver##_init(void) \ >^~~~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Andrew Lutomirski <l...@kernel.org> wrote: >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >&g

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Andrew Lutomirski <l...@kernel.org> wrote: >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >>

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Andrew Lutomirski wrote: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski <l...@amacapital.net> writes: > On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Andy Lutomirski <l...@kernel.org> writes: >> >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
I'm just wondering should I push this to 4.10 or -next. This is a driver for ancient hardware so I'm starting to lean for -next. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Help adding trace events to xHCI

2013-07-12 Thread Kalle Valo
Sarah Sharp sarah.a.sh...@linux.intel.com writes: On Fri, Jul 12, 2013 at 07:25:59AM +0300, Kalle Valo wrote: Instead of individual trace points for command I would recommend to consider just pushing the whole command buffer to the trace point and parse the command in trace-cmd plugin

Re: Help adding trace events to xHCI

2013-07-11 Thread Kalle Valo
to ath6kl was that I wanted to combine wpasupplicant, cfg80211 and ath6kl debug messages all into file with synchronised timestamps. In this case I wasn't actually concerned about performance at all. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: Help adding trace events to xHCI

2013-07-11 Thread Kalle Valo
to consider just pushing the whole command buffer to the trace point and parse the command in trace-cmd plugin in user space. Kernel code would be simpler that way. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org