Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-03-20 Thread Kishon Vijay Abraham I
Hi, On Monday 19 March 2018 09:42 PM, Martin Blumenstingl wrote: > Hi Roger, > > On Mon, Mar 19, 2018 at 9:49 AM, Roger Quadros wrote: >> Hi, >> >> On 19/03/18 00:29, Martin Blumenstingl wrote: >>> Hi Roger, >>> >>> On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros

Re: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-08 Thread Kishon Vijay Abraham I
Hi Tony, On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote: > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > It is used on some Motorola Mapphone series of phones and tablets such > as Droid 4. > > The MDM6600 is hardwired to the first OHCI port in the Droid 4

Re: [PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-02 Thread Kishon Vijay Abraham I
Hi Tony, On Thursday 01 March 2018 09:20 AM, Tony Lindgren wrote: > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > It is used on some Motorola Mapphone series of phones and tablets such > as Droid 4. Generally PHY configuration is done for the PHYs that is connected to

Re: [PATCH v5 00/17] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

2018-02-16 Thread Kishon Vijay Abraham I
On Thursday 01 February 2018 06:08 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 31 January 2018 10:51 AM, Manu Gautam wrote: >> Hi Kishon, >> >> >> On 1/16/2018 4:26 PM, Manu Gautam wrote: >>> QUSB-v2 and QMP-v3 USB PHYs are pr

Re: [PATCH v5 00/17] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

2018-02-01 Thread Kishon Vijay Abraham I
Hi, On Wednesday 31 January 2018 10:51 AM, Manu Gautam wrote: > Hi Kishon, > > > On 1/16/2018 4:26 PM, Manu Gautam wrote: >> QUSB-v2 and QMP-v3 USB PHYs are present on Qualcomm's 14nm >> and 10nm SOCs. >> This patch series adds support for runtime PM for these >> USB PHYs and adds fixes in

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

2018-01-11 Thread Kishon Vijay Abraham I
Hi Arnd, On Thursday 11 January 2018 11:46 PM, Eric Anholt wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> On Thu, Jan 11, 2018 at 2:30 PM, Kishon Vijay Abraham I <kis...@ti.com> >> wrote: >>> On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wro

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

2018-01-11 Thread Kishon Vijay Abraham I
Hi Arnd, On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wrote: > On Mon, Jan 8, 2018 at 7:32 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >> Hi Arnd, >> >> On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote: >>> Stefan Wahren reports a proble

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

2018-01-08 Thread Kishon Vijay Abraham I
Hi Arnd, On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote: > Stefan Wahren reports a problem with a warning fix that was merged > for v4.15: we had lots of device nodes with a 'phys' property pointing > to a device node that is not compliant with the binding documented in >

Re: [PATCH v4 14/16] phy: Add USB speed related PHY modes

2018-01-05 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 January 2018 04:58 PM, Manu Gautam wrote: > Add following USB speed related PHY modes: > LS (Low Speed), FS (Full Speed), HS (High Speed), SS (Super Speed) > > Speed related information is required by some QCOM PHY drivers > to program PHY monitor resume/remote-wakeup events

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-28 Thread Kishon Vijay Abraham I
Hi, On Friday 29 December 2017 09:54 AM, Manu Gautam wrote: > Hi, > > > On 12/28/2017 4:34 PM, Kishon Vijay Abraham I wrote: >> Hi, >> > [snip] >> >>>> I'd prefer adding modes in enum phy_mode according to speed and using >>>> phy

Re: [PATCH 1/3] phy: phy-mtk-tphy: use auto instead of force to bypass utmi signals

2017-12-28 Thread Kishon Vijay Abraham I
On Thursday 07 December 2017 05:23 PM, Chunfeng Yun wrote: > When system is running, if usb2 phy is forced to bypass utmi signals, > all PLL will be turned off, and it can't detect device connection > anymore, so replace force mode with auto mode which can bypass utmi > signals automatically if

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-28 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 December 2017 02:11 PM, Manu Gautam wrote: > Hi > > > On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote: >> Hi, >> > [snip] >>>> Why not use a notification mechanism instead of adding new APIs in >>>> phy

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 December 2017 11:59 AM, Manu Gautam wrote: > Hi, > > > On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: >>> Hi, >>> >>> >>

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: > Hi, > > > On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: >>> QCOM USB PHYs can monitor resume/remote-wakeup event in

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-12 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: > QCOM USB PHYs can monitor resume/remote-wakeup event in > suspended state. However PHY driver must know current > operational speed of PHY in order to set correct polarity of > wakeup events for detection. E.g. QUSB2 PHY monitors

Re: [PATCHv4 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2017-10-25 Thread Kishon Vijay Abraham I
Felipe, On Monday 09 October 2017 05:30 PM, Andrzej Pietrasiewicz wrote: > From: Vivek Gautam > > Adding phy calibration sequence for USB 3.0 DRD PHY present on > Exynos5420/5800 systems. > This calibration facilitates setting certain PHY parameters viz. > the

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

2017-10-22 Thread Kishon Vijay Abraham I
On Wednesday 18 October 2017 07:44 AM, Chanwoo Choi wrote: > Gently Ping. > > Dear Kishon, > > Could you please review this patch for 'drivers/phy/*'? sorry for the delay.. here it is Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > > Regards, > Chanwoo Ch

Re: [PATCHv4 0/2] dwc3 on XU3

2017-10-18 Thread Kishon Vijay Abraham I
On Monday 09 October 2017 05:30 PM, Andrzej Pietrasiewicz wrote: > Hi all, > > This is the fourth version of patches in this thread. > > The series fixes problems with enumerating of SuperSpeed devices > on an Odroid XU3. There was a patch series from Vivek Gautam in > circulation, but it got

Re: [PATCHv3 1/2] drivers: phy: add calibrate method

2017-10-09 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 October 2017 05:41 PM, Andrzej Pietrasiewicz wrote: > Some quirky UDCs (like dwc3 on exynos) need to have heir phys calibrated %s/heir/their > e.g. for using super speed. The commit log should also include when phy calibrate should be used and why existing API's is not

Re: [PATCHv2 0/2]

2017-10-03 Thread Kishon Vijay Abraham I
Hi, On Tuesday 03 October 2017 06:29 PM, Andrzej Pietrasiewicz wrote: > Hi all, > > This is the second version of patches in this thread. > > The series fixes problems with enumerating of SuperSpeed devices > on an Odroid XU3. There was a patch series from Vivek Gautam in > circulation, but it

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2017-09-21 Thread Kishon Vijay Abraham I
Hi, On Monday 18 September 2017 07:50 PM, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 18.09.2017 o 14:43, Felipe Balbi pisze: >> >> Hi, >> >> Andrzej Pietrasiewicz writes: >>> +static int exynos5_usbdrd_phy_reset(struct phy *phy) >>> +{ >>> +struct

Re: [PATCH RESEND 1/2] phy: phy-mtk-tphy: fix NULL point of chip bank

2017-09-21 Thread Kishon Vijay Abraham I
On Thursday 21 September 2017 04:01 PM, Chunfeng Yun wrote: > Chip bank of version-1 is initialized as NULL, but it's used > by pcie_phy_instance_power_on/off(), so assign it a right > address. merged. How was this not noticed before? Thanks Kishon > > Signed-off-by: Chunfeng Yun

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2017-09-18 Thread Kishon Vijay Abraham I
Hi, On Monday 18 September 2017 04:08 PM, Felipe Balbi wrote: > > Hi, > > Andrzej Pietrasiewicz writes: >> From: Vivek Gautam >> >> Adding phy calibration sequence for USB 3.0 DRD PHY present on >> Exynos5420/5800 systems. >> This calibration

Re: [PATCH 4/4] dt-bindings: phy-mt65xx-usb: supports PCIe, SATA and rename file

2017-08-08 Thread Kishon Vijay Abraham I
Chunfeng On Thursday 03 August 2017 03:50 PM, Chunfeng Yun wrote: > hi, > > I made a mistake, please ignore the patches with Change-Id, very sorry No problem. However can you resend the series after fixing all checkpatch warnings? Thanks Kishon -- To unsubscribe from this list: send the line

Re: [PATCH 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated extcon API

2017-08-01 Thread Kishon Vijay Abraham I
On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_get_state() > > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: Raviteja Garimella <raviteja.garime...

Re: [PATCH 2/5] phy: rockchip-inno-usb2: Replace the extcon API

2017-08-01 Thread Kishon Vijay Abraham I
con_set_state_sync() > > Cc: linux-rockc...@lists.infradead.org > acked-by: Kishon Vijay Abraham I <kis...@ti.com> ^ should be 'A' here. -Kishon > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > --- > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 10

Re: [PATCH] phy: qcom-qmp: Fix failure path in phy_init functions

2017-08-01 Thread Kishon Vijay Abraham I
control deassertion failure path in >> qcom_qmp_phy_com_init(). >> >> Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets") >> >> Cc: Kishon Vijay Abraham I <kis...@ti.com> >> Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org

Re: [PATCH] phy: cpcap-usb: Fix missing return statement

2017-06-15 Thread Kishon Vijay Abraham I
On Monday 12 June 2017 01:42 PM, Tony Lindgren wrote: > Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > is missing return statement as noted by Colin Ian King > . If the optional pins are not configured, > we just want to return early and not

Re: [PATCH v2 2/2] phy: tusb1210: implement ->set_mode()

2017-06-09 Thread Kishon Vijay Abraham I
On Friday 09 June 2017 03:50 PM, Felipe Balbi wrote: > ->set_mode() can be used to tell PHY to prepare itself to enter USB > Host/Peripheral mode and that's very important for DRD > configurations. > > Signed-off-by: Felipe Balbi > > changes since v1: > -

Re: [PATCH v2 1/2] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
On Friday 09 June 2017 03:50 PM, Felipe Balbi wrote: > TUSB1211 is software compatible with TUSB1210 and as such we don't > need an entire new driver to control it. Let's add its product ID to > the existing TUSB1210 driver instead. > > Signed-off-by: Felipe Balbi

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
Hi, On Friday 09 June 2017 03:27 PM, Felipe Balbi wrote: > > Hi, > > Kishon Vijay Abraham I <kis...@ti.com> writes: >> On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: >>> TUSB1211 is software compatible with TUSB1210 and as such we don't >>> need

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
Hi Felipe, On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: > TUSB1211 is software compatible with TUSB1210 and as such we don't > need an entire new driver to control it. Let's add its product ID to > the existing TUSB1210 driver instead. > > Signed-off-by: Felipe Balbi

Re: [PATCHv4] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-06-01 Thread Kishon Vijay Abraham I
On Tuesday 23 May 2017 06:07 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for the SoC

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-23 Thread Kishon Vijay Abraham I
On Monday 22 May 2017 03:32 AM, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang <w...@the-dreams.de> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- >

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

2017-05-16 Thread Kishon Vijay Abraham I
himoda...@renesas.com> > Reviewed-by: Jaehoon Chung <jh80.ch...@samsung.com> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: David S. Miller <da...@davemloft.net> > Cc: Geert Uytterhoeven <geert+rene...@glider.be> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesa

Re: [PATCH v5 1/3] phy: qcom-usb: Remove unused ulpi phy header

2017-05-16 Thread Kishon Vijay Abraham I
linaro.org> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-arm-...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Cc: linux-usb@vger.kernel.org this patch introduced a bunch of compiler errors because of missing "

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

2017-05-12 Thread Kishon Vijay Abraham I
himoda...@renesas.com> > Reviewed-by: Jaehoon Chung <jh80.ch...@samsung.com> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: David S. Miller <da...@davemloft.net> > Cc: Geert Uytterhoeven <geert+rene...@glider.be> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesa

Re: [PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-08 Thread Kishon Vijay Abraham I
Hi Tony, On Monday 10 April 2017 09:49 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for

Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK

2017-04-09 Thread Kishon Vijay Abraham I
; Cc: Fengguang Wu <fengguang...@intel.com> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > --- > > Hi Kishon, > > This patch is fixing the build failures for architectures > such as, tile, and ia64, that

Re: [PATCH v5 1/9] phy: phy-mt65xx-usb3: improve RX detection stable time

2017-04-06 Thread Kishon Vijay Abraham I
On Friday 31 March 2017 01:05 PM, Chunfeng Yun wrote: > The default value of RX detection stable time is 10us, and this > margin is too big for some critical cases which cause U3 link fail > and link to U2(probability is about 1%). So change it to 5us. > merged all the phy patches in this

Re: [PATCH V8 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-06 Thread Kishon Vijay Abraham I
On Thursday 06 April 2017 11:21 AM, Vivek Gautam wrote: > Hi Kishon, > Here's the series with fixed checkpatch warnings/checks. > Please pick it for phy/next. > > This patch series adds couple of PHY drivers for Qualcomm chipsets. > a) qcom-qusb2 phy driver: that provides High Speed USB

Re: [PATCH V7 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Kishon Vijay Abraham I
Hi Vivek, On Wednesday 05 April 2017 06:02 PM, Vivek Gautam wrote: > This patch series adds couple of PHY drivers for Qualcomm chipsets. > a) qcom-qusb2 phy driver: that provides High Speed USB functionality. > b) qcom-qmp phy driver: that is a combo phy providing support for >USB3, PCIe, UFS

Re: [PATCH v4 0/3] phy: Group phy drivers based on vendor listing

2017-04-05 Thread Kishon Vijay Abraham I
Hi Vivek, On Wednesday 05 April 2017 05:07 PM, Vivek Gautam wrote: > Hi Kishon, > > > On 04/05/2017 04:34 PM, Kishon Vijay Abraham I wrote: >> Hi Vivek, >> >> On Monday 20 March 2017 06:49 PM, Vivek Gautam wrote: >>> This is the next version to an earli

Re: [PATCH v3 0/3] add support of usb2-phy for rk3328

2017-04-05 Thread Kishon Vijay Abraham I
On Monday 06 March 2017 06:59 AM, Meng Dongyang wrote: > The config information of RK3328 about address and port property > is different from other platform. So adds config information in the > data of match table and the device tree bindings description for > usb2-phy. > > Changes in v2: > -

Re: [PATCH v4 0/3] phy: Group phy drivers based on vendor listing

2017-04-05 Thread Kishon Vijay Abraham I
eived 'Acked-by' and 'Reviewed-by' > tags. > > This series is based on linux-phy/next branch. > > [1] https://www.spinics.net/lists/arm-kernel/msg568370.html > > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > C

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-30 Thread Kishon Vijay Abraham I
Hi Tony, On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I <kis...@ti.com> [170326 23:27]: >> On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: >>> +static const struct phy_ops ops = { >>> + .owner = THIS_MODULE,

Re: [PATCH 0/2] add support of u2phy for rk3328

2017-03-27 Thread Kishon Vijay Abraham I
On Wednesday 01 March 2017 03:43 PM, Meng Dongyang wrote: > The config information of RK3328 about address and port property > is different from before platform. So add config information in the > data of match table and documentation of the device tree bindings > of u2phy. merged, thanks.

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-27 Thread Kishon Vijay Abraham I
Hi Tony, On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY

Re: [RESEND PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

2017-03-09 Thread Kishon Vijay Abraham I
Hi, On Monday 06 March 2017 07:19 PM, Chunfeng Yun wrote: > the reference clock of HighSpeed port is 48M which comes from PLL; > the reference clock of SuperSpeed port is 26M which usually comes > from 26M oscillator directly, but some SoCs are not, add it for > compatibility, and put them into

Re: [PATCH v8 0/3] Support qcom's HSIC USB and rewrite USB2 HS support

2017-01-26 Thread Kishon Vijay Abraham I
On Thursday 26 January 2017 04:02 AM, Stephen Boyd wrote: > This patch series continues the usb chipidea rewrite for > Qualcommm platforms. I've dropped the patches that were applied > to Peter's tree for chipidea. Now the phy drivers are left, > along with the patch to call phy_set_mode() at

Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 24 January 2017 01:28 AM, Stephen Boyd wrote: > Quoting Kishon Vijay Abraham I (2017-01-22 00:46:21) >> Hi, >> >> On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: >>> Some USB PHYs need to be told about vbus changing state >>> expl

Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-22 Thread Kishon Vijay Abraham I
Hi, On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: > Some USB PHYs need to be told about vbus changing state > explicitly. For example the qcom USB HS PHY needs to toggle a bit > when vbus goes from low to high (VBUSVLDEXT) to cause the > "session valid" signal to toggle. This signal

Re: [PATCH 1/4] phy: sun4i-usb: add support for V3s USB PHY

2017-01-16 Thread Kishon Vijay Abraham I
On Friday 06 January 2017 07:26 PM, Maxime Ripard wrote: > On Tue, Jan 03, 2017 at 11:25:31PM +0800, Icenowy Zheng wrote: >> Allwinner V3s come with a USB PHY controller slightly different to other >> SoCs, with only one PHY. >> >> Add support for it. >> >> Signed-off-by: Icenowy Zheng

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

2016-12-01 Thread Kishon Vijay Abraham I
t; > Cc: Wei Xu <xuw...@hisilicon.com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.or

Re: [PATCH v3 1/3] phy_sun4i_usb: set_mode: Allow using set_mode to force end the current session

2016-11-18 Thread Kishon Vijay Abraham I
On Friday 23 September 2016 07:10 PM, Hans de Goede wrote: > The sunxi musb has a bug where sometimes it will generate a babble > error on device disconnect instead of a disconnect irq. When this > happens the musb-controller switches from host mode to device mode > (it clears

Re: [PATCH 6/6] phy: twl4030-usb: Fix for musb session bit based PM

2016-11-16 Thread Kishon Vijay Abraham I
lemented their own PM. >> >> Fixes: 467d5c980709 ("usb: musb: Implement session bit based >> runtime PM for musb-core") >> Tested-by: Ladislav Michl <la...@linux-mips.org> >> Tested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> >>

Re: [PATCH v5] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-15 Thread Kishon Vijay Abraham I
On Wednesday 09 November 2016 08:00 AM, Yoshihiro Shimoda wrote: > This patch adds sysfs "role" for usb role swap. This parameter can be > read and write. If you use this file as the following, you can swap > the usb role. > > For example: > 1) Connect a usb cable using 2 Salvator-x boards >

Re: [PATCH] phy: twl4030-usb: make driver DT only

2016-11-15 Thread Kishon Vijay Abraham I
Hi, On Saturday 12 November 2016 04:09 PM, Nicolae Rosia wrote: > All users are DT-only and it makes no sense to keep > unused code Are you sure about this? I still see a bunch of board files in mach-omap2 using twl4030. Thanks Kishon > > Signed-off-by: Nicolae Rosia

Re: [PATCH v5 2/4] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

2016-11-15 Thread Kishon Vijay Abraham I
On Monday 07 November 2016 06:35 PM, Alexandre Bailon wrote: > If we configure the da8xx OTG phy in OTG mode, neither device or host > mode will work. That is because the PHY is not able to detect and notify > the driver that value of ID pin changed. > To work despite this hardware limitation,

Re: [PATCH v2 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-04 Thread Kishon Vijay Abraham I
On Thursday 03 November 2016 09:33 PM, Axel Haslam wrote: > The ohci device name has changed in the board configuraion files, > hence, change the phy lookup table to match the new name. > > Signed-off-by: Axel Haslam merged, thanks. -Kishon > --- >

Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-04 Thread Kishon Vijay Abraham I
On Friday 04 November 2016 11:04 AM, Sekhar Nori wrote: > Hi Kishon, > > On Thursday 03 November 2016 10:20 PM, Kishon Vijay Abraham I wrote: >> >> >> On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: >>> There is only one ohci on the da8xx series o

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

2016-11-03 Thread Kishon Vijay Abraham I
Hi, On Thursday 03 November 2016 10:56 PM, Alexandre Bailon wrote: > On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote: >>> The USB PHY is able to operate in OTG, host or peripheral. >&

Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-03 Thread Kishon Vijay Abraham I
-by: Axel Haslam <ahas...@baylibre.com> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > drivers/phy/phy-da8xx-usb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/phy/phy-da8xx-usb.c > index

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

2016-11-03 Thread Kishon Vijay Abraham I
Hi, On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote: > The USB PHY is able to operate in OTG, host or peripheral. > Some board may be wired to work act only as host or peripheral. > In such case, the dr_mode property of controller must be set to > host or peripheral. But doing that

Re: [PATCH] phy: Add reset callback for not generic phy

2016-10-26 Thread Kishon Vijay Abraham I
On Wednesday 26 October 2016 02:17 AM, John Youn wrote: > On 10/25/2016 7:15 AM, Randy Li wrote: >> I forget to add a dummy function in case the CONFIG_GENERIC_PHY >> is disabled. >> >> Signed-off-by: Randy Li > > Fixes: cac18ecb6f44 ("phy: Add reset callback") > Tested-by:

Re: [PATCH] phy: nop: Add a new phy driver for No-Op transceiver

2016-10-05 Thread Kishon Vijay Abraham I
nop-phy driver. > This can be further extended to add required features. > > Inspired by phy-generic driver in drivers/usb/phy. > > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: Felipe Balbi

Re: [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-19 Thread Kishon Vijay Abraham I
On Monday 19 September 2016 10:12 PM, Kevin Hilman wrote: > Kishon Vijay Abraham I <kis...@ti.com> writes: > >> Hi Kevin, >> >> On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote: >>> Kishon, >>> >>> Martin

Re: [PATCH 1/2] phy-sun4i-usb: Add sun4i_usb_phy_force_session_end() function

2016-09-19 Thread Kishon Vijay Abraham I
Hi, On Sunday 18 September 2016 10:20 PM, Hans de Goede wrote: > The sunxi musb has a bug where sometimes it will generate a babble > error on device disconnect instead of a disconnect irq. When this > happens the musb-controller switches from host mode to device mode > (it clears

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-18 Thread Kishon Vijay Abraham I
Hi, On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote: > Hi Kishon, > > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I <kis...@ti.com> > wrote: >> Hi, >> >> On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote: >>>

Re: [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-16 Thread Kishon Vijay Abraham I
Hi Kevin, On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote: > Kishon, > > Martin Blumenstingl writes: > >> This is a new driver for the USB PHY found in Meson8b and GXBB SoCs. >> >> Signed-off-by: Martin Blumenstingl

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-16 Thread Kishon Vijay Abraham I
Hi, On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >> However, the problem with all of the solutions proposed (runtime PM ones >> included) is that we're forcing a board-specific design issue (2 devices

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-13 Thread Kishon Vijay Abraham I
On Saturday 10 September 2016 05:48 PM, Kishon Vijay Abraham I wrote: > > On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: >> The high-speed phy on qcom SoCs is controlled via the ULPI >> viewport. >> >> Cc: Kishon Vijay Abraham I <kis...@ti.com>

Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-09-05 Thread Kishon Vijay Abraham I
Hi, On Sunday 04 September 2016 03:25 AM, Randy Li wrote: > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). > > We can get

Re: [PATCH V3 2/2] usb: phy: phy-brcm-usb: Add Broadcom STB USB Phy driver

2016-08-31 Thread Kishon Vijay Abraham I
Hi, On Tuesday 30 August 2016 08:00 PM, Al Cooper wrote: > Add a new USB Phy driver for Broadcom STB SoCs. This driver > supports all Broadcom STB ARM SoCs. This driver in combination > with the generic ohci, ehci and xhci platform drivers will enable > USB1.1, USB2.0 and USB3.0 support. This Phy

Re: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-08-29 Thread Kishon Vijay Abraham I
Hi, On Monday 22 August 2016 06:30 PM, Heiko Stübner wrote: > Am Montag, 22. August 2016, 17:17:41 schrieb Kishon Vijay Abraham I: >> Hi, >> >> On Sunday 21 August 2016 02:02 AM, Randy Li wrote: >>> It is a hardware bug in RK3288, the only way to solve it is to >

Re: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-08-22 Thread Kishon Vijay Abraham I
Hi, On Sunday 21 August 2016 02:02 AM, Randy Li wrote: > It is a hardware bug in RK3288, the only way to solve it is to > reset the phy. > > Signed-off-by: Randy Li > --- > drivers/phy/phy-rockchip-usb.c | 20 > 1 file changed, 20 insertions(+) > > diff

Re: [PATCH] usb: chipidea: support generic phy in PM code path

2016-08-22 Thread Kishon Vijay Abraham I
Hi, On Monday 22 August 2016 01:44 PM, Jisheng Zhang wrote: > + Kishon > > Hi Peter, Kishon, > > On Mon, 22 Aug 2016 15:29:07 +0800 Peter Chen wrote: > >> On Mon, Aug 22, 2016 at 02:39:21PM +0800, Jisheng Zhang wrote: >>> Hi Peter, >>> >>> On Mon, 22 Aug 2016 13:33:08 +0800 Peter Chen wrote:

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-19 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 August 2016 03:47 PM, Felipe Balbi wrote: > > Hi, > > Hans de Goede writes: > > [...] > >> void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled) >> { >> struct sun4i_usb_phy *phy = phy_get_drvdata(_phy); > [...]

Re: [PATCH v5 0/5] da8xx USB PHY platform devices and clocks (was "da8xx UBS clocks")

2016-08-17 Thread Kishon Vijay Abraham I
Hi Kevin, On Saturday 13 August 2016 02:54 AM, Kevin Hilman wrote: > On Wed, May 25, 2016 at 6:18 AM, Sekhar Nori wrote: >> On Monday 23 May 2016 08:44 PM, David Lechner wrote: >>> On 05/09/2016 06:46 PM, David Lechner wrote: v5 changes: renamed "usbphy" to "usb_phy" or

Re: [PATCH v9 2/4] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-08-12 Thread Kishon Vijay Abraham I
Hi, On Friday 22 July 2016 12:30 PM, Frank Wang wrote: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang

Re: [PATCH RESEND v2 1/3] dt: bindings: add bindings for Allwinner A64 usb phy

2016-08-12 Thread Kishon Vijay Abraham I
On Friday 12 August 2016 08:36 AM, Icenowy Zheng wrote: > Signed-off-by: Icenowy Zheng Added "Update sun4i usb phy dt binding documentation to include support for Allwinner A64 usb phy." and then merged this. Thanks Kishon > --- >

Re: [PATCH RESEND v2 2/3] phy: sun4i: add support for A64 usb phy

2016-08-12 Thread Kishon Vijay Abraham I
On Friday 12 August 2016 08:36 AM, Icenowy Zheng wrote: > There's something unknown in the pmu part that shared with H3. > It's renamed as PMU_UNK1 from PMU_UNK_H3. > > Signed-off-by: Icenowy Zheng Fixed the following checkpatch warning and merged this to linux-phy tree.

Re: [PATCH V4] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-08-12 Thread Kishon Vijay Abraham I
Hi, On Friday 12 August 2016 03:58 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Northstar is a family of SoCs used in home routers. They have USB 2.0 > and 3.0 controllers with PHYs that need to be properly initialized. > This driver provides PHY init support in a

Re: [PATCH resend 0/1] phy-sun4i-usb: Add support for peripheral-only mode

2016-08-12 Thread Kishon Vijay Abraham I
On Tuesday 09 August 2016 01:25 AM, Hans de Goede wrote: > Hi Kishon, > > As discussed before, here is a resend now that rc1 is out (and includes > the new of_usb_get_dr_mode_by_phy helper this patch needs). > > Please merge this for 4.9-rcX some of the musb-sunxi glue changes > already merged

Re: [PATCH v5 1/7] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.

2016-07-21 Thread Kishon Vijay Abraham I
Hi, On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: > We will be using a generic syscon device for the TI DA8XX SoC CFGCHIPx > retisters. This will be used by a number of planned drivers including a > new USB PHY driver and common clock framework drivers. > > The same defines are removed

Re: [PATCH v6 0/1] phy-sun4i-usb: Add support for peripheral-only mode

2016-07-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 05 July 2016 02:47 AM, Hans de Goede wrote: > Hi Kishon, > > Thanks for merging one of the 2 pending phy-sun4i-usb patches, I see > that the other one actually has a conflict after merging in > linux-phy/fixes. So here is a rebased version of it. > > Note can you please make sure

Re: [PATCH v6] phy-sun4i-usb: Add support for peripheral-only mode

2016-07-04 Thread Kishon Vijay Abraham I
e <hdego...@redhat.com> > Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > Changes in v2: > -Adjust for of_usb_get_dr_mode_by_phy now taking an args0 parameter > Changes in v3: > -Only toggle the phy vbus-det bit on id-change on systems without vbus-det >

Re: [PATCH v5 3/7] phy: Add set_mode callback

2016-07-04 Thread Kishon Vijay Abraham I
Hi Bin, On Monday 27 June 2016 06:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: >> The initial use for this is for PHYs that have a mode related to USB OTG. >> There are several SoCs (e.g. TI OMAP and DA8xx) tha

Re: [PATCH v5 resend 0/2] phy-sun4i-usb: peripheral-mode + a31 otg workaround

2016-07-04 Thread Kishon Vijay Abraham I
On Sunday 03 July 2016 01:38 AM, Hans de Goede wrote: > Hi, > > On 30-06-16 07:47, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 29 June 2016 11:44 PM, Hans de Goede wrote: >>> Hi Kishon, >>> >>> The "USB: Fix of_usb_get

Re: [PATCH v5 resend 0/2] phy-sun4i-usb: peripheral-mode + a31 otg workaround

2016-06-29 Thread Kishon Vijay Abraham I
Hi, On Wednesday 29 June 2016 11:44 PM, Hans de Goede wrote: > Hi Kishon, > > The "USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block" > patch on which this series depends is in usb-next now: > >

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-29 Thread Kishon Vijay Abraham I
Hi, On Friday 17 June 2016 10:16 PM, Heiko Stübner wrote: > Hi Kishon, > > Am Freitag, 17. Juni 2016, 17:24:46 schrieb Kishon Vijay Abraham I: > >>> + ret = of_clk_add_provider(node, of_clk_src_simple_get, rphy->clk480m); >>> + if (ret < 0) &

Re: [PATCH v5 0/7] da8xx USB PHY (was da8xx USB clocks)

2016-06-27 Thread Kishon Vijay Abraham I
On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: > v5 changes: > > Functionally, nothing has really changed. Just some cleanups based on > feedback. > > * Renamed "usbphy" to "usb_phy" or "usb-phy" as appropriate > * License header matches MODULE_LICENSE in new phy driver applied all

Re: [PATCH v5 3/7] phy: Add set_mode callback

2016-06-27 Thread Kishon Vijay Abraham I
e, the enum can be expaned in the future to include modes for > other types of PHYs as well. > > Suggested-by: Kishon Vijay Abraham I <kis...@ti.com> > Signed-off-by: David Lechner <da...@lechnology.com> I've created a immutable branch for this patch and it can be found here. gi

Re: [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions

2016-06-22 Thread Kishon Vijay Abraham I
Hi, On Saturday 18 June 2016 05:03 PM, Sergei Shtylyov wrote: > On 6/18/2016 12:31 PM, Hans de Goede wrote: > >> commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe") >> changed the condition under which irqs are requested, but omitted matching >> changes to

Re: [PATCH v5 3/7] phy: Add set_mode callback

2016-06-21 Thread Kishon Vijay Abraham I
e, the enum can be expaned in the future to include modes for > other types of PHYs as well. > > Suggested-by: Kishon Vijay Abraham I <kis...@ti.com> > Signed-off-by: David Lechner <da...@lechnology.com> This patch is required for both phy driver and the usb driver. I can create

Re: [PATCH v3 3/4] phy-sun4i-usb: Add workaround for missing Vbus det interrupts on A31

2016-06-17 Thread Kishon Vijay Abraham I
dego...@redhat.com> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > Changes in v2: > -No changes > Changes in v3: > -No changes > --- > drivers/phy/phy-sun4i-usb.c | 34 -- > 1 file changed, 24 insertions(+), 10 deletions

Re: [PATCH v3 2/4] phy-sun4i-usb: Add support for peripheral-only mode

2016-06-17 Thread Kishon Vijay Abraham I
good thing as this means > we will not be registering phy0 on devices where the otg controller is > not enabled in the devicetree. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > Changes in v2: > -Adjust for of

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-17 Thread Kishon Vijay Abraham I
Hi, On Monday 13 June 2016 07:40 AM, Frank Wang wrote: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang

Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Kishon Vijay Abraham I
reset lines. > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > drivers/phy/phy-stih407-usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/p

Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Kishon Vijay Abraham I
n requesting shared/exclusive reset lines. > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > drivers/phy/phy-miphy28lp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/

  1   2   3   4   5   6   7   8   9   10   >