Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

2018-09-23 Thread Lee Jones
On Sun, 23 Sep 2018, Lee Jones wrote: > On Sun, 23 Sep 2018, Laurent Pinchart wrote: > > > Hi Tony, > > > > On Tuesday, 11 September 2018 19:25:38 EEST Tony Lindgren wrote: > > > * Laurent Pinchart [180911 16:12]: > > > > On Tuesday, 11 Sep

Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

2018-09-23 Thread Lee Jones
> > >> > > >> "[PATCH] mfd: omap-usb-host: Fix dts probe of children" > > > > > > This fixes the issue for me. > > > > > > Tested-by: Laurent Pinchart > > > > OK good to hear. > > The fix is still not in v4.19-

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-03 Thread Lee Jones
On Tue, 03 Apr 2018, Masahiro Yamada wrote: > 2018-04-03 17:03 GMT+09:00 Lee Jones <lee.jo...@linaro.org>: > > On Mon, 02 Apr 2018, Andrew Lunn wrote: > > > >> On Mon, Apr 02, 2018 at 10:21:01PM +0900, Masahiro Yamada wrote: > >> > 2018-04-02 2

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-03 Thread Lee Jones
u can cleanly split it up, you don't need an MFD. If > however the registers are in overlapping areas, you do need an > MFD. The MFD core provides access to the registers, while its children > implement PHY, reset, regulator etc. This device certainly sounds like an MFD to me. Can you

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-10-04 Thread Lee Jones
..@ti.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Sebastian Reichel <s...@kernel.org> > Cc: Lee Jones <lee.jo...@linaro.org> > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > --- > drivers/extcon/extcon-adc-jack.c

Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-19 Thread Lee Jones
t;nicolas.fe...@microchip.com> > > Thanks Romain! > > Regards, > > > --- > > drivers/mfd/atmel-flexcom.c | 65 > > ++--- > > 1 file changed, 50 insertions(+), 15 deletions(-) This is the first time I've seen this patch. Why's that?

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-08-14 Thread Lee Jones
On Mon, 14 Aug 2017, Lee Jones wrote: > On Sun, 13 Aug 2017, Wolfram Sang wrote: > > > On Tue, May 23, 2017 at 08:18:19AM +0100, Lee Jones wrote: > > > On Mon, 22 May 2017, Wolfram Sang wrote: > > > > > > > include/linux/i2c is not for client devic

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-08-14 Thread Lee Jones
On Sun, 13 Aug 2017, Wolfram Sang wrote: > On Tue, May 23, 2017 at 08:18:19AM +0100, Lee Jones wrote: > > On Mon, 22 May 2017, Wolfram Sang wrote: > > > > > include/linux/i2c is not for client devices. Move the header file to a > > > more appropriate location. &g

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-08-14 Thread Lee Jones
On Sun, 13 Aug 2017, Wolfram Sang wrote: > On Thu, Jul 06, 2017 at 08:03:52AM +0100, Lee Jones wrote: > > On Thu, 06 Jul 2017, Thierry Reding wrote: > > > > > On Mon, May 22, 2017 at 12:02:10AM +0200, Wolfram Sang wrote: > > > > include/linux/i2c is not for

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-25 Thread Lee Jones
hout drawing more current than specified from others. > > Signed-off-by: Mark Brown <broo...@kernel.org> > Signed-off-by: Baolin Wang <baolin.w...@linaro.org> > --- > Documentation/devicetree/bindings/mfd/wm831x.txt |1 + Acked-by: Lee Jones <lee.jo...@linaro.org

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-07-06 Thread Lee Jones
nged, 26 insertions(+), 26 deletions(-) > > rename include/linux/{i2c => mfd}/twl.h (100%) > > I didn't see this get applied yet, so just in case anyone was waiting > for me (this is trivial, so I don't think there's a need): You're not the last. :) -- Lee Jones Linaro STMic

[GIT PULL] Immutable branch between MFD and X86 due for the v4.13 merge window

2017-06-19 Thread Lee Jones
+-- drivers/platform/x86/intel_bxtwc_tmu.c | 4 - drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- drivers/usb/typec/typec_wcove.c | 2 +- include/linux/mfd/intel_soc_pmic.h | 5 +- 6 files changed, 175 insertions(+), 84 deletions(-) -- Lee Jones Linaro STMicroelectronics

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-05-23 Thread Lee Jones
is.c | 2 +- > drivers/mfd/tps65010.c | 2 +- For my own reference: Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org> > drivers/usb/host/ohci-omap.c| 2 +- > drivers/usb/phy/phy-isp1301-omap.c | 2 +- > drivers/video/fbdev/omap/lcd_h3.c | 2 +- &

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-23 Thread Lee Jones
| 2 +- For my own reference: Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org> I guess this will be going through the MFD tree? > drivers/phy/phy-twl4030-usb.c | 2 +- > drivers/power/supply/twl4030_charger.c | 2 +- > drivers/pwm/pwm-twl-led.c

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Lee Jones
On Tue, 14 Mar 2017, Baolin Wang wrote: > Hi, > > On 14 March 2017 at 17:57, Lee Jones <lee.jo...@linaro.org> wrote: > > On Mon, 20 Feb 2017, Baolin Wang wrote: > > > > [...] > > > >> drivers/power/supply/wm831x_power.c | 63 +++ > >> d

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Lee Jones
sb/gadget/udc/charger.c > create mode 100644 include/linux/usb/charger.h > create mode 100644 include/uapi/linux/usb/charger.h Why have you sent this set to me? Please be careful when submitting patches, since a lot of us have enough mail to contend with already. -- Lee Jones Lina

Re: [PATCH 1/1] mfd: rtsx_usb: avoid setting ucr->current_sg.status

2016-08-30 Thread Lee Jones
ret = ucr->current_sg.status; > > if (act_len) > *act_len = ucr->current_sg.bytes; > > - return ucr->current_sg.status; > + return ret; > } > > int rtsx_usb_transfer_data(struct rtsx_ucr *ucr, unsigned int pipe, -- Lee Jones Lina

Re: [PATCHv6 3/3] mfd: intel_soc_pmic_bxtwc: add support for USB Type-C PHY on WhiskeyCove

2016-08-30 Thread Lee Jones
On Tue, 30 Aug 2016, Lee Jones wrote: > On Mon, 29 Aug 2016, Heikki Krogerus wrote: > > > Intel WhiskeyCove PMIC has also a USB Type-C PHY, so let's > > create a device for it. > > > > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> >

Re: [PATCHv6 3/3] mfd: intel_soc_pmic_bxtwc: add support for USB Type-C PHY on WhiskeyCove

2016-08-30 Thread Lee Jones
On Mon, 29 Aug 2016, Heikki Krogerus wrote: > Intel WhiskeyCove PMIC has also a USB Type-C PHY, so let's > create a device for it. > > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Cc: Lee Jones <lee.jo...@linaro.org> > --- > driver

Re: [PATCH v4 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-08-17 Thread Lee Jones
On Tue, 16 Aug 2016, Andrew F. Davis wrote: > On 08/09/2016 10:27 AM, Lee Jones wrote: > > On Tue, 09 Aug 2016, Andrew F. Davis wrote: > > > >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. > >> Add MFD core support. > >> > &

Re: [PATCH v4 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-08-09 Thread Lee Jones
-smusbdig.h Still requires a DT Ack. Please ping the relevant guys. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-29 Thread Lee Jones
On Wed, 29 Jun 2016, Philipp Zabel wrote: > Am Mittwoch, den 29.06.2016, 09:06 +0100 schrieb Lee Jones: > > On Wed, 29 Jun 2016, Philipp Zabel wrote: > > > Am Dienstag, den 28.06.2016, 09:56 +0100 schrieb Lee Jones: > > > > Philipp, > > > > &

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-29 Thread Lee Jones
On Wed, 29 Jun 2016, Philipp Zabel wrote: > Am Dienstag, den 28.06.2016, 09:56 +0100 schrieb Lee Jones: > > Philipp, > > > > I need this to go into the -rcs too. > > > > Can I add it with your Ack please? > > I have already added your patches to my branch

[PATCH 1/1] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-28 Thread Lee Jones
On the STiH410 B2120 development board the MiPHY28lp shares its reset line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device (DRD). New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-28 Thread Lee Jones
nal_* API > in particular to specify that their request is for a 'shared' line. > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > --- > include/linux/reset.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/reset.h b/include

Re: [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared

2016-06-28 Thread Lee Jones
On Tue, 28 Jun 2016, Lee Jones wrote: > On Mon, 06 Jun 2016, Alan Stern wrote: > > > On Mon, 6 Jun 2016, Lee Jones wrote: > > > > > On the STiH410 B2120 development board the ST EHCI IP shares its reset > > > line with the OHCI IP. New function

Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-28 Thread Lee Jones
On Tue, 07 Jun 2016, Kishon Vijay Abraham I wrote: > > > On Monday 06 June 2016 09:26 PM, Lee Jones wrote: > > On the STiH410 B2120 development board the MiPHY28lp shares its reset > > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > >

Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-06-16 Thread Lee Jones
On Wed, 15 Jun 2016, Andrew F. Davis wrote: > On 06/15/2016 10:43 AM, Lee Jones wrote: > > This requires a USB Ack. > > > >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. > >> Add MFD core support. > >> > >> Signed-off-by: An

Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-06-15 Thread Lee Jones
224 insertions(+) > create mode 100644 drivers/mfd/ti-smusbdig.c > create mode 100644 include/linux/mfd/ti-smusbdig.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from thi

Re: [RESEND PATCH v11 4/4] power: wm831x_power: Support USB charger current limit management

2016-06-15 Thread Lee Jones
hout drawing more current than specified from others. > > Signed-off-by: Mark Brown <broo...@kernel.org> > Signed-off-by: Baolin Wang <baolin.w...@linaro.org> > Acked-by: Lee Jones <lee.jo...@linaro.org> > Acked-by: Charles Keepax <ckee...@opensource.w

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Lee Jones
On Tue, 07 Jun 2016, Lee Jones wrote: > On Tue, 07 Jun 2016, Peter Griffin wrote: > > > Hi, > > > > On Mon, 06 Jun 2016, Lee Jones wrote: > > > > > Phasing out generic reset line requests enables us to make some better > > > decisions on when and

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Lee Jones
On Tue, 07 Jun 2016, Peter Griffin wrote: > Hi, > > On Mon, 06 Jun 2016, Lee Jones wrote: > > > Phasing out generic reset line requests enables us to make some better > > decisions on when and how to (de)assert said lines. If an 'exclusive' > > line is request

[PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared

2016-06-06 Thread Lee Jones
On the STiH410 B2120 development board the ports on the Generic PHY share their reset lines with each other. New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- drive

[PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared

2016-06-06 Thread Lee Jones
On the STiH410 B2120 development board the ST EHCI IP shares its reset line with the OHCI IP. New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- drivers/usb/host/ehc

[PATCH 10/10] usb: host: ohci-st: Inform the reset framework that our reset line may be shared

2016-06-06 Thread Lee Jones
On the STiH410 B2120 development board the ST EHCI IP shares its reset line with the OHCI IP. New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- drivers/usb/host/ohc

[PATCH 3/7] reset: Supply *_shared variant calls when using of_* API

2016-06-06 Thread Lee Jones
Consumers need to be able to specify whether they are requesting an 'exclusive' or 'shared' reset line no matter which API (of_*, devm_*, etc) they are using. This change allows users of the of_* API in particular to specify that their request is for a 'shared' line. Signed-off-by: Lee Jones

[PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers

2016-06-06 Thread Lee Jones
() Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- include/linux/reset.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/include/linux/reset.h b/include/linux/reset.h index ec0306ce..33eaf11 100644 --- a/include/linux/reset.h

[PATCH 2/7] reset: Ensure drivers are explicit when requesting reset lines

2016-06-06 Thread Lee Jones
immediately, causing administration headache between subsystems, this patch adds some temporary stand-in shim-calls. This will ease the burden at merge time and allow subsystems to migrate over to the new API in a more realistic time-frame. Signed-off-by: Lee Jones <lee.jo...@linaro.

[PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-06 Thread Lee Jones
On the STiH410 B2120 development board the MiPHY28lp shares its reset line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device (DRD). New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones

[PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-06 Thread Lee Jones
Consumers need to be able to specify whether they are requesting an 'exclusive' or 'shared' reset line no matter which API (of_*, devm_*, etc) they are using. This change allows users of the optional_* API in particular to specify that their request is for a 'shared' line. Signed-off-by: Lee

[PATCH 5/7] reset: TRIVIAL: Add line break at same place for similar APIs

2016-06-06 Thread Lee Jones
Standardise the way inline functions: devm_reset_control_get_shared_by_index devm_reset_control_get_exclusive_by_index ... are formatted. Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- include/linux/reset.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-06 Thread Lee Jones
On the STiH410 B2120 development board the MiPHY28lp shares its reset line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device (DRD). New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones

[PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-06 Thread Lee Jones
immediately, causing administration headache between subsystems, this patch adds some temporary stand-in shim-calls. This will ease the burden at merge time and allow subsystems to migrate over to the new API in a more realistic time-frame. Lee Jones (7): reset: Reorder inline reset_control_get

Re: [PATCH v8 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-05-09 Thread Lee Jones
org> > --- > drivers/mfd/Kconfig| 8 + > drivers/mfd/Makefile | 1 + > drivers/mfd/intel-vuport.c | 89 > ++ > 3 files changed, 98 insertions(+) > create mode 100644 drivers/mfd/intel-vuport.c Acked-by: Lee Jones <

Re: [PATCH v4 1/7] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.

2016-04-25 Thread Lee Jones
> include/linux/mfd/da8xx-cfgchip.h | 153 > ++ > include/linux/platform_data/usb-davinci.h | 22 - Works for me. Acked-by: Lee Jones <lee.jo...@linaro.org> Since this is a new file, I'm happy for it to be taken in via another tree. >

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-29 Thread Lee Jones
2f69411456d35051e9047c15157c9a5ba217 "usb: host: > >> > xhci-plat: add struct xhci_plat_priv" : > >> > > >> > This patch adds struct xhci_plat_priv to simplify the code to match > >> > platform specific variables. For now, this patch adds

Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-03-18 Thread Lee Jones
-off-by: Fengguang Wu <fengguang...@intel.com> What is this sign-off meant to indicate? > Reviewed-by: Lee Jones <lee.jo...@linaro.org> Why is this here? a) I don't provide "Reviewed-by:" tags #alarmbells b) I have never signed this patch off > --- > MAINTAINERS

Re: [PATCH v2 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-03-07 Thread Lee Jones
rt_acpi_match[] = { > + { "INT3496" }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, vuport_acpi_match); > + > +static struct platform_driver vuport_driver = { > + .driver = { > + .name = "intel-vuport", > + .acpi_match_

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2015-08-18 Thread Lee Jones
current than specified from others. Signed-off-by: Mark Brown broo...@kernel.org Signed-off-by: Baolin Wang baolin.w...@linaro.org --- drivers/power/wm831x_power.c | 69 ++ include/linux/mfd/wm831x/pdata.h |3 ++ MFD: Acked-by: Lee Jones lee.jo

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2015-08-18 Thread Lee Jones
a bunch of bounces, we had a bit of an email fiasco at this end. Hopefully all fixed now. Yes, I sent you guys a mail about that. Glad it's all sorted now. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2015-08-14 Thread Lee Jones
current than specified from others. Signed-off-by: Mark Brown broo...@kernel.org Signed-off-by: Baolin Wang baolin.w...@linaro.org --- drivers/power/wm831x_power.c | 69 ++ include/linux/mfd/wm831x/pdata.h |3 ++ Acked-by: Lee Jones lee.jo

Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-05-26 Thread Lee Jones
On Thu, 21 May 2015, Thierry Reding wrote: On Thu, May 21, 2015 at 09:40:01AM +0100, Lee Jones wrote: On Wed, 20 May 2015, Thierry Reding wrote: On Wed, May 20, 2015 at 07:35:51AM +0100, Lee Jones wrote: On Tue, 19 May 2015, Andrew Bresticker wrote: On Thu, May 14, 2015 at 10:38 AM

Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-05-21 Thread Lee Jones
On Wed, 20 May 2015, Thierry Reding wrote: On Wed, May 20, 2015 at 07:35:51AM +0100, Lee Jones wrote: On Tue, 19 May 2015, Andrew Bresticker wrote: On Thu, May 14, 2015 at 10:38 AM, Andrew Bresticker abres...@chromium.org wrote: On Thu, May 14, 2015 at 12:40 AM, Lee Jones lee.jo

Re: [PATCH v3 2/2] mfd: dln2: add suspend/resume functionality

2015-01-20 Thread Lee Jones
(dln2_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 1/2] mfd: dln2: add start/stop RX URBs helpers

2015-01-20 Thread Lee Jones
: + dln2_stop_rx_urbs(dln2); + +out_free: dln2_free(dln2); return ret; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH 3/4] mfd: dln2: add support for ACPI

2015-01-20 Thread Lee Jones
(dln2_devs)); if (ret != 0) { dev_err(dev, failed to add mfd devices to core\n); -- 1.9.1 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send

Re: [PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

2015-01-19 Thread Lee Jones
On Sun, 18 Jan 2015, Boris Brezillon wrote: Hi Lee, On Sun, 18 Jan 2015 12:52:59 + Lee Jones lee.jo...@linaro.org wrote: On Wed, 14 Jan 2015, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com AT91 SoCs have a memory range reserved

Re: [PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

2015-01-18 Thread Lee Jones
-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Lee Jones lee.jo...@linaro.org --- include/linux/mfd/syscon/atmel-matrix.h | 117 1 file changed, 117 insertions(+) create mode 100644 include/linux/mfd/syscon/atmel-matrix.h Applied, thanks. diff

Re: [PATCH 04/12] mfd: syscon: Add Atmel SMC binding doc

2015-01-18 Thread Lee Jones
this memory region as a syscon, so that different drivers can configure the SMC interface (mostly timing configuration) according to their need. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Lee Jones lee.jo...@linaro.org --- Documentation/devicetree/bindings/mfd

Re: [PATCH 03/12] mfd: syscon: Add atmel-smc registers definition

2015-01-18 Thread Lee Jones
. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Lee Jones lee.jo...@linaro.org --- include/linux/mfd/syscon/atmel-smc.h | 173 +++ 1 file changed, 173 insertions(+) create mode 100644 include/linux/mfd/syscon/atmel-smc.h

Re: [PATCH 02/12] mfd: syscon: Add Atmel Matrix bus DT binding documentation

2015-01-18 Thread Lee Jones
), hence we declare this register set as a syscon device. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Lee Jones lee.jo...@linaro.org --- .../devicetree/bindings/mfd/atmel-matrix.txt | 24 ++ 1 file changed, 24 insertions(+) create mode

Re: [PATCH v2 3/4] mfd: dln2: add start/stop RX URBs helpers

2015-01-18 Thread Lee Jones
; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-12-01 Thread Lee Jones
CY_USBS_BULK_XFER_TIMEOUT 5000 +#define CY_USBS_INTR_XFER_TIMEOUT 5000 + +#endif /* __MFD_CYUSBS23X_H__ */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH V2 5/5] mfd: tc6387xb: prepare/unprepare clocks

2014-11-18 Thread Lee Jones
); + clk_disable_unprepare(tc6387xb-clk32k); clk_put(tc6387xb-clk32k); kfree(tc6387xb); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send

Re: [PATCH V2 4/5] mfd: t7l66xb: prepare/unprepare clocks

2014-11-18 Thread Lee Jones
); clk_put(t7l66xb-clk48m); - clk_disable(t7l66xb-clk32k); + clk_disable_unprepare(t7l66xb-clk32k); clk_put(t7l66xb-clk32k); t7l66xb_detach_irq(dev); iounmap(t7l66xb-scr); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [PATCH v11 1/3] mfd: add support for Diolan DLN-2 devices

2014-11-10 Thread Lee Jones
the functionality of the device. +config MFD_DLN2 + tristate Diolan DLN2 support + select MFD_CORE + depends on USB + help + I've removed this line and applied the set. I will send out a pull-request to the other Maintainers shortly. [...] -- Lee Jones Linaro

Re: [PATCH v11 0/3] add support for Diolan DLN-2

2014-11-10 Thread Lee Jones
create mode 100644 include/linux/mfd/dln2.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

[GIT PULL] Immutable branch between MFD, GPIO and I2C

2014-11-10 Thread Lee Jones
create mode 100644 drivers/mfd/dln2.c create mode 100644 include/linux/mfd/dln2.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH v11 0/3] add support for Diolan DLN-2

2014-11-10 Thread Lee Jones
On Mon, 10 Nov 2014, Octavian Purdila wrote: On Mon, Nov 10, 2014 at 5:10 PM, Lee Jones lee.jo...@linaro.org wrote: Linus, Wolfram, Enjoy! The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1 (2014-10-19 18:08:38 -0700) are available

Re: [GIT PULL] Immutable branch between MFD, GPIO and I2C

2014-11-10 Thread Lee Jones
insertions(+) create mode 100644 drivers/gpio/gpio-dln2.c create mode 100644 drivers/i2c/busses/i2c-dln2.c create mode 100644 drivers/mfd/dln2.c create mode 100644 include/linux/mfd/dln2.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [GIT PULL] Immutable branch between MFD, GPIO and I2C

2014-11-10 Thread Lee Jones
/mfd/dln2.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-10 Thread Lee Jones
-Original Message- From: Lee Jones [mailto:lee.jo...@linaro.org] Sent: Thursday, October 09, 2014 1:10 PM To: Muthu Mani Cc: Samuel Ortiz; Wolfram Sang; Linus Walleij; Alexandre Courbot; gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux- g...@vger.kernel.org; linux

Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-09 Thread Lee Jones
CY_USBS_INTR_XFER_TIMEOUT5000 + +#endif /* __MFD_CYUSBS23X_H__ */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-09 Thread Lee Jones
On Thu, 09 Oct 2014, Johan Hovold wrote: On Thu, Oct 09, 2014 at 08:40:29AM +0100, Lee Jones wrote: On Mon, 06 Oct 2014, Muthu Mani wrote: +static int update_ep_details(struct usb_interface *interface, + struct cyusbs23x *cyusbs) +{ + struct

Re: [PATCH 1/6] mfd: viperboard: fix platform-device id collision

2014-10-07 Thread Lee Jones
a second viperboard is plugged in: Applied to fixes. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 2/6] mfd: rtsx_usb: fix platform device-id collision

2014-10-07 Thread Lee Jones
) goto out_init_fail; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/6] mfd: core: add helper function to register hotplug devices

2014-10-07 Thread Lee Jones
, + const struct mfd_cell *cells, int n_devs) +{ + return mfd_add_devices(parent, PLATFORM_DEVID_AUTO, cells, n_devs, + NULL, 0, NULL); +} + extern void mfd_remove_devices(struct device *parent); #endif -- Lee Jones Linaro STMicroelectronics Landing Team

Re: [PATCH 4/6] mfd: use mfd_add_hotplug_devices helper

2014-10-07 Thread Lee Jones
, - NULL); + ret = mfd_add_hotplug_devices(interface-dev, vprbrd_devs, + ARRAY_SIZE(vprbrd_devs)); if (ret != 0) { dev_err(interface-dev, Failed to add mfd devices to core.); goto error; -- Lee Jones Linaro STMicroelectronics

Re: [PATCH 5/6] HID: hid-sensor-hub: use mfd_add_hotplug_devices helper

2014-10-07 Thread Lee Jones
, + sd-hid_sensor_client_cnt); if (ret 0) goto err_stop_hw; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/6] mfd: core: fix platform-device id generation

2014-10-07 Thread Lee Jones
, platform_id); if (!pdev) goto fail_alloc; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
*/ struct mutex lock; - u8 buf[sizeof(struct vprbrd_i2c_write_msg)]; + u8 *buf; struct platform_device pdev; }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH v2 2/2] mfd: viperboard: remove redundant OOM message and NULL pointer check

2014-09-24 Thread Lee Jones
vprbrd_probe(struct usb_interface *interface, return 0; error: - if (vb) { - usb_put_dev(vb-usb_dev); - kfree(vb-buf); - kfree(vb); - } + usb_put_dev(vb-usb_dev); + kfree(vb-buf); + kfree(vb); return ret; } -- Lee

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Wed, 24 Sep 2014, Johan Hovold wrote: On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: On Mon, 22 Sep 2014, Octavian Purdila wrote: Currently the I/O buffer is allocated part of the device status structure, potentially sharing the same cache line with other members

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Lee Jones
(+) create mode 100644 drivers/mfd/dln2.c create mode 100644 include/linux/mfd/dln2.h [...] Unless anyone suggests otherwise (e.g. to stick with auto id), I'll add a helper function for this and fix up those two drivers. Appreciated. -- Lee Jones Linaro STMicroelectronics Landing Team Lead

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Lee Jones
On Wed, 17 Sep 2014, Octavian Purdila wrote: On Wed, Sep 17, 2014 at 2:21 AM, Lee Jones lee.jo...@linaro.org wrote: On Tue, 09 Sep 2014, Octavian Purdila wrote: This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-16 Thread Lee Jones
{ + struct { + u8 port; + } i2c; + }; +}; Why this complexity? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-09 Thread Lee Jones
usually prevails here. I sometimes bunch up the really simple/obvious/throw-away variables like; i, j, k, ret, val etc, especially when there are a lot of variables in use, but it's nicer to see the less used, more complex ones on separate lines. -- Lee Jones Linaro STMicroelectronics Landing Team

Re: [PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-08 Thread Lee Jones
submitting a new version of the patch set. Thanks for for review ! No, please don't. Fix-up and resubmit. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-02 Thread Lee Jones
On Mon, 01 Sep 2014, Johan Hovold wrote: On Mon, Sep 01, 2014 at 07:22:39PM +0300, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones lee.jo...@linaro.org

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
in drivers/usb. Please move it there. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Sat, 30 Aug 2014, Octavian Purdila wrote: This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Sat, 30 Aug 2014, Octavian Purdila wrote

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 01 Sep 2014, Octavian Purdila wrote: On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 01 Sep 2014, Octavian Purdila wrote

[PATCH] mfd: omap-usb-host: Fix improper mask use

2014-07-29 Thread Lee Jones
single-ulpi-bypass is a flag used for older OMAP3 silicon. The flag when set, can excite code that improperly uses the OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit. Instead it clears all of the other bits disabling all of the ports in the process. Signed-off-by: Michael

Re: [PATCH] mfd: omap-usb-host: Fix improper mask use

2014-07-29 Thread Lee Jones
On Tue, 29 Jul 2014, Greg KH wrote: On Tue, Jul 29, 2014 at 09:33:25AM +0100, Lee Jones wrote: single-ulpi-bypass is a flag used for older OMAP3 silicon. The flag when set, can excite code that improperly uses the OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit

Re: [PATCH v2 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture

2014-07-24 Thread Lee Jones
On Thu, 24 Jul 2014, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) I Acked, this already. Please carry them forward through revisions. Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/MAINTAINERS b

Re: [PATCH v2 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.

2014-07-24 Thread Lee Jones
1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/st-hcd.txt If you've fixed the nits from the previous review, you should have applied my Ack for this submission. Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones Linaro

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Lee Jones
/Makefile | 1 + drivers/usb/host/st-hcd.c | 460 ++ 3 files changed, 473 insertions(+) create mode 100644 drivers/usb/host/st-hcd.c Looks good to me now: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH v3 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-23 Thread Lee Jones
On Wed, 23 Jul 2014, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v3 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-07-23 Thread Lee Jones
be phandle to system configuration node which + encompasses the glue registers This should be st,syscfg. As you have it in the example. Besides this small issue, I don't see anything controversial so once fixed up, you can apply my: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones

  1   2   3   >