manner and any duplex information.
This patch adds a quirk for such a setup. The PHY is detected by its
PHY ID register values and if present, link detection is not performed
and duplex is always forced to full.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
is considered a MDIO
broadcast address by them. We want to obtain their real MDIO address
instead.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
---
drivers/net/usb/smsc95xx.c | 42 +-
1 file changed, 41 insertions(+), 1 deletion
On 03/06/2018 09:09 AM, Minas Harutyunyan wrote:
Hi,
On 3/6/2018 10:45 AM, Minas Harutyunyan wrote:
Hi,
On 3/5/2018 11:14 PM, Marek Vasut wrote:
On 02/20/2018 06:51 AM, Minas Harutyunyan wrote:
[...]
Is there a way to reduce that or is that the absolute minimum in HS mode?
We already
connected to dwc2 device
See attached
> and driver debug log.
What exactly do you mean by this one ?
--
Best regards,
Marek Vasut
Bus 001 Device 003: ID 0781:5581 SanDisk Corp. Ultra
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.10
On 02/19/2018 11:11 AM, Minas Harutyunyan wrote:
> On 2/19/2018 12:51 PM, Marek Vasut wrote:
>> On 02/19/2018 09:19 AM, Minas Harutyunyan wrote:
>>> On 2/17/2018 12:07 AM, Marek Vasut wrote:
>>>> On 02/16/2018 06:59 AM, Minas Harutyunyan wrote:
>>>&g
On 02/19/2018 09:19 AM, Minas Harutyunyan wrote:
> On 2/17/2018 12:07 AM, Marek Vasut wrote:
>> On 02/16/2018 06:59 AM, Minas Harutyunyan wrote:
>>> On 2/15/2018 5:20 PM, Mirza Krak wrote:
>>>> On 14 February 2018 at 13:07, Minas Harutyunyan
>>>> <mina
80k interrupts / second
>> - Keyboard (FS) = ~80k interrupts / second
>> - WiFI USB (HS) = ~8k interrupts / second
>>
>> After applying the suggested patch [1], it is steady around 8k
>> interrupts / second no matter what device I connect (HS/FS,
>> HUB/NO-HUB). Which is acceptable and usable.
>
> Great!
So 8k IRQs per second is what I should expect from this HW with HS
device attached, that's normal and cannot be reduced ?
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
dering if anyone might have an idea on what could be causing
> this error?
Maybe some clock are not enabled ?
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d 'disable-over-current' binding to allow of the
> option of disabling the over-current condition.
>
> Signed-off-by: Dinh Nguyen <dingu...@kernel.org>
Reviewed-by: Marek Vasut <ma...@denx.de>
Similar patch was in U-Boot for two years now and it does the trick indeed.
&g
On 04/19/2017 10:00 AM, Johan Hovold wrote:
> On Tue, Apr 18, 2017 at 08:07:56PM +0200, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 provides four UARTs, but only two are used. The UART 0
>> is used by the FlashPro5
On 04/18/2017 11:56 AM, Johan Hovold wrote:
> On Mon, Apr 17, 2017 at 01:56:54PM +0200, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 provides four UARTs, but only two are used. The UART 0
>> is used by the FlashPro5
to Linux USB
VID database, but that was acquired by Microsemi.
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: stable <sta...@vger.kernel.org>
Cc: usb <linux-usb@vger.kernel.org>
Cc: Johan Hovold <jo...@kernel.org>
---
V2: - Move the ID in ftdi_sio_ids.h to keep it sorted by
On 02/13/2017 10:29 AM, Johan Hovold wrote:
> [+CC: linux-usb]
>
> Always make sure to CC linux-usb for USB patches.
>
> On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 pr
to Linux USB
VID database, but that was acquired by Microsemi.
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: stable <sta...@vger.kernel.org>
Cc: usb <linux-usb@vger.kernel.org>
Cc: Johan Hovold <jo...@kernel.org>
---
V2: - Move the ID in ftdi_sio_ids.h to keep it sorted by
On 02/13/2017 10:29 AM, Johan Hovold wrote:
> [+CC: linux-usb]
>
> Always make sure to CC linux-usb for USB patches.
Got it
> On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT
On 02/18/2016 05:12 PM, Alan Stern wrote:
> On Tue, 9 Feb 2016, Antony Pavlov wrote:
>
>> This patch retrieves and configures the vbus control gpio via
>> the device tree.
>>
>> This patch is based on a ehci-s5p.c commit fd81d59c90d38661
>> ("USB: ehci-s5p: Add vbus setup function to the s5p ehci
vers/usb/host/ehci-platform.c | 22 ++
> 1 file changed, 22 insertions(+)
I think this patch will not be needed if you switch the ar9331 to chipidea hdrc
driver. There is CI HDRC in the ar9331.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubs
ays define possible values of
fields with offset, so keep this consistent, add the necessary offset
and fix the problem with speed detection.
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: Felipe Balbi <ba...@ti.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: John
On Friday, December 18, 2015 at 12:45:56 AM, John Youn wrote:
> On 12/17/2015 2:49 PM, Marek Vasut wrote:
> > The "enumspd" field is located in register DSTS[2:1], but the current
> > set of macros define the possible values without the necessary offset.
> > This in
with speed detection.
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: Felipe Balbi <ba...@ti.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: John Youn <johny...@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
V2:
if the g_audio can
work well with an ubuntu PC (make sure your codec works well).
ci_hdrc.0 request length too big for isochronous
Doesn't this just mean it cannot transfer such a long buffer via ISO pipe ?
I guess the UAC should send smaller buffers to work with the CI HDRC?
Best regards,
Marek Vasut
On Monday, April 13, 2015 at 07:59:29 AM, har...@ccbib.org wrote:
On Mon, 13 Apr 2015 01:18:07 +0200, Marek Vasut ma...@denx.de wrote:
On Sunday, April 12, 2015 at 12:06:10 PM, Stefan Wahren wrote:
Hi,
toggling the green LED (GPIO 65) on Olinuxino Maxi unexpectedly also
toggles the USB
this would be a silicon problem.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Michael,
Hi Marek, Peter,
On Sat, Aug 25, 2012 at 01:51:38AM +0200, Marek Vasut wrote:
Add the pinmux settings for USB PHY overcurrent pins.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Chris Ball c...@laptop.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: Mark Brown
usbmisc_imx.o
+ obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o
endif
How is this supposed to work please? Can you explain me the trick here please?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Greg,
On Fri, Nov 22, 2013 at 04:34:14PM +0100, Marek Vasut wrote:
Hi Peter,
endif
ifneq ($(CONFIG_OF),)
- obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_imx.o usbmisc_imx.o
+ obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o
Hi Michael,
Hi Marek,
On Sun, Nov 17, 2013 at 11:59:10PM +0100, Marek Vasut wrote:
Dear Peter Chen,
Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will
get -EPROBE_DEFER from usbmisc when both are compiled into the kernel
and thus USB gadget mode won't work
://marc.info/?l=linux-usbm=138060107809076w=2
Argh, I see. So what's the solution here really ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will
get -EPROBE_DEFER from usbmisc when both are compiled into the kernel
and thus USB gadget mode won't work.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Alexander Shishkin alexander.shish...@linux.intel.com
Cc: Peter Chen peter.c
Hi Shawn,
On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote:
+static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
+ { .compatible = fsl,imx28-usb, .data = imx28_usb_data},
+ { .compatible = fsl,imx27-usb, .data = imx27_usb_data},
Just a nit-pick, but the order here
Dear Hector Palacios,
Dear Peter,
On 10/25/2013 08:02 AM, Peter Chen wrote:
According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB
register error issue, All USB register write operations must
use the ARM SWP instruction. So, we implement special hw_write
and hw_test_and_clear
struct of_device_id ci_hdrc_imx_dt_ids[] = {
+ { .compatible = fsl,imx28-usb, .data = imx28_usb_data},
+ { .compatible = fsl,imx27-usb, .data = imx27_usb_data},
Just a nit-pick, but the order here is wrong ;-)
[...]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line
interrupt
Does the ERRATA apply to MX23 as well btw?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
would be to fix those
platforms
that are broken by runtime PM.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Peter Chen,
On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote:
Hi,
After adding IC fixes bits, some PHY bugs are fixed by
IC logic.
Can you please elaborate what those bits do exactly ? They seem like a
magic stuff to me thus far, which is not exactly helpful . I
Dear Peter Chen,
On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote:
Dear Peter Chen,
Add notify_suspend and notify_resume according to different SoCs.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 73
+ HW_USBPHY_CTRL_SET);
+ /* Enable IC solution */
+ if (is_mx6q_phy(mxs_phy) || is_mx6sl_phy(mxs_phy))
+ writel(BM_USBPHY_IP_FIX, base + HW_USBPHY_IP_SET);
+
return 0;
}
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Dear Peter Chen,
Add notify_suspend and notify_resume according to different SoCs.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 73
+ 1 files changed, 73
insertions(+), 0 deletions(-)
diff --git
Dear Peter Chen,
When we need the PHY can be waken up by external signals,
we can call this API. Besides, we call mxs_phy_disconnect_line
at this API to close the connection between USB PHY and
controller, after that, the line state from controller is SE0.
Once the PHY is out of power,
, this might needs some rewording. I didn't understand the reason for this
prop before I checked the 12/12 patch.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
init as late_initcall may be a
moderate solution.
Signed-off-by: Peter Chen peter.c...@freescale.com
Seems this tries to paper over an issue with module dependencies , no?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
() returns -EISNAM unconditionally. That's rather strange.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
afraid I have not updated my tree with mx28 updates.
Just curious, how do you boot the linux kernel on your EVK? Do you use imx
bootlets or uboot (which one, mainline?) or even some other setup ?
[...]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb
Dear Peter Chen,
On Tue, Sep 10, 2013 at 10:18:04AM +0200, Marek Vasut wrote:
Dear Peter Chen,
On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote:
Dear Peter Chen,
Please see my commit log, the mx6sl-phy has some improvements compared
to mx6q-phy.
But they're
Dear Peter Chen,
On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote:
Dear Peter Chen,
With the auto setting, the PHY's clock and power can be
recovered correctly from low power mode, it is ganranteed by IC logic.
Besides, we enable the IC fixes for this PHY at mx6
@@
/*
- * Copyright 2012 Freescale Semiconductor, Inc.
+ * Copyright 2012-2013 Freescale Semiconductor, Inc.
* Copyright (C) 2012 Marek Vasut ma...@denx.de
* on behalf of DENX Software Engineering GmbH
*
@@ -29,8 +29,17 @@
#define HW_USBPHY_CTRL_SET 0x34
#define
, but not on mx6.
Will try tomorrow on mx6q-sabresd.
Does OTG work for you on MX28 ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
anyway.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-names = default;
pinctrl-0 = pinctrl_usdhc1_2;
However, I am not able to get USB ether to work.
Any suggestions?
Are you not missing usbmisc or vbus regulator ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
: https://github.com/hzpeterchen/linux-usb.git
Patchset:
Tested-by: Marek Vasut ma...@denx.de
on two STMP3780-based boards (not yet mainline) and two MX28-based boards.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Dear Peter Chen,
On Thu, Jul 25, 2013 at 07:55:23AM +0200, Marek Vasut wrote:
Hi Peter,
I have not tried the manual switching, but first, you need to close
your vbus supply.
I think we can close this issue, I will now be also getting MX28EVK.
Thanks for all your help!
Great
Hi Peter,
On Mon, Jul 22, 2013 at 03:40:32AM +0200, Marek Vasut wrote:
Dear Peter Chen,
On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote:
Hi Peter,
On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote:
Hi Peter,
On Fri, Jul 12, 2013
Hi Peter,
On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote:
Hi Peter,
On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote:
Hi Peter,
On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote:
Hi Peter,
This patchset adds tested otg
Dear Peter Chen,
On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote:
Hi Peter,
On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote:
Hi Peter,
On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote:
Hi Peter,
On Thu, Jul 11, 2013
Hi Peter,
On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote:
Hi Peter,
On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote:
Hi Peter,
This patchset adds tested otg id switch function and
vbus connect and disconnect detection for chipidea driver
)
IS_NONEXISTENT , no?
[..]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
peterchen
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Peter Chen,
On Thu, Jul 11, 2013 at 05:36:10PM +0200, Marek Vasut wrote:
Dear Peter Chen,
Since we need otgsc to know vbus's status at some chipidea
controllers even it is peripheral-only mode. Besides, some
SoCs (eg, AR9331 SoC) don't have otgsc register even
Hi Peter,
On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote:
Hi Peter,
This patchset adds tested otg id switch function and
vbus connect and disconnect detection for chipidea driver.
And fix kinds of bugs found at chipidea drivers after enabling
id and vbus detection
, thanks.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Peter,
-Original Message-
From: Marek Vasut [mailto:ma...@denx.de]
Sent: Sunday, July 07, 2013 9:10 AM
To: Chen Peter-B29397
Cc: shawn@linaro.org; Michael Grzeschik; maxime.ripard@free-
electrons.com; Hector Palacios; linux-usb@vger.kernel.org;
s.ha...@pengutronix.de
of your otg vbus pin.
It's 2.5 volt for me. What am I supposed to observe happening there?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
on it
from next week.
Ok then, I won't interfere.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the voltage of your otg vbus pin.
Ok, I see it's 2.25 volts after I disconnect the microB-A thing . I should see
0.8V constantly with nothing connected on the port?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
? Is anyone working on it? I'd hate to stomp on anyones' efforts,but
I'd also like to see this mess sorted out.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Dear Fabio Estevam,
On Tue, Jun 25, 2013 at 11:23 AM, Fabio Estevam feste...@gmail.com wrote:
On Mon, Jun 24, 2013 at 10:51 AM, Marek Vasut ma...@denx.de wrote:
Fabio, can you possibly test on MX23EVK please?
I never used USB gadget with chipidea driver.
Could you please explain
in U-Boot too, but the
driver in
U-Boot is very minimalistic.
You mean, the larger data transfer with USB peripheral mode is ok at
u-boot? but it can't work at Linux Kernel?
Yes, but the U-Boot driver is completely different beast.
Best regards,
Marek Vasut
--
To unsubscribe from this list
, but the driver
in
U-Boot is very minimalistic.
Shawn, marek reported the udc function at mx23 works abnormal, but it works
good at mx28. Have you tried mx23 udc recently?
Fabio, can you possibly test on MX23EVK please?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line
on a different MX23-based board for me. This other board I
tried has mDDR DRAM and the DRAM is operating correctly. The 96MHz thing people
complained about in the Olimex forum is resolved now.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb
/topic/usb-peterchen
Is anyone planning to work on this stuff and start pushing it mainline or is
this effort stalled completely? What is it that's missing before these can be
applied?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Dear Michael Grzeschik,
Hi Marek,
On Fri, Jun 21, 2013 at 01:26:10PM +0200, Marek Vasut wrote:
Hi,
Hi,
On Wed, May 29, 2013 at 08:07:55AM +, Chen Peter-B29397 wrote:
Indeed, I've been using the patchset Add tested id switch and vbus
connect detect support
Hi,
Dear Michael Grzeschik,
Hi Marek,
On Fri, Jun 21, 2013 at 01:26:10PM +0200, Marek Vasut wrote:
Hi,
Hi,
On Wed, May 29, 2013 at 08:07:55AM +, Chen Peter-B29397 wrote:
Indeed, I've been using the patchset Add tested id switch and
vbus connect detect
Dear Sachin Kamat,
fixing CC here
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Marek Vasut ma...@denx.de
---
drivers/usb/phy/phy-mxs-usb.c |2
Dear Peter Chen,
[...]
+
+#define CI_VBUS_STABLE_TIMEOUT 500
Shall we not change this to static const int instead ?
[...]
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1371,6 +1371,7 @@ static int ci13xxx_vbus_session(struct usb_gadget
*_gadget, int is_active)
Dear Jiri Kosina,
On Wed, 21 Nov 2012, Marek Vasut wrote:
diff --git a/drivers/hid/usbhid/hid-quirks.c
b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -101,6 +101,7 @@ static
Dear Jiri Kosina,
On Sun, 5 Aug 2012, Marek Vasut wrote:
diff --git a/drivers/hid/usbhid/hid-quirks.c
b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -101,6 +101,7 @@ static const struct
Dear Peter Chen,
[...]
+static void ci_wait_vbus_stable(struct ci13xxx *ci, bool low)
+{
+ unsigned long timeout;
+ u32 otgsc = hw_read(ci, OP_OTGSC, ~0);
+
+ timeout = jiffies + CI_WAIT_VBUS_STABLE_TIMEOUT;
+
+ if (low) {
+ while (otgsc OTGSC_BSV) {
+
Dear Peter Chen,
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci.h |2 +
Dear Richard Zhao,
You know, commit message would be nice to have.
Signed-off-by: Richard Zhao richard.z...@freescale.com
Otherwise
Reviewed-by: Marek Vasut ma...@denx.de
---
drivers/usb/chipidea/core.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers
Dear Fabio Estevam,
Hi Marek,
On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut ma...@denx.de wrote:
+#define MXY_PHY_ENHOSTDISCONDETECT_DELAY 250
+
Why 250 what unit? ? :)
It is 250 ms. We found this one to be a safe value to enable
ENHOSTDISCONDETECT in our tests
Dear Jiri Kosina,
On Sun, 5 Aug 2012, Marek Vasut wrote:
The Freescale i.MX28 BootROM USB recovery mode implements the USB HID
protocol, yet the global item tag report size is 128. Linux checks if
this is 96 as of now, see [1]. This causes Linux to refuse to communicate
with this device
the chip
was completely deaf (no messages in kernel log).
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
://bbs.archlinux.org/viewtopic.php?pid=1141340
[4] http://git.bfuser.eu/?p=marex/mxsldr.git;a=summary
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Chen Peter b29...@freescale.com
Cc: Greg KH g...@kroah.com
Cc: Jiri Kosina jkos...@suse.cz
---
drivers/hid/hid-core.c |2 +-
1 file changed, 1 insertion(+), 1
The USB recovery mode present in i.MX28 ROM emulates USB HID.
It needs this quirk to behave properly.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Chen Peter b29...@freescale.com
Cc: Greg KH g...@kroah.com
Cc: Jiri Kosina jkos...@suse.cz
---
drivers/hid/hid-ids.h |3 +++
drivers
}, { 0, 0 }
OT: btw. the comment mentioned the list should be sorted, yet it's not so for a
while. Maybe a sorting patch would be favored?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
for fixing with proper #defined value.
[...]
The rest of the patches looks OK, you can add my Reviewed-By: ma...@denx.de
to
those. This one though will need further investigation.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
Richard
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
90 matches
Mail list logo
