Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-15 Thread Martin K. Petersen
appear to be a regular SATA drive behind a USB bridge. Have you tried to issue a DSM TRIM command via ATA passthrough? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-14 Thread Martin K. Petersen
T470s), it _does_ show "UAS". Refer the arrow below: Do you get different sg_readcap -l output when accessing it in UAS mode? I.e. is lbpme=1? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bod

Re: [PATCH 13/15] scsi: make device_type const

2017-08-25 Thread Martin K. Petersen
Bhumika, > Make these const as they are only stored in the type field of a device > structure, which is const. Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb&q

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-09 Thread Martin K. Petersen
>>>>> "Oliver" == Oliver Neukum <oneu...@suse.com> writes: Oliver> On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: >> >>>>> "Oliver" == Oliver Neukum <oneu...@suse.com> writes: >> Oliver> Some SATA to US

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-18 Thread Martin K. Petersen
Oliver> synchronize caches. That causes data loss when the drive is Oliver> powered down. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb&qu

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-15 Thread Martin K. Petersen
hey are false. Can't you just blacklist the mode select on the device in question? Something like: if (us->fflags & US_FL_ALWAYS_SYNC) { sdev->skip_ms_page_3f = 1; sdev->skip_ms_page_8 = 1; sdev->wce_default_on = 1; }

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-10 Thread Martin K. Petersen
unsigned no_dif:1; /* T10 PI (DIF) should be disabled */ unsigned broken_fua:1; /* Don't set FUA bit */ unsigned lun_in_cdb:1; /* Store LUN bits in CDB[1] */ I must be missing something. How is always_sync different from just setting wce_default_on? -- Ma

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-08 Thread Martin K. Petersen
Oliver> synchronize caches. That causes data loss when the drive is Oliver> powered down. Alan? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-15 Thread Martin K. Petersen
>>>>> "Hans" == Hans de Goede <hdego...@redhat.com> writes: Hans> Oliver Neukum is taking over uas maintainership from me and Gerd Hans> Hoffmann. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [-next] BUG_ON in scsi_target_destroy()

2016-04-15 Thread Martin K. Petersen
, we will try to remove a James> running target when it has no more scsi devices left on it. So James> the correct patch should be to make the BUG_ON see this: Commit amended. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubs

Re: optimal io size / custom alignment

2015-06-20 Thread Martin K. Petersen
nature. We don't know whether a discovered device is a simple drive. And once again: The whole point of the queue limit is to have an common abstraction for all block devices. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-usb in

Re: optimal io size / custom alignment

2015-06-18 Thread Martin K. Petersen
by blacklisting them. I suggest you try to find a way we can reliably identify your UAS devices. If there is a common pattern, we can entertain adding a workaround. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: optimal io size / custom alignment

2015-06-16 Thread Martin K. Petersen
shouldn't bind values from totally Tom different source (raid stripe vs vpd limit) to the same variable. RAID devices communicate the stripe width through the Block Limits VPD. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Martin K. Petersen
. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Martin K. Petersen
. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-30 Thread Martin K. Petersen
in the stable Alan kernels as soon as possible. James? [PATCH] SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_page() call. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
the following instead? -- Martin K. Petersen Oracle Linux Engineering SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_page() call. Signed-off-by: Martin K. Petersen

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
Alan == Alan Stern st...@rowland.harvard.edu writes: Alan In the case of these bug reports, the scsi_report_opcode() call Alan returns -EINVAL. Oh, right. Because I actually do an explicit SCSI version check in scsi_report_opcode(). That's OK, then... -- Martin K. Petersen Oracle Linux