Re: [PATCH v6 05/99] xarray: Add definition of struct xarray

2018-01-24 Thread Paul Bolle
USERINCLUDE variable, which is actually part of the LINUXINCLUDE variable, but split off to make things confusing.) Why do you need to include linux/kconfig.h here? > #include > #include Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-usb&quo

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Paul Bolle
line here, things look neater. +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_AUTHOR(Peter Hong peter_h...@fintek.com.tw); +MODULE_AUTHOR(Tom Tsai tom_t...@fintek.com.tw); +MODULE_LICENSE(GPL); Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

2015-05-27 Thread Paul Bolle
beyond what anyone sane cares for: usb_find_interface_driver() was removed in v2.5.36 through a patch titled USB: Convert the core code to use struct device_driver.. So, IMHO it would be relevant to remove this obselete function from kernel mainline. Thanks, Paul Bolle -- To unsubscribe from

Re: [RFC][PATCH v2 05/13] usb: otg: add OTG core

2015-04-15 Thread Paul Bolle
. So I think the loading of that module (triggered by loading another module that uses one of the exported symbols, I suppose) taints the kernel. Am I correct? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-11 Thread Paul Bolle
the + * GNU General Public License for more details. + */ This states the license is GPL v2 or later. +MODULE_LICENSE(GPL v2); So you probably want MODULE_LICENSE(GPL); here. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Paul Bolle
On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: As always, comments are welcome. Are nits welcome too? +MODULE_LICENSE(GPLv2); You probably meant

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-19 Thread Paul Bolle
On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: As always, comments are welcome. Are nits welcome too? +MODULE_LICENSE(GPLv2); You probably meant MODULE_LICENSE(GPL v2) Didn't that trigger a warning or error? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-12 Thread Paul Bolle
implementation to attach it to the at91sam9rl-udc compatible string. Add new compatible strings to avoid executing at91sam9rl erratum handling on other SoCs. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com Paul

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-12 Thread Paul Bolle
nothing at all about all that! Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-04 Thread Paul Bolle
be educated here. Why is a patch that allows the users of ARCH_S5PV210 to set USB_EHCI_EXYNOS or USB_OHCI_EXYNOS - which they apparently need - for a v3.17.y kernel, not a stable issue? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-04 Thread Paul Bolle
that users of PLAT_S5P, who could set USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Bolle
On Thu, 2014-10-23 at 10:05 -0500, Dinh Nguyen wrote: On 10/22/2014 03:27 PM, Paul Bolle wrote: On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: Well, CONFIG_USB enables the host stack that is needed by the DWC2 driver, without CONFIG_USB, the DWC2 driver will not be able to build

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Bolle
On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: On 10/20/2014 02:42 PM, Paul Bolle wrote: (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig) even if USB is _not_ set. But USB_DCW2 still depends on USB. Why is that?) Because USB is for Host-Side support. DWC2

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-20 Thread Paul Bolle
USB_DWC2_DEBUG bool Enable Debugging Messages help diff --git a/drivers/usb/dwc2/Makefile b/drivers/usb/dwc2/Makefile index b73d2a5..2175d93 100644 Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

[PATCH 0/4] Remove optional dependencies on PLAT_S5P

2014-10-06 Thread Paul Bolle
. If it turns out that they should actually be replaced by another symbol, as was said in a reply to my first message but never done, this series can be used as a reference for the places that need fixing. This series is done on top of next-20141003. It is tested by grepping the tree only. Paul Bolle

[PATCH 4/4] usb: host: Remove optional dependencies on PLAT_S5P

2014-10-06 Thread Paul Bolle
Commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code) removed the Kconfig symbol PLAT_S5P. Remove two optional dependencies on that symbol from this Kconfig file too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- drivers/usb/host/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

2014-10-04 Thread Paul Bolle
early (ie, in linux-next) and for how Valentin hopes to automate that properly. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

2014-10-03 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl Fixes: 905e300e1043 (USB: host: st: fix ehci/ohci driver selection) --- drivers/usb/host/ehci-st.o actually builds (on x86_64. that is) so there's no _obvious_ reason not to fix this typo. drivers/usb/host/Makefile | 2 +- 1 file changed, 1 insertion

Re: [PATCH] USB: host: st: fix ehci/ohci driver selection

2014-09-30 Thread Paul Bolle
) += ehci-st.o ohci-st.o Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES?

2014-07-04 Thread Paul Bolle
do that? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: remove CONFIG_USB_PERSIST from Documentation

2014-07-02 Thread Paul Bolle
On Tue, 2014-06-24 at 13:19 -0400, Alan Stern wrote: On Tue, 24 Jun 2014, Paul Bolle wrote: On Tue, 2014-06-24 at 10:25 -0400, Alan Stern wrote: Also, that Later kernels thing has already arrived. I believe it was implemented in 2.6.35. How does the kernel currently call

[PATCH v2] Documentation: sysfs-bus-usb: update power/persist description

2014-07-02 Thread Paul Bolle
. It is not needed to understand this file anyhow. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- v2: incorporate Alan's feedback. The clearest way to do that was to not mention the default value at all. Trying to do handle the default correctly made the text way too complicated. I hope Alan agrees

[PATCH] Documentation: sysfs-bus-usb: update power/persist description

2014-06-24 Thread Paul Bolle
There's no power/persist file for hubs. And CONFIG_USB_PERSIST was removed in v2.6.26. Update the description of power/persist accordingly. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- I don't know anything about USB-Persist. Could Greg and Alan please check whether the new description does

[PATCH] USB: remove CONFIG_USB_PERSIST from Documentation

2014-06-24 Thread Paul Bolle
CONFIG_USB_PERSIST was removed in v2.6.26. Remove a reference to it from Documentation. That reference was a bit odd to begin with. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- [...] under certain circumstances [...]? Is that about USB_QUIRK_RESET_RESUME? Anyhow, I feel this paragraph needs

Re: [PATCH] Documentation: sysfs-bus-usb: update power/persist description

2014-06-24 Thread Paul Bolle
that they will morph or change modes when reset). If the symbol is not set then persist is enabled by default only for hubs. Thanks for the documentation update. You do expect a v2 updated to reflect your comments, don't you? Paul Bolle -- To unsubscribe from this list: send the line

Re: [PATCH] USB: remove CONFIG_USB_PERSIST from Documentation

2014-06-24 Thread Paul Bolle
actually knowing why they can be dropped. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: core: remove the Kconfig entry for USB_DEBUG

2014-05-28 Thread Paul Bolle
. Are patches to remove or replace these references to CONFIG_USB_DEBUG queued somewhere? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: gadget: rename CONFIG_USB_GADGET_PXA25X

2014-05-26 Thread Paul Bolle
. Rename that last macro too now. Fixes: 193ab2a60700 (usb: gadget: allow multiple gadgets to be built) Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. drivers/usb/gadget/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/inode.c b/drivers/usb

[PATCH] MIPS: MSP71xx: remove checks for two macros

2014-05-22 Thread Paul Bolle
Since v2.6.39 there are checks for CONFIG_MSP_HAS_DUAL_USB and checks for CONFIG_MSP_HAS_TSMAC in the code. The related Kconfig symbols have never been added. These checks have evaluated to false for three years now. Remove them and the code they have been hiding. Signed-off-by: Paul Bolle pebo

Re: [PATCH v6 10/17] ARM: mvebu: add USB3 support for Armada 38x

2014-05-19 Thread Paul Bolle
USB_ARCH_HAS_XHCI was dropped in commit b797b76fb464 (usb: host: remove USB_ARCH_HAS_?HCI). Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP

2014-05-16 Thread Paul Bolle
Felipe, On Thu, 2014-05-15 at 18:12 -0500, Felipe Balbi wrote: On Thu, May 15, 2014 at 10:55:45PM +0200, Paul Bolle wrote: diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c index 65d2acb31498..57092bc7f4f1 100644 --- a/arch/arm/mach-omap1/board-h2.c +++ b/arch

[PATCH v2] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP

2014-05-16 Thread Paul Bolle
since v3.1. And, since we're touching this code, use the IS_ENABLED() macro, so things will now (hopefully) also work if USB_OMAP is modular. Fixes: 193ab2a60700 (usb: gadget: allow multiple gadgets to be built) Signed-off-by: Paul Bolle pebo...@tiscali.nl --- v2: us IS_ENABLED() as Felipe requested

[PATCH] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP

2014-05-15 Thread Paul Bolle
since v3.1. Fixes: 193ab2a60700 (usb: gadget: allow multiple gadgets to be built) Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Also untested. It seems efficient to also include the change to phy-isp1301-omap.c in this patch (ie, not ship that as a separate patch). arch/arm/mach-omap1/board-h2.c

[PATCH] usb: musb: tusb: remove dead code

2014-05-04 Thread Paul Bolle
musb_in_tusb() is always set to 0, because CONFIG_USB_TUSB6010 is never set (it should have been CONFIG_USB_MUSB_TUSB6010). But musb_in_tusb() is unused anyway, so remove a few lines of dead code. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Usb, musb, and tusb! Is somebody sneaking nursery

Re: [PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv_u3d

2014-04-17 Thread Paul Bolle
by the automated tests people appear to run, while work is done on adding MMP3 support. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv_u3d

2014-04-15 Thread Paul Bolle
when it was added. In commit 60630c2eabd4 (usb: gadget: mv_u3d: drop ARCH dependency) MV_U3D_PHY was made depended directly on CPU_MMP3. That kept it unbuildable, of course. Remove this driver. It can be re-added once its dependencies are part of the tree. Signed-off-by: Paul Bolle pebo

Re: [PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv_u3d

2014-04-15 Thread Paul Bolle
what's already in-tree ? Were any of the reasons I gave for removing this driver incorrect? Has it actually ever been possible to build it? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

2014-02-16 Thread Paul Bolle
USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made obsolete in v3.11. They have not been used ever since. Setting them has no effect. They can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep. Note that the comment in this Kconfig file

[PATCH 2/2] usb: host: remove selects of USB_ARCH_HAS_?HCI

2014-02-16 Thread Paul Bolle
USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were just removed. Selecting them is a nop. The select statements for these symbols can be removed too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep. Sending this as a few separate patches to the maintainers

Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 15:02 -0500, Alan Stern wrote: On Sun, 16 Feb 2014, Paul Bolle wrote: Note that the comment in this Kconfig file (that is also removed) suggests to first remove the select statements for these symbols and then the symbols themselves. But I think it makes more sense

[PATCH] USB: ELAN: Remove useless default M lines

2014-02-11 Thread Paul Bolle
by default, let's just drop these lines (that basically do nothing). Signed-off-by: Paul Bolle pebo...@tiscali.nl --- This patch deserves a Reported-by: Martin Walch walch.mar...@web.de line, but that apparently requires Martin's permission. drivers/usb/host/Kconfig | 1 - drivers/usb/misc/Kconfig

Re: [PATCH 01/28] Remove CPU_MMP3

2014-02-11 Thread Paul Bolle
On Tue, 2014-02-11 at 13:30 -0800, Greg Kroah-Hartman wrote: On Sun, Feb 09, 2014 at 07:47:39PM +0100, Richard Weinberger wrote: The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger rich...@nod.at Acked-by: Paul Bolle pebo...@tiscali.nl --- drivers/usb/phy

Re: [PATCH 01/28] Remove CPU_MMP3

2014-02-09 Thread Paul Bolle
text (not displayed here) too, I'd guess. Aside from that: Acked-by: Paul Bolle pebo...@tiscali.nl Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] usb: phy: Quiet unable to find transceiver message

2014-02-03 Thread Paul Bolle
. Is a patch to downgrade this message to dev_dbg() - from Josh, Felipe or someone else - queued somewhere? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] usb: phy: Quiet unable to find transceiver message

2014-02-03 Thread Paul Bolle
On Mon, 2014-02-03 at 11:04 -0500, Alan Stern wrote: On Mon, 3 Feb 2014, Paul Bolle wrote: This message cab still be seen when booting v3.14-rc1. Is a patch to downgrade this message to dev_dbg() - from Josh, Felipe or someone else - queued somewhere? http://marc.info/?l=linux-usbm

[PATCH] usb: phy: remove CONFIG_USB_OTG_UTILS once more

2013-05-13 Thread Paul Bolle
The Kconfig symbol USB_OTG_UTILS was removed in the v3.10 merge window, in commit fd89149875 (usb: phy: remove CONFIG_USB_OTG_UTILS). But that symbol popped up again in a few places. Remove it there too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. drivers/staging/dwc2/Kconfig | 1

[PATCH] usb: gadget: net2272: finally convert CONFIG_USB_GADGET_NET2272_DMA

2013-03-20 Thread Paul Bolle
-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. I'll explain - at some length - why this patch needs testing. 1) The driver for the PLX NET2272 USB device controller and support for its external DMA controller were added in v3.1-rc1, see commit ceb80363b2ec1091dffd78064771e3d4679f69c7 (USB: net2272

Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

2013-03-14 Thread Paul Bolle
On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote: On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote: diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 5a0c541..c65b5e2 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig

[PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

2013-03-11 Thread Paul Bolle
The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of v2.6.36, as can be seen in commit 267ecec95f7d215d2da38252640b06198515acc3 (Removing dead MACH_OMAP_H4_OTG). Remove its last trace now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with make ARCH=arm menuconfig

[PATCH] usb: gadget: get rid of two outdated selects

2013-03-08 Thread Paul Bolle
The Kconfig symbols USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED were removed in commit 85b8614d722389202af298e1bf8a599c431fef19 (usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED). These two select statements somehow escaped cleaning up. Get rid of these too. Signed-off-by: Paul Bolle pebo