Re: [PATCH v2 6/6] UDC: Add Synopsys UDC Platform driver

2017-02-21 Thread Scott Branden
Hi Raviteja, One compatibility string to add. Comment inline On 17-02-21 03:43 AM, Raviteja Garimella wrote: This patch adds platform driver support for Synopsys UDC. A new driver file (snps_udc_plat.c) is created for this purpose where the platform driver registration is done based on OF

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Scott Branden
Hi Raviteja, updates inline On 17-02-21 03:43 AM, Raviteja Garimella wrote: The device node is used for UDCs integrated into Broadcom's iProc family of SoCs'. The UDC is based on Synopsys Designware Cores AHB Subsystem USB Device Controller IP. Signed-off-by: Raviteja Garimella

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
On 17-01-19 01:55 PM, Ray Jui wrote: On 1/19/2017 12:17 PM, Florian Fainelli wrote: On 01/19/2017 12:07 PM, Scott Branden wrote: Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: This patch adds device tree bindings documentation for Synopsys USB

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: This patch adds device tree bindings documentation for Synopsys USB device controller platform driver. Bindings describe h/w, not drivers. Signed-off-by: Raviteja Garimella

Re: [PATCH V3 RESEND] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-05-24 Thread Scott Branden
Hi Rafal, some comments in line. On 16-05-22 03:09 PM, Rafał Miłecki wrote: > Northstar is a family of SoCs used in home routers. They have USB 2.0 > and 3.0 controllers with PHYs that need to be properly initialized. > This driver provides PHY init support in a generic way and can be bound >

Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-23 Thread Scott Branden
On 15-09-23 01:18 AM, John Youn wrote: On 9/23/2015 1:11 AM, John Youn wrote: On 9/23/2015 12:36 AM, Scott Branden wrote: Hi John, Could you please review the v3 Patch. I believe we have address all of your comments? Yes I've been meaning to test it on our platforms. I should be able

Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-23 Thread Scott Branden
Hi John, Could you please review the v3 Patch. I believe we have address all of your comments? On 15-09-10 06:13 PM, Scott Branden wrote: This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed

[PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-10 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Changes from v2: - created s2c_hsotg_chage_ep_iso_parity function to call function in 3 places in code - used hsotg->num_of_eps

[PATCH v3 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-09-10 Thread Scott Branden
riodic Transfer interrupt to toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik <rba...@broadcom.com> Reviewed-by: Abhinav Ratna <ara...@broadcom.com> Reviewed-by: Srinath Mannam <srinath.man...@broadcom.com> Signed-off-

[PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-08-31 Thread Scott Branden
riodic Transfer interrupt to toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik <rba...@broadcom.com> Reviewed-by: Abhinav Ratna <ara...@broadcom.com> Reviewed-by: Srinath Mannam <srinath.man...@broadcom.com> Signed-off-

[PATCH v2 0/1] USB DWC2 parity fix in isochronous mode

2015-08-31 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Changes from v1: - Address code review comments as per previous responses: - renamed parity_set to has_correct_parity and

[PATCH 0/1] USB DWC2 parity fix in isochronous mode

2015-08-18 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Roman Bacik (1): usb: dwc2: gadget: parity fix in isochronous mode drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c

[PATCH 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-08-18 Thread Scott Branden
Transfer interrupt to toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik rba...@broadcom.com Reviewed-by: Abhinav Ratna ara...@broadcom.com Reviewed-by: Srinath Mannam srinath.man...@broadcom.com Reviewed-by: Scott Branden sbran

Re: [PATCH 1/2] usb: ohci-platform: add support for multiple phys per controller

2014-12-10 Thread Scott Branden
On 14-12-05 01:28 PM, arun.ramamur...@broadcom.com wrote: From: Arun Ramamurthy arunr...@broadcom.com Added support for cases where one controller is connected to multiple phys Signed-off-by: Arun Ramamurthy arunr...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott