Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Sergei Shtylyov
Hello! On 10/23/2019 09:58 PM, Andy Shevchenko wrote: >>> + int error; >>> + >>> + error = pm_runtime_get(cdd->ddev.dev); >>> + if (error < 0) { >> >>I'd call that variable 'status', comparison (error < 0) just doesn't look >> right. >> If it was *if* (error), it would have been

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Sergei Shtylyov
Hello! On 10/23/2019 06:31 PM, Tony Lindgren wrote: > Yegor Yefremov reported that musb and ftdi > uart can fail for the first open of the uart unless connected using > a hub. > > This is because the first dma call done by musb_ep_program() must wait > if cppi41 is PM runtime suspended. Otherwi

Re: [PATCH 2/7] usb: musb: omap2430: Wait on enable to avoid babble

2019-10-10 Thread Sergei Shtylyov
Hello! On 10.10.2019 0:21, Tony Lindgren wrote: We can babble interrupt if we attempt to switch to USB host mode too ^ verb missing? soon after enabling musb. Let's fix the issue by waiting a bit in runtime_resume. Cc: Jacopo Mondi Cc: Marcel Partap Cc: Merlijn Wajer Cc: Michael

Re: [PATCH v2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-10 Thread Sergei Shtylyov
Hello! On 10.08.2019 0:37, Simon Horman wrote: For consistency with the naming of (most) other documentation files for DT bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral documentation file from renesas,usb3.txt to renesas,usb3-peri.txt This refines a recent rename from rene

Re: [PATCH v2 04/12] usb: gadget: aspeed: Improve debugging when nuking

2019-07-12 Thread Sergei Shtylyov
On 12.07.2019 12:01, Sergei Shtylyov wrote: When nuking requests, it's useful to display how many were actually nuked. It has proven handy when debugging issues where EP0 went in a wrong state. Signed-off-by: Benjamin Herrenschmidt ---   drivers/usb/gadget/udc/aspeed-vhub/core.

Re: [PATCH v2 04/12] usb: gadget: aspeed: Improve debugging when nuking

2019-07-12 Thread Sergei Shtylyov
On 12.07.2019 5:53, Benjamin Herrenschmidt wrote: When nuking requests, it's useful to display how many were actually nuked. It has proven handy when debugging issues where EP0 went in a wrong state. Signed-off-by: Benjamin Herrenschmidt --- drivers/usb/gadget/udc/aspeed-vhub/core.c | 7

Re: [PATCH 02/10] usb: gadget: aspeed: Cleanup EP0 state on port reset

2019-07-06 Thread Sergei Shtylyov
Hello! On 06.07.2019 3:53, Benjamin Herrenschmidt wrote: Otherwise, we can have a stale state after a disconnect and reconnect causing errors on the first SETUP packet to the device. Signed-off-by: Benjamin Herrenschmidt [...] diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c b/drivers

Re: [PATCH] gpss: core: no waiters left behind on deregister

2019-06-25 Thread Sergei Shtylyov
Hello! The subject has gpss ISO gnss. You hardly meant the General Purpose System Simulation. :-) On 24.06.2019 11:33, Oliver Neukum wrote: If you deregister a device you need to wake up all waiters as there will be no further wakeups. Signed-off-by: Oliver Neukum --- drivers/gnss/core.

Re: [PATCH] ARM: imx25: provide a fixed regulator for usb phys

2019-06-25 Thread Sergei Shtylyov
Hello! On 25.06.2019 13:04, Uwe Kleine-König wrote: The usb phys are internal to the SoC and so it their 5V supply. With s/it/is/? this regulator added explicitly the following (harmless) boot messages go away: usb_phy_generic usbphy:usb-phy@0: usbphy:usb-phy@0 supply vcc not f

Re: [PATCH v4 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support

2019-06-17 Thread Sergei Shtylyov
Hello! On 06/17/2019 04:13 AM, Peter Chen wrote: [...] >>> Signed-off-by: Peter Chen >>> --- >>> arch/arm/boot/dts/imx7ulp.dtsi | 28 >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi >>> b/arch/arm/boot/dts/imx7ulp.dtsi inde

Re: [PATCH v4 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support

2019-06-15 Thread Sergei Shtylyov
On 14.06.2019 12:35, Peter Chen wrote: Add imx7ulp USBOTG1 support. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx7ulp.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-06-01 Thread Sergei Shtylyov
Hello! On 01.06.2019 10:52, Marco Zatta wrote: This patch fixes the chipmunk-like voice that manifets randomly when using the integrated mic of the Logitech Webcam HD C270. The issue was solved initially for this device by commit 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintro

Re: [PATCH 1/1] usb: chipidea: udc: workaround for endpoint conflict issue

2019-05-30 Thread Sergei Shtylyov
Hello! On 30.05.2019 9:45, Peter Chen wrote: An endpoint conflict occurs when the USB is working in device mode during an isochronous communication. When the endpointA IN direction is an isochronous IN endpoint, and the host sends an IN token to endpointA on another device, then the OUT transac

Re: [PATCH 1/1] usb: chipidea: udc: workaround for endpoint conflict issue

2019-05-27 Thread Sergei Shtylyov
On 27.05.2019 12:44, Peter Chen wrote: An endpoint conflict occurs when the USB is working in device mode during an isochronous communication. When the endpointA IN direction is an isochronous IN endpoint, and the host sends an IN token to endpointA on another device, then the OUT transaction ma

Re: [PATCH 1/1] usb: chipidea: udc: workaround for endpoint conflict issue

2019-05-27 Thread Sergei Shtylyov
On 27.05.2019 10:42, Peter Chen wrote: An endpoint conflict occurs when the USB is working in device mode during an isochronous communication. When the endpointA IN direction is an isochronous IN endpoint, and the host sends an IN token to endpointA on another device, then the OUT transaction ma

Re: [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document

2019-05-15 Thread Sergei Shtylyov
Hello! On 05/15/2019 03:09 PM, Biju Das wrote: > Add device tree binding document for TI HD3SS3220 Type-C DRP port > controller driver. > > Signed-off-by: Biju Das > Reviewed-by: Rob Herring > --- > V5-->V6 > * No change. > V4-->V5 > * No Change. > V3-->V4 > * No Change. > V2-->V3 > *

Re: [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1

2019-05-15 Thread Sergei Shtylyov
Hello! On 15.05.2019 10:35, Geert Uytterhoeven wrote: Document the USB_X1 input and add clock-names to identify functional and USB_X1 clocks. Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt +++ b/Documentation

Re: [PATCH v2 05/15] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG

2019-05-11 Thread Sergei Shtylyov
On 10.05.2019 16:55, Chris Brandt wrote: + } else { + /* Not OTG, so dr_mode should be set in PHY node */ + mode = usb_get_dr_mode(channel->dev); + if (mode == USB_DR_MODE_HOST) + writel(0x, usb2_base + USB2_COMMCTRL);

Re: [PATCHv2 4/4] USB: rio500: update Documentation

2019-05-07 Thread Sergei Shtylyov
On 07.05.2019 10:38, Oliver Neukum wrote: Added the newly added limit and updated the text a bit Signed-off-by: Oliver Neukum --- Documentation/usb/rio.txt | 54 +-- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/Documentation/usb

Re: [PATCH 2/3] usb: typec: fusb302: Implement start_srp_connection_detect

2019-04-14 Thread Sergei Shtylyov
Hello! On 13.04.2019 23:39, Hans de Goede wrote: When in single role port mode, we most start single-role toggling to Must, perhaps? get an interrupt when a device / cable gets plugged into the port. This commit implements the tcpc_dev start_srp_connection_detect callback for this. Sig

Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Sergei Shtylyov
Hello! On 18.02.2019 14:23, Yu Chen wrote: This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some

Re: [PATCH -next] usb: host: oxu210hp-hcd: remove set but not used variables 'uframes, transfer_buffer_length'

2019-02-15 Thread Sergei Shtylyov
Hello! On 15.02.2019 6:17, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/oxu210hp-hcd.c: In function 'scan_periodic': drivers/usb/host/oxu210hp-hcd.c:2256:13: warning: variable 'uframes' set but not used [-Wunused-but-set-variable] drivers/usb/host/oxu210

Re: [PATCH] usb: typec: tps6598x: Check mode of operation

2019-02-14 Thread Sergei Shtylyov
On 02/14/2019 06:28 PM, Heikki Krogerus wrote: > +static int tps6598x_check_mode(struct tps6598x *tps) > +{ > + char mode[5] = { }; > + int ret; > + > + ret = tps6598x_read32(tps, TPS_REG_MODE, (void *)mode); Casting pointers to 'void *' happens automagically,

Re: [PATCH] usb: typec: tps6598x: Check mode of operation

2019-02-14 Thread Sergei Shtylyov
On 02/14/2019 03:12 PM, Heikki Krogerus wrote: >>> +static int tps6598x_check_mode(struct tps6598x *tps) >>> +{ >>> + char mode[5] = { }; >>> + int ret; >>> + >>> + ret = tps6598x_read32(tps, TPS_REG_MODE, (void *)mode); >> >>Casting pointers to 'void *' happens automagically, doesn't i?

Re: [PATCH] usb: typec: tps6598x: Check mode of operation

2019-02-14 Thread Sergei Shtylyov
Hello! On 13.02.2019 19:36, Heikki Krogerus wrote: To prevent loading of the driver when the PD controller is still in some operational mode that the driver does not support, checking the mode in driver probe callback function. TI PD controllers may be in undefined mode of operation for exampl

Re: [PATCH v3 7/9] usb: typec: Find the ports by also matching against the device node

2019-02-13 Thread Sergei Shtylyov
On 13.02.2019 10:45, Heikki Krogerus wrote: When the connections are defined in firmware, struct device_connection will have the fwnode member pointing to the device node (struct fwnode_handle) of the requested device, and the endpoint will not be used at all in that case. Acked-by: Hans de Goe

Re: [PATCH v3 1/9] platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme

2019-02-13 Thread Sergei Shtylyov
Hello! On 13.02.2019 10:45, Heikki Krogerus wrote: Adding new connections with for the muxes with new I can't parse this. :-) identifiers. The old connection are left in for now. Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Reviewed-by: Jun

Re: [PATCH] xhci: Drop superfluous initialization in xhci_queue_ctrl_tx()

2019-02-07 Thread Sergei Shtylyov
Hello! On 07.02.2019 3:03, Andrey Smirnov wrote: Simplify filed's initialization by directly assigning its final value field's. instead of initializing the variable to sero and then bitwise or-ing it. Signed-off-by: Andrey Smirnov Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-us

Re: [PATCH v2] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-30 Thread Sergei Shtylyov
Hello! On 30.01.2019 19:30, Paul Kocialkowski wrote: According to the chipidea driver bindings, the USB PHY is specified via the "phys" phandle node. However, this only takes effect for USB PHYs that use the common PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY type is

Re: [PATCH v2] usb: dwc3: gadget: Handle 0 xfer length for OUT EP

2019-01-21 Thread Sergei Shtylyov
Hello! On 01/21/2019 12:33 PM, Tejas Joglekar wrote: > For OUT endpoints, zero-length transfers require MaxPacketSize buffer as > per the DWC_usb3 programming guide 3.30a section 4.2.3.3. > > This patch fixes this by explicitly checking zero length > transfer to correctly pad up to MaxPacketSize

Re: [PATCH v1 3/6] usb: host: Stops USB controller init if PLL fails to lock

2019-01-21 Thread Sergei Shtylyov
Hello! On 21.01.2019 6:13, Yinbo Zhu wrote: From: yinbo.zhu USB erratum-A006918 workaround tries to start internal PHY inside uboot (when PLL fails to lock). However, if the workaround also fails, then USB initialization is also stopped inside Linux. Erratum-A006918 workaround failure creates

Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

2019-01-19 Thread Sergei Shtylyov
Hello! On 01/19/2019 12:29 AM, Shuah Khan wrote: > From: Shuah Khan > > Fix vhci_urb_enqueue() to print error and return error instead of > failing with WARN_ON. It's BUG_ON(). > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vhci_hcd.c | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Sergei Shtylyov
Hello! On 01/17/2019 10:15 AM, min@mediatek.com wrote: > From: Min Guo > > This adds support for MediaTek musb controller in > host, peripheral and otg mode. > > Signed-off-by: Min Guo > --- > .../devicetree/bindings/usb/mediatek,musb.txt | 43 > ++ > 1 file cha

Re: [PATCH v2,2/2] usb: chipidea: imx: set power polarity

2019-01-16 Thread Sergei Shtylyov
Hello! On 01/16/2019 01:51 PM, Philipp Puschmann wrote: > This patch adds support to set the power line polarity for i.MX6q/dl. > > To let the USB controller control the power it may be necessary to configure > the polarity of the power line. So far the polarity was configured > by Bootloader or

Re: [PATCH v2 03/10] usb: ehci-orion: avoid double PHY initialization

2019-01-11 Thread Sergei Shtylyov
Hello! On 01/11/2019 04:31 PM, Miquel Raynal wrote: > No need to initialize the PHY from the driver's probe. It is done by > the core automatically and doing it twice would increment the > phy->powercount counter to 2 instead of 1. During later suspend > operation, the counter will be decremented

Re: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by IRQ latency

2018-12-14 Thread Sergei Shtylyov
Hello! On 12/14/2018 07:32 PM, Zeng Tao wrote: > If it's a busy system, some times when we start an isoc transfer, the > framenumber get from the event buffer may be already elasped, in this Frame number? Else my spell checker trips. :-) > case, we will get all the packets dropped due to mi

Re: [PATCH 1/6] driver core: Introduce device_iommu_mapped() function

2018-12-11 Thread Sergei Shtylyov
Hello! On 12/11/2018 04:43 PM, Joerg Roedel wrote: > From: Joerg Roedel > > Some places in the kernel check the iommu_group pointer in > 'struct device' in order to find ot whether a device is > mapped by an IOMMU. > > This is not good way to make this check, as the pointer will > be moved to

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Sergei Shtylyov
On 03.12.2018 11:51, Chen Yu wrote: This patch adds binding descriptions to support the dwc3 controller on HiSilicon SoCs and boards like the HiKey960. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Signed-off-by: Yu Chen ---   .../devicetree/bindings/usb/dwc3-his

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Sergei Shtylyov
Hello! On 03.12.2018 6:45, Yu Chen wrote: This patch adds binding descriptions to support the dwc3 controller on HiSilicon SoCs and boards like the HiKey960. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Signed-off-by: Yu Chen --- .../devicetree/bindings/usb/dw

Re: [PATCH 4/4] usbnet: smsc95xx: check for csum being in last four bytes

2018-11-14 Thread Sergei Shtylyov
On 11/14/2018 02:50 PM, Ben Dooks wrote: > The manual states that the checksum cannot lie in the last DWORD of the > transmission, so add a basic check for this and fall back to software > checksumming the packet. > > This only seems to trigger for ACK packets with no options or data to > return

Re: [PATCH 2/2] usb: dwc2: gadget: Accept LPM token when TxFIFO is not empty

2018-10-30 Thread Sergei Shtylyov
Hello! On 10/30/2018 03:26 PM, Artur Petrosyan wrote: > To accept LPM token during ISOC transfers when TxFIFO > is not empty. > > Signed-off-by: Artur Petrosyan > Signed-off-by: Minas Harutyunyan > --- > drivers/usb/dwc2/gadget.c | 1 + > drivers/usb/dwc2/hw.h | 3 +++ > 2 files changed,

Re: [PATCH 03/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2018-10-27 Thread Sergei Shtylyov
On 27.10.2018 12:58, Yu Chen wrote: This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey&HiKey960 Board. Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- .../bindings/misc/hisilicon-hikey-usb.txt

Re: [PATCH 2/3] net: ethernet: Remove dummy runtime PM callbacks from Renesas drivers

2018-10-24 Thread Sergei Shtylyov
eric runtime pm callbacks") > 543f2503a956 ("PM / platform_bus: Allow runtime PM by default") > 8b313a38ecff ("PM / Platform: Use generic runtime PM callbacks directly") Wow, these are old! :-) > Signed-off-by: Jarkko Nikula > --- > Only build tested.

Re: [RFC PATCH 4/5] usb: typec: Find the ports by also matching against the device node

2018-10-24 Thread Sergei Shtylyov
Hello! On 10/24/2018 06:05 PM, Heikki Krogerus wrote: > When the connections are defined in firmware, struct > device_connection will have the fwnode member pointing to > the device node (struct fwnode_handle) of the requested > device, and the endpoint will not be used at all in that > case. >

Re: [PATCH 6/8] usbnet: smsc95xx: fix memcpy for accessing rx-data

2018-10-12 Thread Sergei Shtylyov
Hello! On 12.10.2018 11:34, Ben Dooks wrote: Change the RX code to use get_unaligned_le32() instead of the combo of memcpy and cpu_to_le32s(&var). le32_to_cpus(), actually. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions

Re: [PATCH 3/4] usbnet: smsc95xx: check for csum being in last four bytes

2018-10-02 Thread Sergei Shtylyov
Hello! On 10/2/2018 12:26 PM, Ben Dooks wrote: The manual states that the checksum cannot lie in the last DWORD of the transmission, so add a basic check for this and fall back to software checksumming the packet. This only seems to trigger for ACK packets with no options or data to return to

Re: [PATCH v2 -next] usb: typec: remove set but not used variables 'snk_ma, flags'

2018-09-29 Thread Sergei Shtylyov
Hello! On 9/29/2018 9:58 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable] drivers/usb/type

Re: [PATCH] ALSA: usb-audio: ensure that cluster header size is enough

2018-09-22 Thread Sergei Shtylyov
Hello! On 09/22/2018 04:38 PM, Dan Carpenter wrote: > I think we need a check to make sure that "hc_header.wLength" is large > enough for a struct struct uac3_cluster_header_descriptor. struct struct? :-) > Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") > Signe

Re: [PATCH 2/3] usb: host: xhci: return -ESHUTDOWN when removing hcd

2018-09-21 Thread Sergei Shtylyov
On 9/21/2018 4:48 AM, Peter Chen wrote: When we are removing HCD, the xhci_configure_endpoint may be timeout. To get rid of timeout, we'd better return before issue command. The related log message when removing HCD like below: [66.736633] usb 3-1: USB disconnect, device number 2 [66.737003] hu

Re: [PATCH 3/3] usb: host: xhci: return early for xhci_urb_dequeue when removing hcd

2018-09-21 Thread Sergei Shtylyov
On 9/21/2018 4:48 AM, Peter Chen wrote: When we are removing hcd, the stop endpoint command may be timeout. To eliminate the timeout, we'd better return early. The related log for this timeout like below: [31.208933] hub 3-1:1.0: hub_ext_port_status failed (err = -71) [31.214972] usb 3-1-port2:

Re: [PATCH] usb: typec: don't disable sink or source on initialization

2018-09-07 Thread Sergei Shtylyov
Hello! On 9/6/2018 10:26 PM, Angus Ainslie (Purism) wrote: If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled. Signed-off-by: Angus Ainslie (Purism) --- drivers/usb/typec/tcpm.c | 8 +--- 1 file changed

Re: [PATCH 01/25] tty: Change return type to void

2018-09-04 Thread Sergei Shtylyov
Hello! On 9/4/2018 5:44 AM, Jaejoong Kim wrote: Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception hand

Re: [PATCH] usb: musb: dsps: do not disable CPPI41 irq in driver teardown

2018-08-22 Thread Sergei Shtylyov
Hello! On 08/21/2018 09:55 PM, Bin Liu wrote: > TI AM335x CPPI41 module uses a single register bit for CPPI interrupts in It's CPPI 4.1. :-) > both musb controllers. So disabling the CPPI irq in one musb driver breaks > the other musb module. > > Since musb is already disabled before tearin

Re: [PATCH 4/9] ALSA: usb-audio: use usb_fill_int_urb()

2018-06-20 Thread Sergei Shtylyov
Hello! On 6/20/2018 12:55 AM, Sebastian Andrzej Siewior wrote: Using usb_fill_int_urb() helps to find code which initializes an URB. A grep for members of the struct (like ->complete) reveal lots of other things, too. data_ep_set_params() additionally sets urb->transfer_buffer_length which was

Re: [PATCH 3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get}

2018-06-14 Thread Sergei Shtylyov
Hello! On 06/14/2018 12:23 PM, Jaejoong Kim wrote: > Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used I thought you removed the exports from the real kref_{get|put}(). :-) Your patch subject and description are simply misleading the way they are written. > only in f_mass_stor

Re: [PATCH 2/3] usb: dwc3: pci: Enable ULPI Refclk on platforms where the firmware doesnot

2018-06-07 Thread Sergei Shtylyov
Hello! On 06/07/2018 01:38 PM, Hans de Goede wrote: > On some Bay Trail (BYT) systems the firmware does not enable the > ULPI Refclk. > > This commit adds a helper which checks and if necessary enabled the Refclk > and calls this helper for BYT machines. > > Signed-off-by: Hans de Goede > ---

Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

2018-05-23 Thread Sergei Shtylyov
On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Trying to determine the USB port type with this mux is very > difficult. To simplify the situation, always allowing user s/allowing/allow/? Else the statement doesn't parse for me. :-) > control, even if the port is USB Type-C port. > > Signed

Re: [PATCH v2 3/3] usb: typec: fusb302: Fix debugfs issue

2018-05-23 Thread Sergei Shtylyov
Hello! On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Removing the "fusb302" debugfs directory when unloading > the driver. That allows the driver to be loaded more then > ones. The directory will not get actually removed until it s/ones/once/? > is empty, so only after the last instance h

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Sergei Shtylyov
- if (dev->of_node) { > - ret = of_mdiobus_register(mdp->mii_bus, dev->of_node); > - } else { > - if (pd->phy_irq > 0) > - mdp->mii_bus->irq[pd->phy] = pd->phy_irq; > - > - ret = mdiobus_re

Re: [PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes

2018-05-08 Thread Sergei Shtylyov
Hello! On 5/7/2018 6:18 PM, Icenowy Zheng wrote: Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and a custom PHY. Add device tree nodes for them. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 1 file changed,

Re: [PATCH v5 08/14] staging: typec: tcpci: register port before request irq

2018-05-03 Thread Sergei Shtylyov
On 5/3/2018 11:29 AM, Sergei Shtylyov wrote: From: Peter Chen With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen Signed-off-by: Li Jun ---   drivers/staging/typec/tcpci.c | 15

Re: [PATCH v5 08/14] staging: typec: tcpci: register port before request irq

2018-05-03 Thread Sergei Shtylyov
Hello! On 5/3/2018 3:24 AM, Li Jun wrote: From: Peter Chen With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 15 ++

Re: [PATCH 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-04-24 Thread Sergei Shtylyov
Hello! On 4/24/2018 5:43 AM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is 0), we can't simply return immediately. Because the DATA0 can be the first transaction or the second transaction for the isoc split in transaction. If the DATA0 packet with on da

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

2018-04-23 Thread Sergei Shtylyov
Hello! s/optrion/option/ in the subject. And please add spaces after each colon. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 1/1] usb: core: Add quirk for HP v222w 16GB Mini

2018-04-14 Thread Sergei Shtylyov
Hello! On 4/13/2018 8:40 PM, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kamil Lulko Add DELAY_INIT quirk to fix the following problem with HP v222w 16GB Mini: usb 1-3: unable to read config index 0 descriptor/start: -110 usb 1-3: can't read configurations, error -110 usb 1-3: ca

Re: [PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()

2018-04-06 Thread Sergei Shtylyov
Hello! On 4/6/2018 1:31 AM, Shuah Khan wrote: Validate !rhport < 0 before using it to access port_status array. Why '!'? Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/usbip/vhci_hcd.c b/driver

Re: [PATCH v2 1/1] usb: musb: gadget: misplaced out of bounds check

2018-03-20 Thread Sergei Shtylyov
Hello! On 3/20/2018 5:27 AM, Heinrich Schuchardt wrote: musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- v2 Only the 4 low bits of epnum are relevant for indexing. --- d

Re: [PATCH] usb: Don't disable Latency tolerance Messaging (LTM) before port reset

2018-03-01 Thread Sergei Shtylyov
Hello! On 03/01/2018 02:15 PM, Mathias Nyman wrote: > Disabing Latency Tolerance Messaging before port reset is unnecessary. > LTM is automatically disabled at port reset. > > If host can't communicate with the device the LTM message will fail, and > the hub driver will unnecessarily do a logica

Re: [RFC PATCH] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-02-25 Thread Sergei Shtylyov
Hello! On 2/24/2018 11:51 PM, Merlijn Wajer wrote: Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 pgd = b333e822 [fa0ab060] *pgd=48011452(bad) [] (musb_default_r

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

2018-01-22 Thread Sergei Shtylyov
On 01/22/2018 06:44 PM, Ladislav Michl wrote: >>> As devm_ioremap_resource() checks for valid resource, >>> make use of it instead of testing ourselves. As a bonus >>> memory region is requested. >>> >>> Signed-off-by: Ladislav Michl >>> --- >>> drivers/usb/gadget/udc/atmel_usba_udc.c | 40 >>>

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

2018-01-22 Thread Sergei Shtylyov
Hello! On 01/22/2018 06:21 PM, Ladislav Michl wrote: > As devm_ioremap_resource() checks for valid resource, > make use of it instead of testing ourselves. As a bonus > memory region is requested. > > Signed-off-by: Ladislav Michl > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 40 > +++

Re: [PATCH v4] usb: uhci: Add clk support to uhci-platform

2018-01-16 Thread Sergei Shtylyov
Hello! On 1/16/2018 12:53 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to

Re: [PATCH v4] usb: uhci: Add clk support to uhci-platform

2018-01-15 Thread Sergei Shtylyov
Hello! On 1/15/2018 1:59 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to t

Re: [PATCH] usb: uhci: Add clk support to uhci-platform

2018-01-11 Thread Sergei Shtylyov
Hello! On 1/12/2018 8:51 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to t

Re: [PATCH 13/15] usb: dwc3: Track DWC_usb31 VERSIONTYPE

2018-01-05 Thread Sergei Shtylyov
Hello! On 1/5/2018 11:16 PM, Thinh Nguyen wrote: Add a new variable to dwc3 structure to track VERSIONTYPE. The That's called field, not variable. VERSIONTYPE is represented in ASCII in the 32-bit VERSIONTYPE register. In DWC_usb31, sub releases for each version are tracked with VERSIONT

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

2018-01-05 Thread Sergei Shtylyov
Hello! On 1/4/2018 11:01 PM, Chris Brandt wrote: Add USB device support. Signed-off-by: Chris Brandt --- arch/arm/boot/dts/r7s72100.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index ab9645a

Re: [PATCH] usb: quirks: Add reset-resume quirk for QCA6174 Rome Bluetooth

2018-01-01 Thread Sergei Shtylyov
Hello! On 12/31/2017 8:13 PM, Leif Liddy wrote: This is a rework of reverted commit fd865802c66bc451dc515ed89360f84376ce1a56 You need to also specify the commit summry enclosed in (""). Alos, 12 digits of SHA1 is enough. The issue is that some QCA Rome bluetooth controllers stop functi

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Sergei Shtylyov
Hello! On 10/20/2017 12:54 PM, Uwe Kleine-König wrote: ehci_hub_control does the following related to overcurrent handling (simplified): temp = ehci_readl(ehci, status_reg); if (temp & PORT_OCC) { status |= USB_PORT_STAT_C_OVERCURRENT << 16; if

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-17 Thread Sergei Shtylyov
On 10/17/2017 12:22 AM, Jules Maselbas wrote: Thanks Sergei, Is it better if the documentation say: " Optional property: - interrupt-parent: the phandle of the associated interrupt controller. " That should be enough. or should I also add that "it may be inherited from the parent nodes

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-16 Thread Sergei Shtylyov
On 10/16/2017 12:04 PM, Sergei Shtylyov wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-16 Thread Sergei Shtylyov
Hello! On 10/16/2017 2:43 AM, Jules Maselbas wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devi

Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init()

2017-09-30 Thread Sergei Shtylyov
Hello! On 9/28/2017 3:17 AM, Chunfeng Yun wrote: When fail to get irq number, platform_get_irq() may return Failing. IRQ. :-) -EPROBE_DEFER, but we ignore it and always return -ENODEV, so fix it. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_core.c |4 ++-- 1 file change

Re: [PATCH] USB: gadgetfs: fix copy_to_user while holding spinlock

2017-09-21 Thread Sergei Shtylyov
Hello! On 09/21/2017 11:12 PM, Alan Stern wrote: The gadgetfs driver as a long-outstanding FIXME, regarding a call of s/as/has/? copy_to_user() made while holding a spinlock. This patch fixes the issue by dropping the spinlock and using the dev->udc_usage mechanism introduced by another

Re: [PATCH v2 3/4] usb: musb: musb_cppi41: Configure the number of channels for DA8xx

2017-09-20 Thread Sergei Shtylyov
Hello! On 9/20/2017 10:35 AM, Alexandre Bailon wrote: Currently, the number of channels is set to 15 but in the case of DA8xx, the number of channels is 4. Update the driver to configure the number of channels at runtime. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_cppi41.c |

Re: [PATCH 7/8] xhci: set missing SuperSpeedPlus Link Protocol bit in roothub descriptor

2017-09-18 Thread Sergei Shtylyov
Hello! Only some grammar nits, could prolly be fixed when applying... On 09/18/2017 05:39 PM, Mathias Nyman wrote: A SuperSpeedPlus roothub needs to have the Link Protocol (LP) bit set in the bmSublinkSpeedAttr[] entry of a SuperSpeedPlus descriptor. If the xhci controller has an optional P

Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message

2017-09-11 Thread Sergei Shtylyov
Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd

Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file

2017-08-29 Thread Sergei Shtylyov
Hello! On 8/29/2017 12:20 PM, Chunfeng Yun wrote: The mt8173-mtu3.txt actually holds the bindings for all mediatek SoCs with usb3 DRD IP, so add a generic compatible and change the name to mediatek,mtu3.txt. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring --- .../usb/{mt8173-mtu3.txt =>

[PATCH] usb: common: use of_property_read_bool()

2017-08-20 Thread Sergei Shtylyov
Use more compact of_property_read_bool() calls for the boolean properties instead of of_find_property() calls in of_usb_host_tpl_support() and of_usb_update_otg_caps(). Signed-off-by: Sergei Shtylyov --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git&

Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

2017-08-17 Thread Sergei Shtylyov
On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/s

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Sergei Shtylyov
Hello! On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32746g-eval.dts

Re: [PATCH 2/2] usb: musb: musb_cppi41: Fix cppi41_set_dma_mode() for DA8xx

2017-08-15 Thread Sergei Shtylyov
On 8/13/2017 3:04 PM, Alexandre Bailon wrote: The way to configure the DMA mode on DA8xx is different from DSPS. Add a new function to configure DMA mode on DA8xx and use a callback to call the right function based on the platform. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_cp

Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers

2017-08-15 Thread Sergei Shtylyov
Hello! On 8/13/2017 3:04 PM, Alexandre Bailon wrote: The DA8xx and DSPS platforms don't use the same address for few registers. On Da8xx, this is causing some issues (e.g. teardown that doesn't work). Configure the address of the register during the init and use them instead of constants. Repo

Re: [PATCH] uas: Add US_FL_IGNORE_RESIDUE for Initio Copropration INIC-3069

2017-07-26 Thread Sergei Shtylyov
Hello! On 7/26/2017 12:46 AM, Alan Swanson wrote: Similar to commit d595259fbb7a7afed241b1afb2c4fe4b47de47fa for INIC-3169 in That's not how you cite a commit -- you should also specify the commit summary line enclosed in ("") (and 12-digit SHA1 would be enough). unusual_devs.h but INI

Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

2017-07-18 Thread Sergei Shtylyov
Hello! On 07/18/2017 06:13 PM, Bin Liu wrote: Add helper function musb_ep_xfertype_string() to return the ep transfer type string. Signed-off-by: Bin Liu Doesn't this belong to USB core? What's MUSB specific about it? --- drivers/usb/musb/musb_core.h | 24 d

Re: [PATCH 1/4] usb: Add Aspeed SoC USB controllers to device-tree

2017-06-26 Thread Sergei Shtylyov
On 06/26/2017 05:46 PM, Benjamin Herrenschmidt wrote: arch/arm/boot/dts/aspeed-g4.dtsi | 15 +++ arch/arm/boot/dts/aspeed-g5.dtsi | 22 ++ 2 files changed, 37 insertions(+) If the patch only changes .dtsi files, the subject needs to be smth like "ARM: d

Re: [PATCH 1/4] usb: Add Aspeed SoC USB controllers to device-tree

2017-06-26 Thread Sergei Shtylyov
Hello. On 6/25/2017 11:18 PM, Benjamin Herrenschmidt wrote: Now that the necessary tweaks for the Aspeed variant of UHCI are supported, this adds the USB controllers to the DT template of the AST24xx and AST25xx SoCs. The EHCI works with the current unmodified driver. This patch doesn't enabl

Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

2017-06-02 Thread Sergei Shtylyov
Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for

Re: [PATCH v2] usb:host:xhci AMD Promontory USB disable port support

2017-05-26 Thread Sergei Shtylyov
Hello! On 5/26/2017 12:35 PM, Jiahau Chang wrote: There is some limitation for AMD Promontory xHCI host to disable USB port function. It will enable USB wake-up function then cause USB disable port feature to fail. Workaround this issue on Promontory xHCI host is clear PORT_WAKE_BITS. Sig

Re: [PATCH v4 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-22 Thread Sergei Shtylyov
Hello! On 5/22/2017 11:41 AM, Yuyang Du wrote: If we get nonpositive number of ports, there is no sense to continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced configurable numbers of controllers and ports,

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-18 Thread Sergei Shtylyov
Hello! On 05/18/2017 12:50 PM, Yuyang Du wrote: From: Yuyang Du If we get nonpositive number of ports, there is no sense to Negative? continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced configurab

  1   2   3   4   5   6   7   8   9   10   >