On 30/05/2014 04:13 πμ, Saran Neti wrote:
Hi Xenia,
Thanks for looking into this.
On Thu, May 29, 2014 at 6:31 PM, Xenia Ragiadakou burzalod...@gmail.com wrote:
I misunderstood the following description regarding the slot id field of
Command Completion Event TRB:
The Slot ID field shall
it out of command
# git show 20e7acb13ff48fbc884d5918c3697c27de63922a
commit 20e7acb13ff48fbc884d5918c3697c27de63922a
Author: Xenia Ragiadakou burzalod...@gmail.com
mailto:burzalod...@gmail.com
Date: Mon Sep 9 13:29:50 2013 +0300
xhci: use completion event's slot id rather than dig it out
On 30/01/2014 11:21 πμ, Rafał Miłecki wrote:
2014-01-29 Xenia Ragiadakou burzalod...@gmail.com:
Rafał is it possible to send all the bad output with xhci debugging on?
Since your config file shows that dynamic debugging is on, that would be
easy to do by adding dyndbg='module xhci_hcd +p
On 30/01/2014 12:00 πμ, Sarah Sharp wrote:
On Wed, Jan 29, 2014 at 12:50:04PM +0200, Xenia Ragiadakou wrote:
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
I've enabled some debugging in xhci-dbg.c, does it help?
xhci_hcd :04:00.0: xHCI capability registers at c90004e6:
xhci_hcd
On 30/01/2014 07:42 μμ, Xenia Ragiadakou wrote:
On 30/01/2014 12:00 πμ, Sarah Sharp wrote:
On Wed, Jan 29, 2014 at 12:50:04PM +0200, Xenia Ragiadakou wrote:
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
I've enabled some debugging in xhci-dbg.c, does it help?
xhci_hcd :04:00.0: xHCI
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
2014-01-29 David Laight david.lai...@aculab.com:
Maybe I misunderstand something, but won't that commit end up replacing
the previous pair of writel() with a single native writeq() on 64bit
platforms?
Judging by the comment in front of the
On 29/01/2014 01:43 μμ, David Laight wrote:
From: Xenia Ragiadakou
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
2014-01-29 David Laight david.lai...@aculab.com:
Maybe I misunderstand something, but won't that commit end up replacing
the previous pair of writel() with a single native writeq
On 07/01/2014 11:46 μμ, Sarah Sharp wrote:
On Wed, Dec 25, 2013 at 09:51:28PM -0500, Alan Stern wrote:
Okay, now we know that usb_enable_interface takes a long time. That
routine does nothing but call usb_enable_endpoint, which does nothing
but call usb_hcd_reset_endpoint, which calls the
On 11/25/2013 04:41 AM, Alan Stern wrote:
On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
You can simplify part of the problem by not allowing an endpoint to be
reset if it has any pending URBs. Just fail the reset in this case.
Yes, you are right since, from what i understand
On 11/25/2013 04:44 AM, Alan Stern wrote:
On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
On 11/25/2013 01:50 AM, Xenia Ragiadakou wrote:
[snip]
Also, while you're going through the whole remove-and-add procedure for
endpoints that aren't halted, do you want to hold the bandwidth mutex
Hi Alan and Sarah,
Sorry for my late response but i had some personal issues that held me
back for a while.
My comments follow below.
On 10/17/2013 06:11 PM, Alan Stern wrote:
On Wed, 16 Oct 2013, Sarah Sharp wrote:
I think there's some nasty race conditions here. There's several
On 11/25/2013 01:50 AM, Xenia Ragiadakou wrote:
[snip]
Also, while you're going through the whole remove-and-add procedure for
endpoints that aren't halted, do you want to hold the bandwidth mutex?
If the procedure isn't atomic, there's a possibility that some other
device could change configs
:08PM +0300, Xenia Ragiadakou wrote:
The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs
to be converted to CPU byteorder for the correct retrieval of its subfield
'Context Entries'. This field is used by the trace event 'xhci_address_ctx'
to trace only the contexts of valid
sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Changes from v1:
* fix patch to apply cleanly on for-usb-next-queue branch of xhci tree
drivers/usb/host/xhci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host
This patch removes the to_pci_dev() conversion performed to generic struct
device since it is not actually useful (the pointer to the generic device
can be used directly rather through a conversion to pci_dev) and it is pci
bus specific.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
to be
called in a context where a pointer to xhci_hcd is available.
Remove the unnecessary xhci_readl() wrapper function and replace its calls to
with calls to readl() to make the code more straightforward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-dbg.c
function that
has to be called in a context where a pointer to xhci_hcd is available.
Remove xhci_writel() wrapper function and replace its calls with calls to
writel() to make the code more straight-forward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-hub.c
systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-dbg.c | 6 +++---
drivers/usb/host/xhci-mem.c | 6 +++---
drivers/usb/host/xhci-ring.c | 6 +++---
drivers/usb/host/xhci.c | 12 ++--
drivers/usb/host/xhci.h | 10 ++
5 files
and the rest of the headers to improve readability.
Xenia Ragiadakou (4):
xhci: replace xhci_readl() with readl()
xhci: replace xhci_writel() with writel()
xhci: replace xhci_read_64() with readq()
xhci: replace xhci_write_64() with writeq()
drivers/usb/host/xhci-dbg.c | 42 ++--
drivers
on 64bit systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 8
drivers/usb/host/xhci-ring.c | 8 +++-
drivers/usb/host/xhci.c | 8
drivers/usb/host/xhci.h | 29 +
4 files changed, 20
Hi Sarah,
On 10/10/2013 09:25 PM, Sarah Sharp wrote:
Hi Xenia,
On Mon, Oct 07, 2013 at 06:52:39PM +0300, Xenia Ragiadakou wrote:
The previous patch on the endpoint reset uses the already implemented function
xhci_drop_endpoint() to reduce code duplication. However, the way that xhci
updates
On 10/11/2013 11:40 AM, Xenia Ragiadakou wrote:
[snip]
The main reasons that made me come to this conclusion was the fact
that Context Entries by being updated with a value other than the last
valid endpoint will be inconsistent with the definition in xhci spec
(revision 1.0 5/21/10) Context
On 10/11/2013 09:26 PM, Sarah Sharp wrote:
On Fri, Oct 11, 2013 at 07:30:17PM +0300, Xenia Ragiadakou wrote:
[snip]
To test if a smaller value will cause a problem, I reset first
endpoint 4 and, then, endpoint 3 so that the Context Entries field
get updated with the value 3 while the actual
On 10/07/2013 06:52 PM, Xenia Ragiadakou wrote:
[snip]
+static int xhci_reset_ep0(struct xhci_hcd *xhci, struct usb_device *udev,
+ struct usb_host_endpoint *ep)
+{
+ struct xhci_virt_device *vdev;
+ struct xhci_input_control_ctx *ctrl_ctx;
+ struct xhci_slot_ctx
them as
invalid and the transactions to these endpoints will break.
This patch updates the last valid endpoint with the index of the first not
disabled endpoint, starting from the current last valid endpoint and skipping
the dropped endpoint.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
. At this early stage, it is
useful for debugging the xhci_reset_not_halted_ep() and it may be removed
later when further testing and revisioning show that the function works as
expected.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
This patch needs to be tested further because I did not find
On 10/01/2013 11:45 PM, Sarah Sharp wrote:
On Tue, Oct 01, 2013 at 10:01:08PM +0300, Xenia Ragiadakou wrote:
Hi Sarah,
I read the mail on 'possible conflict between xhci_hcd and a patched
usbhid'.
For reference to others:
http://marc.info/?l=linux-usbm=138064948726038w=2
http://marc.info/?l
On 09/23/2013 07:45 PM, Sarah Sharp wrote:
On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote:
The function pci_write_config_dword() sets the appropriate byteordering
internally so the value argument should not be converted to little-endian.
This bug was found by sparse.
Can you
The function pci_write_config_dword() sets the appropriate byteordering
internally so the value argument should not be converted to little-endian.
This bug was found by sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/pci-quirks.c | 4 ++--
1 file changed, 2
On 09/13/2013 06:49 AM, Pratyush Anand wrote:
On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote:
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO
address space. It takes as first argument a pointer to the xhci_hcd although
it does not use it because
On 09/13/2013 12:28 PM, Pratyush Anand wrote:
Hi ksenia,
On Fri, Sep 13, 2013 at 04:45:23PM +0800, Xenia Ragiadakou wrote:
On 09/13/2013 06:49 AM, Pratyush Anand wrote:
On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote:
Function xhci_readl() is used to read 32bit xHC registers
On 09/04/2013 08:39 AM, Xenia Ragiadakou wrote:
Since the slot id retrieved from the command TRB matches the one in Slot ID
field of the command completion event, which is available, there is no need
to determine it again.
This patch removes the uneccessary reassignment to slot id and adds
to
reference to them more easily.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb
This patch adds a new variable 'cmd_trb' to hold the address of the
command TRB, that is associated with the command completion event,
and to replace repetitions of xhci-cmd_ring-dequeue into the code.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh
This patch removes the variable 'ep_ring' that is assigned in
TRB_CONFIG_EP switch case but never used.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci
xhci_handle_cmd_reset_dev().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/host/xhci
'xhci_dbg_missed_periodic_tx', to trace the debug statements related to
missed periodic transfers.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-make changelog more clear
-add two additional tracepoints
drivers/usb/host/xhci-ring.c | 26
This patch adds a new variable 'cmd_comp_code' to hold the command completion
status code aiming to reduce code duplication and to improve code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c
xhci_handle_cmd_disable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/host
calculation
in each of them.
Also, a WARN_ON() was added in case the slot ids reported by command TRB and
event TRB differ (although according to xhci spec rev1.0 that should not happen)
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v4:
-add a WARN_ON() in case the two slot id
according xhci spec rev1.0
they should not differ).
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-the above change is performed now in a separate patch
-a warning is triggered in case the slot id reported in event trb is
different from the slot id renoted in command
xhci_handle_cmd_addr_dev().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b
This patch adds a new variable 'cmd_type' to hold the command type so that
switch cases can be simplified by removing TRB_TYPE() macro improving
code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
update changelog to report the reason for such change
xhci_handle_cmd_eval_ctx().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci
This patch replaces 'xhci-cmd_ring-dequeue' with 'trb', the address of
the command TRB, since it is available to reduce line length.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 6 ++
1 file
xhci_handle_cmd_config_ep().
There were added two additional variables, 'add_flags' and 'drop_flags',
to reduce line length below 80 chars and improve code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-add reason for new function creation in change log
xhci_handle_cmd_enable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci
This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci-cmd_ring);
return;
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-remove return statement
drivers/usb/host/xhci-ring.c | 7 +++
1 file changed, 3 insertions(+), 4
This patch replaces the 'event' argument of xhci_handle_cmd_set_deq() and
xhci_handle_cmd_reset_ep(), which is used to retrieve the command completion
status code, with the cmd_comp_code directly, since it is available.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp
.
The trace-cmd tool with the help of plugin_xhci.py will use this field to
parse the TRB contents in a human readable way.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci
sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index bda0cdf..9f22ddf 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host
function that
has to be called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_writel() with calls to writel() in xhci.c.
This is done so that xhci_writel() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou
, the typecasting of le32 to u64 was incorrect and the
subsequent conversion to le64 reverts the low and high address parts.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
function that
has to be called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_writel() with calls to writel() in
xhci-ring.c.
This is done so that xhci_writel() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou
This patch removes xhci_readl() because it has been replaced with readl()
and it is not used anymore.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index
This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in
'control' field of the link TRB.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
function that
has to be called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_writel() with calls to writel() in xhci-hub.c.
This is done so that xhci_writel() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou
to be
called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_readl() with calls to readl() in xhci-hub.c.
This is done so that xhci_readl() can be removed completely and code can
become more straightforward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
to be
called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_readl() with calls to readl() in xhci-mem.c.
This is done so that xhci_readl() can be removed completely and code can
become more straightforward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx
have type __le32 and need to be converted to CPU byteorder before being
used to derive the number of added endpoints.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb
specific instructions that implement this computation more efficiently.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index
to be
called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_readl() with calls to readl() in xhci-dbg.c.
This is done so that xhci_readl() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
to be
called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_readl() with calls to readl() in xhci.c.
This is done so that xhci_readl() can be removed completely and code can
become more straightforward.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
function that
has to be called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_writel() with calls to writel() in xhci-mem.c.
This is done so that xhci_writel() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou
to be
called in a context where a pointer to xhci_hcd is available.
This patch replaces calls to xhci_readl() with calls to readl() in xhci-ring.c.
This is done so that xhci_readl() can be removed completely and code can
become more straight-forward.
Signed-off-by: Xenia Ragiadakou burzalod
This patch converts Event TRB's 3rd field, which has type le32, to CPU
byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx
have type __le32 and need to be converted to CPU byteorder before being
used to derive the number of dropped endpoints.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb
This patch removes xhci_writel() since its calls has been replaced with
writel() and it is not used anymore.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host
operation
is already implemented.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 8
drivers/usb/host/xhci-ring.c | 8 +++-
drivers/usb/host/xhci.c | 8
drivers/usb/host/xhci.h | 30 ++
4 files
that if the system is not 64bit, readq() will read registers in low-high
order. Also, it replaces all calls to xhci_read_64() with calls to readq()
and removes xhci_read_64().
This is done to reduce code duplication since 64bit register read operation
is already implemented.
Signed-off-by: Xenia
On 09/04/2013 09:25 PM, Martin MOKREJŠ wrote:
Hi Xenia,
thank you. I tested this patch on 3.11 kernel and the messages don't appear
anymore
upon LPM-capable device disconnect (tested with ASMedia AS2105 devices).
Not much to show here, there is just no error/warning related to LPM
while
Set SEL control urbs cannot be sent to a device in unconfigured state.
This patch adds a check in usb_req_set_sel() to ensure the usb device's
state is USB_STATE_CONFIGURED.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Reported-by: Martin MOKREJS mmokr...@gmail.com
Suggested-by: Sarah
This patch adds a new variable 'cmd_trb' to hold the address of the
command TRB, that is associated with the command completion event,
and to replace repetitions of xhci-cmd_ring-dequeue into the code.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh
xhci_handle_cmd_config_ep().
There were added two additional variables, 'add_flags' and 'drop_flags',
to reduce line length below 80 chars and improve code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-add reason for new function creation in change log
This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci-cmd_ring);
return;
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
remove return statement
drivers/usb/host/xhci-ring.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions
xhci_handle_cmd_disable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/host
to
reference to them more easily.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb
This patch removes the variable 'ep_ring' that is assigned in
TRB_CONFIG_EP switch case but never used.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci
calculation
in each of them.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 485ce5c..9cb0f42 100644
--- a/drivers
This patch replaces 'xhci-cmd_ring-dequeue' with 'trb', the address of
the command TRB, since it is available to reduce line length.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 6 ++
1 file
xhci_handle_cmd_nec_get_fw().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/xhci
xhci_handle_cmd_reset_dev().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/host/xhci
This patch adds a new variable 'cmd_type' to hold the command type so that
switch cases can be simplified by removing TRB_TYPE() macro improving
code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
update changelog to report the reason for such change
xhci_handle_cmd_eval_ctx().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci
This patch adds a new variable 'cmd_comp_code' to hold the command completion
status code aiming to reduce code duplication and to improve code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c
This patch replaces the 'event' argument of xhci_handle_cmd_set_deq() and
xhci_handle_cmd_reset_ep(), which is used to retrieve the command completion
status code, with the cmd_comp_code directly, since it is available.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp
This patch removes the adjective argument from xhci_giveback_urb_in_irq(),
since it is not used in the function anymore.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 8
1 file changed, 4
xhci_handle_cmd_enable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
add reason for new function creation in change log
drivers/usb/host/xhci-ring.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci
.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from v3:
-the above change is performed now in a separate patch
-a warning is triggered in case the slot id reported in event trb is
different from the slot id renoted in command trb
drivers/usb/host/xhci-ring.c | 5 +++--
1 file
On 09/01/2013 06:04 AM, Greg KH wrote:
On Sun, Sep 01, 2013 at 02:56:42AM +0200, Martin MOKREJŠ wrote:
Martin MOKREJŠ wrote:
Hi Xenia,
I tried these 3 patches and ... I will rather leave it up to you to decide
if everything went right. Attached is a diff of dmesg from unpatched and patched
usb_submit_urb()
will fail).
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index fe8d95d..a6c10f0 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core
usb_submit_urb()
will fail).
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Reported-by: Martin MOKREJS mmokr...@gmail.com
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index fe8d95d..a6c10f0 100644
On 08/31/2013 07:52 AM, Greg KH wrote:
On Sat, Aug 31, 2013 at 04:52:47AM +0300, Xenia Ragiadakou wrote:
On 08/31/2013 04:25 AM, Greg KH wrote:
On Sat, Aug 31, 2013 at 04:20:09AM +0300, Xenia Ragiadakou wrote:
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor
This patch sets the lpm_capable field for root hubs with LPM capabilities.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Reported-by: Martin MOKREJS mmokr...@gmail.com
Suggested-by: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/core/hcd.c | 1 +
drivers/usb/core/hub.c | 7
Urb fields are stored in struct usbdevfs_ctrltransfer in CPU byteorder
and not in little endian, so there is no need to be converted.
This bug was reported by sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/core/devio.c | 6 ++
1 file changed, 2 insertions(+), 4
the assignmenment to [udev/hub]_u2_del variables.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Reported-by: kbuild test robot fengguang...@intel.com
---
drivers/usb/core/hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core
On 08/29/2013 04:31 PM, Martin MOKREJŠ wrote:
Actually, there is some new bug I haven't seen before (this is 3.10.9 kernel).
First of all, I see my TI XHCI controller does not use MSI-X anymore, will have
to check my .config why is it so.
Why are you saying that xhci does not use MSI-X?
Can
On 08/31/2013 04:25 AM, Greg KH wrote:
On Sat, Aug 31, 2013 at 04:20:09AM +0300, Xenia Ragiadakou wrote:
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order
This patch removes ehci_vdbg debugging statements from EHCI host controller
driver because they produce too much information, lowering the signal to noise
ratio when debugging, and because they are not used anymore.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/ehci
The debugging code for ehci is enabled to run if the DEBUG flag is defined.
This patch enables the debugging code also when the kernel is configured
with dynamic debugging on.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/ehci-dbg.c | 8
drivers/usb/host
1 - 100 of 175 matches
Mail list logo
