Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
On Thu, Aug 15, 2019 at 01:19:19PM +0100, Bob Ham wrote: > On 15/08/2019 12:49, Johan Hovold wrote: > > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > >> On 05/08/2019 12:47, Johan Hovold wrote: > >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > From: Bob Ham > > Add a VID:PID for the BroadModi BM818 M.2 card > >>> > >>> Would you mind posting the output of usb-devices (or lsusb -v) for this > >>> device? > >> > >> T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 > >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > >> P: Vendor=2020 ProdID=2060 Rev=00.00 > >> S: Manufacturer=Qualcomm, Incorporated > >> S: Product=Qualcomm CDMA Technologies MSM > >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > >> I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) > >> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > > > > I amended the commit message with the above, switched to > > USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry > > to the other 0x2020 entries before applying. > > Sorry I should probably have mentioned this before but Angus has been on > vacation, hence the silence on the other matters. Regardless, thanks. Ok, no worries. Johan signature.asc Description: PGP signature
Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
On 15/08/2019 12:49, Johan Hovold wrote: > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: >> On 05/08/2019 12:47, Johan Hovold wrote: >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: From: Bob Ham Add a VID:PID for the BroadModi BM818 M.2 card >>> >>> Would you mind posting the output of usb-devices (or lsusb -v) for this >>> device? >> >> T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> P: Vendor=2020 ProdID=2060 Rev=00.00 >> S: Manufacturer=Qualcomm, Incorporated >> S: Product=Qualcomm CDMA Technologies MSM >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA >> I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) >> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > > I amended the commit message with the above, switched to > USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry > to the other 0x2020 entries before applying. Sorry I should probably have mentioned this before but Angus has been on vacation, hence the silence on the other matters. Regardless, thanks. Bob signature.asc Description: OpenPGP digital signature
Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > On 05/08/2019 12:47, Johan Hovold wrote: > > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > >> From: Bob Ham > >> > >> Add a VID:PID for the BroadModi BM818 M.2 card > > > > Would you mind posting the output of usb-devices (or lsusb -v) for this > > device? > > T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=2020 ProdID=2060 Rev=00.00 > S: Manufacturer=Qualcomm, Incorporated > S: Product=Qualcomm CDMA Technologies MSM > C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) > I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I amended the commit message with the above, switched to USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry to the other 0x2020 entries before applying. Johan signature.asc Description: PGP signature
Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
On 05/08/2019 12:47, Johan Hovold wrote: > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: >> From: Bob Ham >> >> Add a VID:PID for the BroadModi BM818 M.2 card > > Would you mind posting the output of usb-devices (or lsusb -v) for this > device? T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=2020 ProdID=2060 Rev=00.00 S: Manufacturer=Qualcomm, Incorporated S: Product=Qualcomm CDMA Technologies MSM C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) signature.asc Description: OpenPGP digital signature
Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote:
> From: Bob Ham
>
> Add a VID:PID for the BroadModi BM818 M.2 card
Would you mind posting the output of usb-devices (or lsusb -v) for this
device?
> Signed-off-by: Bob Ham
> Signed-off-by: Angus Ainslie (Purism)
> ---
> drivers/usb/serial/option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index c1582fbd1150..674a68ee9564 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1975,6 +1975,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) | RSVD(5) },
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff),
> /* Fibocom NL678 series */
> .driver_info = RSVD(6) },
> + { USB_DEVICE(0x2020, 0x2060),
> /* BroadMobi */
Looks like you forgot to include the model in the comment here.
And please move this one after the other 0x2020 (PID 0x2031) entry.
Should you also be using USB_DEVICE_INTERFACE_CLASS() (e.g. to avoid
matching a mass-storage interface)?
> + .driver_info = RSVD(4) },
> { } /* Terminating entry */
> };
> MODULE_DEVICE_TABLE(usb, option_ids);
Johan
