On Thu, 10 Oct 2019, Bastien Nocera wrote:
> On Wed, 2019-10-09 at 14:45 -0400, Alan Stern wrote:
> >
> On Wed, 9 Oct 2019, Bastien Nocera wrote:
> >
> >
> > > + return
> > device_driver_attach(usb_generic_driver.drvwrap.driver, dev);
> > > + return error;
> >
> > I think t
Hi Bastien,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[cannot apply to v5.4-rc2 next-20191010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to spec
On Wed, 2019-10-09 at 14:45 -0400, Alan Stern wrote:
>
On Wed, 9 Oct 2019, Bastien Nocera wrote:
>
>
> > + return
> device_driver_attach(usb_generic_driver.drvwrap.driver, dev);
> > + return error;
>
> I think that's right. A little testing wouldn't hurt.
device_driver_att
On Wed, 9 Oct 2019, Bastien Nocera wrote:
> On Wed, 2019-10-09 at 13:28 -0400, Alan Stern wrote:
>
> > No, that's not quite it.
> >
> > Here's what should happen when the subclass driver is being probed:
> > First, call the generic_probe routine, and return immediately if that
> > fails. Then c
On Wed, 2019-10-09 at 13:28 -0400, Alan Stern wrote:
> No, that's not quite it.
>
> Here's what should happen when the subclass driver is being probed:
> First, call the generic_probe routine, and return immediately if that
> fails. Then call the subclass driver's probe routine. If that gets
>
On Wed, 9 Oct 2019, Bastien Nocera wrote:
> On Wed, 2019-10-09 at 10:43 -0400, Alan Stern wrote:
> > On Wed, 9 Oct 2019, Bastien Nocera wrote:
> >
> > > Now that USB device drivers can reuse code from the generic USB
> > device
> > > driver, we need to make sure that they get selected rather than
On Wed, 2019-10-09 at 10:43 -0400, Alan Stern wrote:
> On Wed, 9 Oct 2019, Bastien Nocera wrote:
>
> > Now that USB device drivers can reuse code from the generic USB
> device
> > driver, we need to make sure that they get selected rather than the
> > generic driver. Add an id_table and match vfun
On Wed, 9 Oct 2019, Bastien Nocera wrote:
> Now that USB device drivers can reuse code from the generic USB device
> driver, we need to make sure that they get selected rather than the
> generic driver. Add an id_table and match vfunc to the usb_device_driver
> struct, which will get used to selec
