Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-30 Thread Rob Herring
On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: > From: Axel Haslam > > Some regulator supplies have an over-current pin that is > activated when the hw detects an over current condition. > When this happens, the hardware enters a current limited >

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 4:57 PM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 4:33 PM, Mark Brown wrote: >> On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote: >> >>> To be able to use regulator to handle the overcurrent pin, i need to be able

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 4:33 PM, Mark Brown wrote: > On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote: > >> To be able to use regulator to handle the overcurrent pin, i need to be able >> to somehow retrieve the over current pin state from the regulator driver. > >

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-25 Thread Mark Brown
On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote: > To be able to use regulator to handle the overcurrent pin, i need to be able > to somehow retrieve the over current pin state from the regulator driver. What makes you say that, none of the existing users need this? > As i was

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-25 Thread Axel Haslam
Hi Mark, On Mon, Oct 24, 2016 at 8:19 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: >> On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > >> > does it make sense to report this as a mode, we don't report other

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Mark Brown
On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: > On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > > does it make sense to report this as a mode, we don't report other error > > conditions as modes but instead use REGULATOR_STATUS_ with the > > get_status()

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Axel Haslam
On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: > >> + if (ret) { >> + pr_err("Failed to request irq: %d\n", ret); > > dev_err() > >> +++

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Axel Haslam
Hi Mark, On Mon, Oct 24, 2016 at 7:43 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: >> From: Axel Haslam >> >> Some regulator supplies have an over-current pin that is >> activated when the hw detects an

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Mark Brown
On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: > + if (ret) { > + pr_err("Failed to request irq: %d\n", ret); dev_err() > +++ b/include/linux/regulator/consumer.h > @@ -74,6 +74,10 @@ > * the most noisy and may not be able to

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Mark Brown
On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: > From: Axel Haslam > > Some regulator supplies have an over-current pin that is > activated when the hw detects an over current condition. > When this happens, the hardware enters a current limited >

[PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread ahaslam
From: Axel Haslam Some regulator supplies have an over-current pin that is activated when the hw detects an over current condition. When this happens, the hardware enters a current limited mode. Extend the fixed regulator driver with the ability to handle irq's from the