Re: [PATCH] HID: usbkbd: return proper error code

2016-09-01 Thread Sudip Mukherjee
On Thursday 01 September 2016 04:51 PM, Jiri Kosina wrote: On Wed, 31 Aug 2016, Sudip Mukherjee wrote: Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. But we don't. usb_kbd_probe() returns -ENOMEM in case

Re: [PATCH] HID: usbkbd: return proper error code

2016-09-01 Thread Jiri Kosina
On Wed, 31 Aug 2016, Sudip Mukherjee wrote: > Use proper error code instead of using -1 on failure to allocate > memory. We may use the error code later in the caller. But we don't. usb_kbd_probe() returns -ENOMEM in case usb_kbd_alloc_mem() fails anyway, so I fail to see the point of the

Re: [PATCH] HID: usbkbd: return proper error code

2016-08-31 Thread Sudip Mukherjee
On Wednesday 31 August 2016 10:03 PM, Fabio Estevam wrote: On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee wrote: Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. Signed-off-by: Sudip Mukherjee

Re: [PATCH] HID: usbkbd: return proper error code

2016-08-31 Thread Fabio Estevam
On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee wrote: > Use proper error code instead of using -1 on failure to allocate > memory. We may use the error code later in the caller. > > Signed-off-by: Sudip Mukherjee > --- >

[PATCH] HID: usbkbd: return proper error code

2016-08-31 Thread Sudip Mukherjee
Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. Signed-off-by: Sudip Mukherjee --- drivers/hid/usbhid/usbkbd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git