Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Frank Schäfer
Am 15.07.2015 um 13:16 schrieb Johan Hovold: Your changes caused a regression that was discovered mere days before 3.12 was released. At the time the reason had not been fully determined so the patches were consequently reverted. Simply not true, re-read the ML archieves. In that case I

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Frank Schäfer
Am 14.07.2015 um 22:29 schrieb Greg KH: On Tue, Jul 14, 2015 at 09:29:29PM +0200, Frank Schäfer wrote: If you want to pick this up and improve the divisor calculations that'd be great. Maybe you should just start doing your job as the maintainer and accept one of the patches people are

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Greg KH
On Thu, Jul 16, 2015 at 10:12:55PM +0200, Frank Schäfer wrote: Simply not true, re-read the ML archieves. For those of us who don't understand, please explain. In that case I would of course have supported the revert. We both know the real reason. What is the real reason that you feel this

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
On Wed, Jul 08, 2015 at 12:51:03PM +0200, Michał Pecio wrote: This commit fixes the following issues: 1. The 9th bit of buf was believed to be the LSB of divisor's exponent, but the hardware interprets it as MSB (9th bit) of the mantissa. The exponent is actually one bit shorter and

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
On Tue, Jul 14, 2015 at 09:29:29PM +0200, Frank Schäfer wrote: Am 13.07.2015 um 18:47 schrieb Johan Hovold: On Mon, Jul 13, 2015 at 06:08:50PM +0200, Michał Pecio wrote: Commit 57ce61aad748 might be helpful... ;) Good luck, Frank Pretty much the same thing I have done, except that

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Michał Pecio
Looks nice and clean otherwise. Were you already going to send a v2 or was this version complete? I didn't intend to change anything. This works fine for me. Maybe proper rounding would be a nice addition, but I'm not sure if it's worth the effort. Now we can at least guarantee that the rate

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
[ Please try to avoid top-posting. ] On Tue, Jul 14, 2015 at 07:22:01PM +0200, Michał Pecio wrote: I managed to reproduce this old issue, both on vanilla v4.1.1 and with my patch, IF and ONLY if I reverted commit 623c82633 by changing: - if (!old_termios || memcmp(buf,

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-14 Thread Michał Pecio
I managed to reproduce this old issue, both on vanilla v4.1.1 and with my patch, IF and ONLY if I reverted commit 623c82633 by changing: - if (!old_termios || memcmp(buf, priv-line_settings, 7)) { ret = pl2303_set_line_request(port, buf); if (!ret)

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-14 Thread Frank Schäfer
Am 14.07.2015 um 19:22 schrieb Michał Pecio: I managed to reproduce this old issue, both on vanilla v4.1.1 and with my patch, IF and ONLY if I reverted commit 623c82633 by changing: - if (!old_termios || memcmp(buf, priv-line_settings, 7)) { ret =

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-14 Thread Greg KH
On Tue, Jul 14, 2015 at 09:29:29PM +0200, Frank Schäfer wrote: If you want to pick this up and improve the divisor calculations that'd be great. Maybe you should just start doing your job as the maintainer and accept one of the patches people are sending to you to get this issue fixed ?

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-14 Thread Frank Schäfer
Am 13.07.2015 um 18:47 schrieb Johan Hovold: On Mon, Jul 13, 2015 at 06:08:50PM +0200, Michał Pecio wrote: Commit 57ce61aad748 might be helpful... ;) Good luck, Frank Pretty much the same thing I have done, except that I didn't notice that 0 = 512 :) Apparently, 57ce61aad748 fell

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-14 Thread Frank Schäfer
Am 13.07.2015 um 18:08 schrieb Michał Pecio: Commit 57ce61aad748 might be helpful... ;) Good luck, Frank Pretty much the same thing I have done, except that I didn't notice that 0 = 512 :) :) Apparently, 57ce61aad748 fell victim of a mass-revert caused by some underdebugged issues.

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-13 Thread Frank Schäfer
Am 08.07.2015 um 12:51 schrieb Michał Pecio: This commit fixes the following issues: 1. The 9th bit of buf was believed to be the LSB of divisor's exponent, but the hardware interprets it as MSB (9th bit) of the mantissa. The exponent is actually one bit shorter and applies to base 4, not

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-13 Thread Johan Hovold
On Mon, Jul 13, 2015 at 06:08:50PM +0200, Michał Pecio wrote: Commit 57ce61aad748 might be helpful... ;) Good luck, Frank Pretty much the same thing I have done, except that I didn't notice that 0 = 512 :) Apparently, 57ce61aad748 fell victim of a mass-revert caused by some

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-13 Thread Michał Pecio
Commit 57ce61aad748 might be helpful... ;) Good luck, Frank Pretty much the same thing I have done, except that I didn't notice that 0 = 512 :) Apparently, 57ce61aad748 fell victim of a mass-revert caused by some underdebugged issues. Is it known what they were? Is there any chance of

[PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-08 Thread Michał Pecio
This commit fixes the following issues: 1. The 9th bit of buf was believed to be the LSB of divisor's exponent, but the hardware interprets it as MSB (9th bit) of the mantissa. The exponent is actually one bit shorter and applies to base 4, not 2 as previously believed. 2. Loop iterations