Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-20 Thread Srinivas Kandagatla
Overall nvmem side looks good! Minor nits below. On 14/06/18 21:08, Loic Poulain wrote: Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048-byte eeprom...

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-20 Thread Loic Poulain
Hi Johan, Srini, On 19 June 2018 at 15:06, Johan Hovold wrote: > On Tue, Jun 19, 2018 at 02:32:11PM +0200, Loic Poulain wrote: >> Hi Johan, Srini, >> >> On 18 June 2018 at 11:47, Srinivas Kandagatla >> wrote: >> > On 18/06/18 09:46, Johan Hovold wrote: > >> >> I'm not necessarily against the

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-19 Thread Johan Hovold
On Tue, Jun 19, 2018 at 02:32:11PM +0200, Loic Poulain wrote: > Hi Johan, Srini, > > On 18 June 2018 at 11:47, Srinivas Kandagatla > wrote: > > On 18/06/18 09:46, Johan Hovold wrote: > >> I'm not necessarily against the idea, but nvmem core needs to be fixed > >> so that it can handle

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-19 Thread Loic Poulain
Hi Johan, Srini, On 18 June 2018 at 11:47, Srinivas Kandagatla wrote: > > > On 18/06/18 09:46, Johan Hovold wrote: >> >> On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: >>> >>> Most of FTDI's devices have an EEPROM which records FTDI devices >>> configuration setting (e.g. the VID,

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-18 Thread Srinivas Kandagatla
On 18/06/18 09:46, Johan Hovold wrote: On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-18 Thread Johan Hovold
On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: > Most of FTDI's devices have an EEPROM which records FTDI devices > configuration setting (e.g. the VID, PID, I/O config...) and user > data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048-byte > eeprom... > > This patch adds

[PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-14 Thread Loic Poulain
Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048-byte eeprom... This patch adds support for FTDI EEPROM read/write via USB control transfers and register