Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-07 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: As far as I know, except switching in kernel, there isn't any mode switch solution on Android now. Do you have any good ideas for the mode switch on Android system? Josh, the usb_modeswitch maintainer, is also maintaining

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-07 Thread Josua Dietze
Am 07.03.2013 13:19, schrieb Bjørn Mork: it looks like your app will need to be a member of the usb group to do this. I assume there is a way for an app to request such permissions in Android. Josh has obviously managed to get it. Actually, the PPP Widget app requires access to a root shell

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-06 Thread Dan Williams
On Wed, 2013-03-06 at 09:44 +0800, Greg KH wrote: On Wed, Mar 06, 2013 at 01:34:44AM +, Linlei (Lei Lin) wrote: Hello Mork, -- Because in the embedded linux system, Android, or Chrome OS, etc. They don't integrate userspace usb_modeswitch utility for switching. Why

RE: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-06 Thread Fangxiaozhi (Franko)
) Subject: Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression On Wed, 2013-03-06 at 09:44 +0800, Greg KH wrote: On Wed, Mar 06, 2013 at 01:34:44AM +, Linlei (Lei Lin) wrote: Hello Mork, -- Because in the embedded linux system, Android, or Chrome OS, etc

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-06 Thread Greg KH
On Thu, Mar 07, 2013 at 02:54:38AM +, Fangxiaozhi (Franko) wrote: Dear All: As far as I know, except switching in kernel, there isn't any mode switch solution on Android now. Do you have any good ideas for the mode switch on Android system? Please discuss this with the Android

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Monday 04 March 2013 23:28:47 Josua Dietze wrote: I guess the real problem will be verifying that all of the entries can go away. This type of hardware tends to get old very fast, but there is always someone having a really ancient device. I will check this and add any missing USB IDs

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago that this functionality belongs in userspace. Ref e.g

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 04 March 2013 23:28:47 Josua Dietze wrote: I guess the real problem will be verifying that all of the entries can go away. This type of hardware tends to get old very fast, but there is always someone having a really ancient device. I will

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that

答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Linlei (Lei Lin)
@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying (Zihan); Linlei (Lei Lin); Greg KH; Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); ba...@ti.com; mdharm-...@one-eyed-alien.net; sebast...@breakpoint.cc; stable 主题: Re: [PATCH] USB: storage: fix Huawei mode switching regression

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Greg KH
On Wed, Mar 06, 2013 at 01:34:44AM +, Linlei (Lei Lin) wrote: Hello Mork, -- Because in the embedded linux system, Android, or Chrome OS, etc. They don't integrate userspace usb_modeswitch utility for switching. Why not? If they can upgrade the kernel, then they most

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Ben Hutchings
On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode switching was deprecated years ago with the development of the more user friendly userspace alternatives. The existing list of devices in usb-storage was only kept to prevent breaking already working systems. The long

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Ben Hutchings b...@decadent.org.uk writes: On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode switching was deprecated years ago with the development of the more user friendly userspace alternatives. The existing list of devices in usb-storage was only kept to prevent

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Matthew Dharm
Frankly, I consider it appropriate. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed that the Huawei guys had

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Matthew Dharm mdharm-...@one-eyed-alien.net writes: Frankly, I consider it appropriate. OK, I'll try to cook something up. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Josua Dietze
Am 04.03.2013 20:22, schrieb Bjørn Mork: Matthew Dharm mdharm-...@one-eyed-alien.net writes: The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it

RE: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Fangxiaozhi (Franko)
); ba...@ti.com; mdharm-...@one-eyed-alien.net; sebast...@breakpoint.cc; Bjørn Mork; stable Subject: [PATCH] USB: storage: fix Huawei mode switching regression This reverts commit 200e0d99 (USB: storage: optimize to match the Huawei USB storage devices and support new switch command