Please integrate the fixes Francois has proposed.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2013-08-30 at 01:06 +0200, Francois Romieu wrote:
just trivia:
> diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
[]
> @@ -288,19 +291,19 @@ static void sr9700_set_multicast(struct net_device *net)
[]
> +static int sr9700_set_mac_address(struct net_device *netdev, void *p)
Liu, please check those.
---
drivers/net/usb/sr9700.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index 3f05b35..3ae3caf 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/sr9700.c
@@ -99,8 +99,9 @@ static i
Keep it small though literate.
---
drivers/net/usb/sr9700.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index f7f46e6..3f05b35 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/s
- use all columns
- the driver uses both 'netdev' and 'net'. Let's use 'netdev' ('net' is
shorter but it tastes of network namespaces)
- don't dereference dev->net when there is a local netdev at hand
- use some existing #define (please check those)
- skb_set_tail_pointer to avoid compiler cast w
From: Liu Junliang
Signed-off-by: Liu Junliang
---
drivers/net/usb/Kconfig |8 +
drivers/net/usb/Makefile |1 +
drivers/net/usb/sr9700.c | 558 ++
drivers/net/usb/sr9700.h | 172 ++
4 files changed, 739 insertions(+), 0 deletio
From: liujunliang_...@163.com
Date: Sat, 24 Aug 2013 19:26:00 +0800
> From: liujl
Your proper name is not "liujl", please put something more reasonable
here and also in your Signoff.
Also, integrate Joe Perches's white space fixes into this patch as part
of your resubmission.
Thank you.
--
To
Some whitespace and neatening fixups.
Some conversions from 4 indent tabs to normal tabs
Signed-off-by: Joe Perches
---
Just doing this instead of commenting about spacing
again.
drivers/net/usb/sr9700.c | 127 +--
1 file changed, 67 insertions(+), 60
From: liujl
Signed-off-by: liujl
---
drivers/net/usb/Kconfig |8 +
drivers/net/usb/Makefile |1 +
drivers/net/usb/sr9700.c | 551 ++
drivers/net/usb/sr9700.h | 172 ++
4 files changed, 732 insertions(+), 0 deletions(-)
create