Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Laurent Pinchart
Hi Joel, On Wednesday, 21 March 2018 11:53:45 EET Joel Pepper wrote: > Hi Laurent, > > Thanks for the heads up. I noticed the goof with Patch v3 right after > sending, but apparently I screwed up the commit amend too. I'm still > getting accustomed to kernel development. Sorry for wasting your

Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Laurent Pinchart
Hi Joel, Thank you for the patch. On Tuesday, 20 March 2018 22:28:53 EET Joel Pepper wrote: > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. > - Automatically assign ascending bFrameIndex to each frame in a format. > > Before all "bFrameindex" attributes were set to "1" with no

[PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-20 Thread Joel Pepper
- Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. - Automatically assign ascending bFrameIndex to each frame in a format. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1

Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-19 Thread Greg KH
On Mon, Mar 19, 2018 at 11:55:02AM +0100, Joel Pepper wrote: > This adds bFrameIndex as a UVCG_FRAME_ATTR for each frame size. > Beforehand all bFrameindex were set to "1" with no way to configure the > gadget otherwise. > > This resulted in the host always negotiating for bFrameIndex 1 (i.e.

[PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-19 Thread Joel Pepper
This adds bFrameIndex as a UVCG_FRAME_ATTR for each frame size. Beforehand all bFrameindex were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget). After the negotiation the host driver