RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Ivan T. Ivanov
Hi, On Fri, 2013-07-26 at 02:06 +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, July 25, 2013 1:52 PM On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 09:48:26AM +0300, Ivan T. Ivanov wrote: Also, this is not *modifying* what was passed, just skipping the xHCI address space so we don't request_mem_region() an area we won't really handle and prevent xhci-hcd.ko from probing. Hmm? platform_get_resource()

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, July 26, 2013 2:54 AM Also, this is not *modifying* what was passed, just skipping the xHCI address space so we don't request_mem_region() an area we won't really handle and prevent xhci-hcd.ko from probing. Hmm?

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 06:44:23PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, July 26, 2013 2:54 AM Also, this is not *modifying* what was passed, just skipping the xHCI address space so we don't request_mem_region() an area we won't

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, July 26, 2013 1:32 PM On Fri, Jul 26, 2013 at 06:44:23PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, July 26, 2013 2:54 AM Also, this is not *modifying* what was passed, just skipping

[PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving the above operations after driver

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Sergei Shtylyov
On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
On Thu, 2013-07-25 at 21:21 +0400, Sergei Shtylyov wrote: On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable,

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Paul Zimmerman
From: Ivan T. Ivanov Sent: Thursday, July 25, 2013 9:27 AM When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving the above

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 607bef8..50c833f 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -384,21 +384,6 @@ static int dwc3_probe(struct platform_device

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, July 25, 2013 1:52 PM On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 607bef8..50c833f 100644 --- a/drivers/usb/dwc3/core.c +++