Re: [PATCH] usb: ehci-platform: use helper variables in probe function

2016-07-14 Thread Alan Stern
On Thu, 14 Jul 2016, Rafał Miłecki wrote: > > Okay except for... > > > >> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node, > >> - "phys", "#phy-cells"); > >> + priv->num_phys = of_count_phandle_with_args(np, "phys", > >> +

Re: [PATCH] usb: ehci-platform: use helper variables in probe function

2016-07-14 Thread Rafał Miłecki
On 14 July 2016 at 16:11, Alan Stern wrote: > On Wed, 13 Jul 2016, Rafał Miłecki wrote: > >> Probing function was using >dev and dev->dev.of_node over 20 times >> so I believe it made sense to use helper variables for both of them. >> To avoid some uncommon variable

Re: [PATCH] usb: ehci-platform: use helper variables in probe function

2016-07-14 Thread Alan Stern
On Wed, 13 Jul 2016, Rafał Miłecki wrote: > Probing function was using >dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev variable with pdev. > >

[PATCH] usb: ehci-platform: use helper variables in probe function

2016-07-13 Thread Rafał Miłecki
Probing function was using >dev and dev->dev.of_node over 20 times so I believe it made sense to use helper variables for both of them. To avoid some uncommon variable name for struct device I first replaced existing dev variable with pdev. Signed-off-by: Rafał Miłecki ---