[PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org --- drivers/usb/host/ehci-s5p.c | 4 +++- 1 file changed, 3

Re: [PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Jingoo Han
On Wednesday, March 13, 2013 4:03 AM, Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org

Re: [PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
Jingoo, On Thu, Mar 14, 2013 at 5:30 PM, Jingoo Han jg1@samsung.com wrote: Would you replace other 'pdev-dev' with 'dev' in s5p_setup_vbus_gpio() as below? It seems to be better for readability. Yes, of course. That was silly of me not to add the dev local and not update the other