Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-26 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: That's what the code does today, and I wasn't trying to second-guess their decisions on that.

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-26 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 09:23:35AM -0700, Olof Johansson wrote: On Fri, Jul 26, 2013 at 2:54 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-26 Thread Olof Johansson
On Fri, Jul 26, 2013 at 1:30 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jul 26, 2013 at 09:23:35AM -0700, Olof Johansson wrote: On Fri, Jul 26, 2013 at 2:54 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 10:19

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] I switched from ? : to !! mostly to save from

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Olof Johansson
On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34:

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Olof Johansson
On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: That's what the code does today, and I wasn't trying to second-guess their decisions on that. Chances are firmware, in some instances, have left power on so

[PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-23 Thread Olof Johansson
This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] I switched from ? : to !! mostly to save from wrapping the lines while I was at it. Signed-off-by: Olof Johansson