Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-06 Thread Felipe Balbi
Hi Jim, Jim Lin writes: > On 2016年05月04日 18:37, Felipe Balbi wrote: >> * PGP Signed by an unknown key >> >> >> Hi, >> >> Jim Lin writes: >> >> >> > In f_fs.c > " > static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, >

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigned len, void

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigned len, void

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-04 Thread Felipe Balbi
Hi, Jim Lin writes: >>> In f_fs.c >>> " >>> static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, >>>struct usb_os_desc_header *h, void *data, >>>unsigned len, void *priv) >>> { >>> struct ffs_data *ffs = priv; >>>

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-04 Thread Jim Lin
On 2016年04月29日 19:57, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sridharan

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-02 Thread Felipe Balbi
Hi, Mathias Nyman writes: >>> dmesg from PC host side (after adding your change without my patch): >>> >>> [17907.984647] usb 6-2: new SuperSpeed USB device number 54 using xhci_hcd >>> [17908.012036] usb 6-2: No SuperSpeed endpoint companion for config 1 >>>

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-29 Thread Mathias Nyman
On 28.04.2016 15:21, Felipe Balbi wrote: Hi, dmesg from PC host side (after adding your change without my patch): [17907.984647] usb 6-2: new SuperSpeed USB device number 54 using xhci_hcd [17908.012036] usb 6-2: No SuperSpeed endpoint companion for config 1 interface 1 altsetting 0 ep 2:

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-29 Thread Felipe Balbi
Hi, Jim Lin writes: > On 2016年04月28日 20:21, Felipe Balbi wrote: >>> >>> I also attach git log of system/core/adb/usb_linux_client.cpp of Android >>> N for your reference. >>> " >>> Author: Badhri Jagan Sridharan >>> Date: Mon Oct 5 13:04:03 2015 -0700 >>>

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-29 Thread Jim Lin
On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sridharan Date: Mon Oct 5 13:04:03 2015 -0700 adbd: Add os descriptor support for adb. Eventhough

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-28 Thread Felipe Balbi
Hi, Jim Lin writes: > On 2016年04月25日 20:01, Felipe Balbi wrote: Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed which means

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-28 Thread Jim Lin
rdware/gg463179.aspx " How do we proceed on this patch? [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Thanks, --nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-26 Thread Jim Lin
On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed which means function_descriptors() should

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-25 Thread Felipe Balbi
Hi, Jim Lin writes: > On 2016年04月22日 19:52, Felipe Balbi wrote: >> * PGP Signed by an unknown key >> >> >> Hi Jim, >> >> Jim Lin writes: >>> Android N adds os_desc_compat in v2_descriptor by init_functionfs() >>> (system/core/adb/usb_linux_client.cpp) to

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-25 Thread Jim Lin
On 2016年04月22日 19:52, Felipe Balbi wrote: * PGP Signed by an unknown key Hi Jim, Jim Lin writes: Android N adds os_desc_compat in v2_descriptor by init_functionfs() (system/core/adb/usb_linux_client.cpp) to support automatic install of MTP driver on Windows for USB device

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-22 Thread Felipe Balbi
Hi Jim, Jim Lin writes: > Android N adds os_desc_compat in v2_descriptor by init_functionfs() > (system/core/adb/usb_linux_client.cpp) to support automatic install > of MTP driver on Windows for USB device mode. > > Current __ffs_data_do_os_desc() of f_fs.c will check

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-22 Thread Lars-Peter Clausen
On 04/22/2016 12:43 PM, Jim Lin wrote: > Android N adds os_desc_compat in v2_descriptor by init_functionfs() > (system/core/adb/usb_linux_client.cpp) to support automatic install > of MTP driver on Windows for USB device mode. > > Current __ffs_data_do_os_desc() of f_fs.c will check reserved1

[PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-22 Thread Jim Lin
Android N adds os_desc_compat in v2_descriptor by init_functionfs() (system/core/adb/usb_linux_client.cpp) to support automatic install of MTP driver on Windows for USB device mode. Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field and return -EINVAL. This results in a second