Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-18 Thread Alan Stern
On Tue, 18 Jun 2013, Yuan-Hsin Chen wrote: In that case, no, you should be figuring out how to refactor and reuse the EHCI code instead of copying it straight into your driver. I was trying to use ehci-platform.c, anonymous union/struct, and quirk flags to avoid copying EHCI code. But

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-18 Thread Greg KH
On Tue, Jun 18, 2013 at 10:42:09AM +0800, Yuan-Hsin Chen wrote: Hi, On Tue, Jun 18, 2013 at 4:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Greg KH
On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register layout of FOTG210 is incompatible with EHCI. Furthermore, FOTG210 is lack of

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Yuan-Hsin Chen
Hi, On Tue, Jun 18, 2013 at 4:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Sarah Sharp
On Tue, Jun 18, 2013 at 10:42:09AM +0800, Yuan-Hsin Chen wrote: Hi, On Tue, Jun 18, 2013 at 4:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Yuan-Hsin Chen
Hi, On Tue, Jun 18, 2013 at 11:07 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Tue, Jun 18, 2013 at 10:42:09AM +0800, Yuan-Hsin Chen wrote: Hi, On Tue, Jun 18, 2013 at 4:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen