Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-25 Thread Sebastian Andrzej Siewior
On 11/25/2014 02:09 AM, Felipe Balbi wrote: I *think* for some reason the host did not really receive ep0 set_config request as planned. And device's answer is probably then interpreted as data which is not expected (as Felipe said device side tries to move data without the host asking for

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-25 Thread Felipe Balbi
Hi, On Tue, Nov 25, 2014 at 09:24:46AM +0100, Sebastian Andrzej Siewior wrote: On 11/25/2014 02:09 AM, Felipe Balbi wrote: I *think* for some reason the host did not really receive ep0 set_config request as planned. And device's answer is probably then interpreted as data which is not

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/18/2014 10:17 PM, Felipe Balbi wrote: while this helps the situation it doesn't solve the problem I'm having with testusb on BBB when host port is connected to peripheral port on the same BBB. Exactly. On the same device. I see the same problem if I connect host to peripheral port on

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/18/2014 10:17 PM, Felipe Balbi wrote: I think the driver is mis-detecting Babble. A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… Sebastian -- To

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 06:49:50PM +0100, Sebastian Andrzej Siewior wrote: On 11/18/2014 10:17 PM, Felipe Balbi wrote: I think the driver is mis-detecting Babble. A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Peter Stuge
Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… hmm, why would the device move more than wMaxPacketSize at a time ?

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/24/2014 09:39 PM, Peter Stuge wrote: Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… hmm, why would the device move more

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 09:56:28PM +0100, Sebastian Andrzej Siewior wrote: On 11/24/2014 09:39 PM, Peter Stuge wrote: Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled. Sometimes this could even end up in an

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Bin Liu
Felipe, On Tue, Nov 18, 2014 at 3:17 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 06:44:39PM -0600, Bin Liu wrote: Felipe, On Tue, Nov 18, 2014 at 3:17 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are

[PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread George Cherian
Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled. Sometimes this could even end up in an endless loop making MUSB itself unusable. Reported-by: Felipe Balbi

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread Sebastian Andrzej Siewior
On 11/14/2014 09:24 AM, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled. Sometimes this could even end up in an endless loop making

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread George Cherian
On 11/14/2014 02:12 PM, Sebastian Andrzej Siewior wrote: On 11/14/2014 09:24 AM, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled.

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 02:41:57PM +0530, George Cherian wrote: On 11/14/2014 02:12 PM, Sebastian Andrzej Siewior wrote: On 11/14/2014 09:24 AM, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple