In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyj...@gmail.com>
---
 drivers/usb/usbip/vhci_hcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 96f2dac..03eccf2 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1211,8 +1211,8 @@ static int add_platform_device(int id)
                dev_nr = id;
 
        pdev = platform_device_register_simple(driver_name, dev_nr, NULL, 0);
-       if (pdev == NULL)
-               return -ENODEV;
+       if (IS_ERR(pdev))
+               return PTR_ERR(pdev);
 
        *(vhci_pdevs + id) = pdev;
        return 0;



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to