[PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

UVC is a little different from other configfs consumers in that it wants different function and field names from the exposed attribute name, so it keeps it's local macros to define attributes instead of using the common ones. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej

Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

Hi Christoph, please see my comments inline. With the issues addressed you can add Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: UVC is a little different from other configfs consumers in that it wants different function and

Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

On Mon, Sep 28, 2015 at 01:35:38PM +0200, Andrzej Pietrasiewicz wrote: >> -#define UVCG_STREAMING_CONTROL_SIZE 1 > > Moving this define seems an unrelated change to me. I can move it back - this one wasn't intentional. >> +#define identity_conv(x) (x) > > What is this needed for here? > > This