From: Bjørn Mork bj...@mork.no
Date: Wed, 25 Sep 2013 15:31:39 +0200
Sorry, I really don't see the point of this. Yes, the lines are longer
than 80 columns, but breaking them don't improve the readability at
all. On the contrary, IMHO.
So NAK from me for this part.
Sorry, breaking things
From: Fabio Porcedda fabio.porce...@gmail.com
Date: Wed, 25 Sep 2013 11:21:26 +0200
Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com
Applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
Hi Bjørn,
thanks for reviewing.
On Wed, Sep 25, 2013 at 3:31 PM, Bjørn Mork bj...@mork.no wrote:
Sorry, I really don't see the point of this. Yes, the lines are longer
than 80 columns, but breaking them don't improve the readability at
all. On the contrary, IMHO.
So NAK from me for this
Fabio Porcedda fabio.porce...@gmail.com writes:
Hi Bjørn,
thanks for reviewing.
On Wed, Sep 25, 2013 at 3:31 PM, Bjørn Mork bj...@mork.no wrote:
Sorry, I really don't see the point of this. Yes, the lines are longer
than 80 columns, but breaking them don't improve the readability at
all.
Anything that breaks a previously unbroken argument list will reduce the
readability in my opinion. The lines can of course not be unlimited,
but there is no need to set the limit as low as 80 columns. Feedback
I've got from developers using e.g. 80 column braille devices is that
longer
Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com
---
drivers/net/usb/qmi_wwan.c | 56 +-
1 file changed, 36 insertions(+), 20 deletions(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 5f6b6fa..0e59f9e 100644
---
Sorry, I really don't see the point of this. Yes, the lines are longer
than 80 columns, but breaking them don't improve the readability at
all. On the contrary, IMHO.
So NAK from me for this part.
Bjørn
Fabio Porcedda fabio.porce...@gmail.com writes:
Signed-off-by: Fabio Porcedda
