Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 19:45 +0200, Hans de Goede wrote: > Hi, > > Thanks for the quick review! > > On 10/09/2013 07:00 PM, Oliver Neukum wrote: > > On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: > > > >> So I have come up with this patch instead, which adds the ability to > >> suspend wa

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: > usb_wait_anchor_empty_timeout() should wait till the completion handler > has run. Both the zd1211rw driver and the uas driver (in its task mgmt) depend > on the completion handler having completed when > usb_wait_anchor_empty_timeout() > r

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Hans de Goede
Hi, Thanks for the quick review! On 10/09/2013 07:00 PM, Oliver Neukum wrote: On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor functionality

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: > So I have come up with this patch instead, which adds the ability to > suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor > functionality, and uses this in __usb_hcd_giveback_urb() to delay wake-ups > until the com

[PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Hans de Goede
usb_wait_anchor_empty_timeout() should wait till the completion handler has run. Both the zd1211rw driver and the uas driver (in its task mgmt) depend on the completion handler having completed when usb_wait_anchor_empty_timeout() returns, as they read state set by the completion handler after an u