Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-03-02 Thread Bin Liu
Hi, On Mon, Feb 23, 2015 at 9:02 AM, Andrzej Pietrasiewicz andrze...@samsung.com wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but the printer function encodes the interface number in

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-03-02 Thread Andrzej Pietrasiewicz
W dniu 02.03.2015 o 23:03, Bin Liu pisze: Hi, On Mon, Feb 23, 2015 at 9:02 AM, Andrzej Pietrasiewicz andrze...@samsung.com wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but the printer

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-03-02 Thread Andrzej Pietrasiewicz
W dniu 27.02.2015 o 21:58, Felipe Balbi pisze: Hi, On Fri, Feb 27, 2015 at 02:55:25PM -0600, Felipe Balbi wrote: On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-03-02 Thread Andrzej Pietrasiewicz
W dniu 27.02.2015 o 21:55, Felipe Balbi pisze: On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but the printer function

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-03-02 Thread Bin Liu
Hi, On Mon, Mar 2, 2015 at 2:38 AM, Andrzej Pietrasiewicz andrze...@samsung.com wrote: W dniu 27.02.2015 o 21:58, Felipe Balbi pisze: Hi, On Fri, Feb 27, 2015 at 02:55:25PM -0600, Felipe Balbi wrote: On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote: Non-standard

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-02-27 Thread Felipe Balbi
Hi, On Fri, Feb 27, 2015 at 02:55:25PM -0600, Felipe Balbi wrote: On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but

Re: [PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-02-27 Thread Felipe Balbi
On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote: Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but the printer function encodes the interface number in a context-dependet

[PATCH 20/29] usb: gadget: composite: add req_match method to usb_function

2015-02-23 Thread Andrzej Pietrasiewicz
Non-standard requests can encode the actual interface number in a non-standard way. For example composite_setup() assumes that it is w_index 0xFF, but the printer function encodes the interface number in a context-dependet way (either w_index or w_index 8). This can lead to such requests being