Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Paul Bolle
Just a few nits, I'm afraid. On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote: --- /dev/null +++ b/drivers/usb/serial/f81534.c +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) +{ + [...] +} static? +void f81534_gpio_free(struct gpio_chip *chip, unsigned offset)

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Peter Hung
Hi Paul Johan Paul Bolle 於 2015/7/15 下午 04:36 寫道: Just a few nits, I'm afraid. +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) +{ + [...] +} static? Thanks Paul for point this out. And sorry for Johan. It's seems to make a new patch V5. I'll merge some minor fix

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Johan Hovold
On Wed, Jul 15, 2015 at 04:55:19PM +0800, Peter Hung wrote: Hi Paul Johan Paul Bolle 於 2015/7/15 下午 04:36 寫道: Just a few nits, I'm afraid. +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) +{ + [...] +} static? Thanks Paul for point this out. And sorry for

[PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-13 Thread Peter Hung
This driver is for Fintek F81532/F81534 USB to Serial Ports IC. Features: 1. F81534 is 1-to-4 F81532 is 1-to-2 serial ports IC 2. Support Baudrate from B50 to B150 (excluding B100). 3. The RTS signal can be transformed their behavior with configuration by default ioctl