Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-03 Thread David Miller
From: Eric Dumazet Date: Thu, 01 Aug 2013 06:52:45 -0700 > On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: >> From: Eric Dumazet >> >> ax88179_tx_fixup() has quite complex code trying to push 8 bytes >> of control data (len/mss), but fails to do it properly for TCP packets, >> incurring

Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > ax88179_tx_fixup() has quite complex code trying to push 8 bytes > of control data (len/mss), but fails to do it properly for TCP packets, > incurring an extra copy and point of memory allocation failure. I forgot to

[PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
From: Eric Dumazet ax88179_tx_fixup() has quite complex code trying to push 8 bytes of control data (len/mss), but fails to do it properly for TCP packets, incurring an extra copy and point of memory allocation failure. Lets use the simple and approved way. dev->needed_headroom being 8, all fra