Re: [PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2017-01-02 Thread Johan Hovold
On Mon, Dec 19, 2016 at 12:11:15PM +0100, Johan Hovold wrote: > On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote: > > With gcc 4.1.2: > > > > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: > > drivers/usb/serial/f81534.c:1250: warning: comparison is always

Re: [PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-19 Thread Johan Hovold
On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote: > With gcc 4.1.2: > > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: > drivers/usb/serial/f81534.c:1250: warning: comparison is always false due > to limited range of data type > >

[PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-18 Thread Geert Uytterhoeven
With gcc 4.1.2: drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: drivers/usb/serial/f81534.c:1250: warning: comparison is always false due to limited range of data type f81534_logic_to_phy_port() may return a negative error value, which is ignored by assigning it to u8