On Fri, 18 Jan 2013, Greg KH wrote:
On Sat, Jan 12, 2013 at 11:18:03PM +0800, Chen Gang wrote:
for function uhci_sprint_schedule:
the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough:
may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024)
each time of
于 2013年01月22日 00:17, Alan Stern 写道:
This needs to be broken up into two distinct patches:
One to fix the buffer-overflow problem;
One to get rid of the line breaks in string constants.
Two totally separate goals like these should not be combined into a
single patch...
On Tue, 22 Jan 2013, Chen Gang wrote:
...Also, why did you change the comment in
uhci_debug_lseek?
the original comments exceeds 80 bondary (including '*/').
but exculding '*/', the comments are within 80 bondary.
for me, I think it is better to seperate it into multiple lines.
Hello Alan Stern
When you have time, could you help checking this patch ?
welcome any reasonable rejections, too.
thanks.
gchen.
于 2013年01月19日 07:37, Greg KH 写道:
On Sat, Jan 12, 2013 at 11:18:03PM +0800, Chen Gang wrote:
for function uhci_sprint_schedule:
the buffer len is
for function uhci_sprint_schedule:
the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough:
may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024)
each time of loop may get more than 64 bytes
so need check the buffer length to avoid memory overflow
this patch fix
