Re: [PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 05:20:29PM +0530, Himanshu Jha wrote: > On Tue, Oct 17, 2017 at 11:51:14AM +0200, Greg KH wrote: > > On Fri, Oct 06, 2017 at 08:38:07PM +0530, Himanshu Jha wrote: > > > Use put_unaligned_le32 rather than using byte ordering function and > > > memcpy which makes code clear.

Re: [PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Himanshu Jha
On Tue, Oct 17, 2017 at 11:51:14AM +0200, Greg KH wrote: > On Fri, Oct 06, 2017 at 08:38:07PM +0530, Himanshu Jha wrote: > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is declared. > > > > Done

Re: [PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Greg KH
On Fri, Oct 06, 2017 at 08:38:07PM +0530, Himanshu Jha wrote: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier

[PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-06 Thread Himanshu Jha
Use put_unaligned_le32 rather than using byte ordering function and memcpy which makes code clear. Also, add the header file where it is declared. Done using Coccinelle and semantic patch used is : @ rule1 @ identifier tmp; expression ptr,x; type T; @@ - tmp = cpu_to_le32(x); <+... when !=