Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Fri, 25 Apr 2014 16:07:00 +0200, Gregory CLEMENT wrote: Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the clock, by enabling them during probe and disabling them on remove. As not all platforms

[PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Gregory CLEMENT
Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the clock, by enabling them during probe and disabling them on remove. As not all platforms have clock support then enabling and disabling the clocks have been placed in separate

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Russell King - ARM Linux
On Fri, Apr 25, 2014 at 04:07:00PM +0200, Gregory CLEMENT wrote: +#if defined(CONFIG_HAVE_CLK) +static int try_enable_clk(struct platform_device *pdev) +{ + struct clk *clk = devm_clk_get(pdev-dev, NULL); + + /* Not all platforms have a clk so it is not an error if the clock +

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Gregory CLEMENT
On 25/04/2014 16:15, Thomas Petazzoni wrote: Dear Gregory CLEMENT, On Fri, 25 Apr 2014 16:07:00 +0200, Gregory CLEMENT wrote: Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the clock, by enabling them during probe and

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Gregory CLEMENT
On 25/04/2014 16:44, Gregory CLEMENT wrote: On 25/04/2014 16:15, Thomas Petazzoni wrote: Dear Gregory CLEMENT, On Fri, 25 Apr 2014 16:07:00 +0200, Gregory CLEMENT wrote: Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Felipe Balbi
Hi, On Fri, Apr 25, 2014 at 04:07:00PM +0200, Gregory CLEMENT wrote: Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the clock, by enabling them during probe and disabling them on remove. As not all platforms have clock

Re: [PATCH v2 02/18] usb: host: xhci-plat: Add clocks support

2014-04-25 Thread Andrew Lunn
On Fri, Apr 25, 2014 at 04:07:00PM +0200, Gregory CLEMENT wrote: Some platform (such as the Armada 38x ones) can gate the clock of their USB controller. This patch add the support for the clock, by enabling them during probe and disabling them on remove. As not all platforms have clock