Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-23 Thread Sekhar Nori
On Wednesday 23 March 2016 11:15 PM, David Lechner wrote: > On 03/23/2016 11:56 AM, Sekhar Nori wrote: >>> >>> +static struct clk usb_ref_clk = { >>> +.name= "usb_ref_clk", >>> +.rate= 4800, >>> +.set_rate= davinci_simple_set_rate, >>> +}; >> >> can we call this

Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-23 Thread David Lechner
On 03/23/2016 11:56 AM, Sekhar Nori wrote: +static struct clk usb_ref_clk = { + .name = "usb_ref_clk", + .rate = 4800, + .set_rate = davinci_simple_set_rate, +}; can we call this usb_refclkin so it matches the TRM name? Also, should this node be

Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > Up to this point, the USB phy clock configuration was handled manually in > the board files and in the usb drivers. This adds proper clocks so that > the usb drivers can use clk_get and clk_enable and not have to worry about > the details.

Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 5:26 AM, David Lechner wrote: Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the related

[PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-19 Thread David Lechner
Up to this point, the USB phy clock configuration was handled manually in the board files and in the usb drivers. This adds proper clocks so that the usb drivers can use clk_get and clk_enable and not have to worry about the details. Also, the related code is removed from the board files.